cifs: fix incorrect handling of smb2_set_sparse() return in smb3_simple_falloc
Subsystems (2)
PATCH 1/1 cifs: fix incorrect handling of smb2_set_sparse() return in smb3_simple_falloc
smb2_set_sparse does not return -errno, it returns a boolean where true means success.
Change this to just ignore the return value just like the other callsites.
Additionally add code to handle the case where we must set the file sparse and possibly also extending it.
Signed-off-by Ronnie Sahlberg <[email protected]>
--- fs/cifs/smb2ops.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +11 -2
@@ -2781,9 +2781,18 @@ static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon,return rc; } - rc =smb2_set_sparse (xid, tcon, cfile, inode, false); +smb2_set_sparse (xid, tcon, cfile, inode, false); + rc =0 ; + }else { +smb2_set_sparse (xid, tcon, cfile, inode, false); + rc =0 ; +if (i_size_read (inode) < off + len) { + eof =cpu_to_le64 (off + len); + rc =SMB2_set_eof (xid, tcon, cfile->fid.persistent_fid, + cfile->fid.volatile_fid, cfile->pid, + &eof); + } } -/* BB: else ... in future add code to extend file and set sparse */ if (rc) trace_smb3_falloc_err(xid, cfile->fid.persistent_fid, tcon->tid,
Signature · 1 line
2.13.6