Skip to contentSkip to conversation

vhost: select TAP if VHOST is configured

RFC In review Stephen Hemminger 2 participants 2 messages Mar 13, 2019 – Mar 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC 1/1 vhost: select TAP if VHOST is configured

If VHOST_NET is configured but TUN and TAP are not, then the kernel will build but vhost will not work correctly since it can't setup the necessary tap device.

A solution is to select it.

Fixes 9a393b5d5988 ("tap: tap as an independent module")
---
 drivers/vhost/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/vhost/Kconfig +2 -1
index b580885243f7..a24c69598241 100644
@@ -1,7 +1,8 @@
 config VHOST_NET
 	tristate "Host kernel accelerator for virtio net"
-	depends on NET && EVENTFD && (TUN || !TUN) && (TAP || !TAP)
+	depends on NET && EVENTFD
 	select VHOST
+	select TAP
 	---help---
 	  This kernel module can be loaded in host kernel to accelerate
 	  guest networking with virtio_net. Not to be confused with virtio_net
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Stephen Hemminger

If VHOST_NET is configured but TUN and TAP are not, then the kernel will build but vhost will not work correctly since it can't setup the necessary tap device.

A solution is to select it.

Fixes 9a393b5d5988 ("tap: tap as an independent module")

Well vhost can also work with a SOCK_RAW socket. QEMU userspace does not seem to use that interface pobably because we never got around to adding offload support, but it's there and we don't know that no one else does.

Quoted 20 lines
---
 drivers/vhost/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/vhost/Kconfig +2 -1
index b580885243f7..a24c69598241 100644
@@ -1,7 +1,8 @@
 config VHOST_NET
 	tristate "Host kernel accelerator for virtio net"
-	depends on NET && EVENTFD && (TUN || !TUN) && (TAP || !TAP)
+	depends on NET && EVENTFD
 	select VHOST
+	select TAP
 	---help---
 	  This kernel module can be loaded in host kernel to accelerate
 	  guest networking with virtio_net. Not to be confused with virtio_net
Signature · 1 line
2.17.1