Skip to contentSkip to conversation

Use radeon_finish in drmmode_crtc_scanout_update

PATCH In review Michel Dänzer 3 participants 3 messages Mar 14, 2019 – Mar 15, 2019 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use radeon_finish in drmmode_crtc_scanout_update

From: Michel Dänzer <[email protected]>

radeon_glamor_finish only works if we're using glamor, otherwise it'll crash.

Fixes ce7db51020d3 "Cancel pending scanout update in drmmode_crtc_scanout_update"
---
 src/drmmode_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/drmmode_display.c +1 -1
index c5fccd2aa..002513f1a 100644
@@ -785,7 +785,7 @@ drmmode_crtc_scanout_update(xf86CrtcPtr crtc, DisplayModePtr mode,
 					     screen->GetWindowPixmap(screen->root),
 					     extents)) {
 			RegionEmpty(DamageRegion(drmmode_crtc->scanout_damage));
-			radeon_glamor_finish(scrn);
+			radeon_finish(scrn, drmmode_crtc->scanout[scanout_id].bo);
 
 			if (!drmmode_crtc->flip_pending) {
 				radeon_drm_abort_entry(drmmode_crtc->
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20190314101542.2984-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by
#2 lore raw

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Michel Dänzer <[email protected]>
Sent: Thursday, March 14, 2019 6:15 AM
To: [email protected]
Subject: [PATCH xf86-video-ati] Use radeon_finish in drmmode_crtc_scanout_update

From: Michel Dänzer <[email protected]>

radeon_glamor_finish only works if we're using glamor, otherwise it'll crash.

Fixes ce7db51020d3 "Cancel pending scanout update in drmmode_crtc_scanout_update"
---
 src/drmmode_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/drmmode_display.c +1 -1
index c5fccd2aa..002513f1a 100644
@@ -785,7 +785,7 @@ drmmode_crtc_scanout_update(xf86CrtcPtr crtc, DisplayModePtr mode,
                                              screen->GetWindowPixmap(screen->root),
                                              extents)) {
                         RegionEmpty(DamageRegion(drmmode_crtc->scanout_damage));
-                       radeon_glamor_finish(scrn);
+                       radeon_finish(scrn, drmmode_crtc->scanout[scanout_id].bo);
 
                         if (!drmmode_crtc->flip_pending) {
                                 radeon_drm_abort_entry(drmmode_crtc->

--
2.20.1

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#3 lore raw

Re: Bug#924540: [PATCH xf86-video-ati] Use radeon_finish in drmmode_crtc_scanout_update

In reply to a message not in the archive
Quoted 9 lines · Michel Dänzer

From: Michel Dänzer <[email protected]>

radeon_glamor_finish only works if we're using glamor, otherwise it'll crash.

Fixes ce7db51020d3 "Cancel pending scanout update in drmmode_crtc_scanout_update"
Quoted 20 lines
---
 src/drmmode_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/drmmode_display.c +1 -2
index c5fccd2aa..002513f1a 100644
@@ -785,7 +785,7 @@ drmmode_crtc_scanout_update(xf86CrtcPtr crtc, DisplayModePtr mode,
                                             screen->GetWindowPixmap(screen->root),
                                             extents)) {
                        RegionEmpty(DamageRegion(drmmode_crtc->scanout_damage));
-                       radeon_glamor_finish(scrn);
+                       radeon_finish(scrn, drmmode_crtc->scanout[scanout_id].bo);
 
                        if (!drmmode_crtc->flip_pending) {
                                radeon_drm_abort_entry(drmmode_crtc->
--

2.20.1

Quoted 4 lines

_______________________________________________
xorg-driver-ati mailing list
[email protected]
https://lists.x.org/mailman/listinfo/xorg-driver-ati

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx