clk: mvebu: armada-37xx-periph: Fix initialization for cpu clocks
Subsystems (3)
Gregory CLEMENT
maintainerPATCH 1/1 clk: mvebu: armada-37xx-periph: Fix initialization for cpu clocks
The clock parenting was not setup properly when DVFS was enabled. It was expected that the same clock source was used with and without DVFS which was not the case.
This patch fixes this issue, allowing to make the cpufreq support work when the CPU clocks source are not the default ones.
--- drivers/clk/mvebu/armada-37xx-periph.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/clk/mvebu/armada-37xx-periph.c +11 -0
@@ -671,6 +671,17 @@ static int armada_3700_add_composite_clk(const struct clk_periph_data *data, map =syscon_regmap_lookup_by_compatible ("marvell,armada-3700-nb-pm" ); pmcpu_clk->nb_pm_base = map; + +/* +* Use the same parent when DVFS is enabled that the +* default parent received at boot time. When this +* function is called, DVFS is not enabled yet, so we +* get the default parent and we can set the parent +* for DVFS. +*/ +if (clk_pm_cpu_set_parent (muxrate_hw, +clk_pm_cpu_get_parent (muxrate_hw))) +dev_warn (dev,"Failed to setup default parent clock for DVFS\n" ); } *hw = clk_hw_register_composite(dev, data->name, data->parent_names,
Signature · 1 line
2.20.1
Hi Gregory,
Quoted 41 lines
The clock parenting was not setup properly when DVFS was enabled. It was expected that the same clock source was used with and without DVFS which was not the case.
This patch fixes this issue, allowing to make the cpufreq support work when the CPU clocks source are not the default ones.
Fixes 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx")Cc <[email protected]>Reported-by Christian Neubert <[email protected]>Reported-by Ilias Apalodimas <[email protected]>Signed-off-by Gregory CLEMENT <[email protected]>--- drivers/clk/mvebu/armada-37xx-periph.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/clk/mvebu/armada-37xx-periph.c +11
-0@@ -671,6 +671,17 @@ static int armada_3700_add_composite_clk(const struct clk_periph_data *data, map =syscon_regmap_lookup_by_compatible ("marvell,armada-3700-nb-pm" ); pmcpu_clk->nb_pm_base = map; + +/* +* Use the same parent when DVFS is enabled that the +* default parent received at boot time. When this +* function is called, DVFS is not enabled yet, so we +* get the default parent and we can set the parent +* for DVFS. +*/ +if (clk_pm_cpu_set_parent (muxrate_hw, +clk_pm_cpu_get_parent (muxrate_hw))) +dev_warn (dev,"Failed to setup default parent clock for DVFS\n" ); } *hw = clk_hw_register_composite(dev, data->name, data->parent_names,Signature · 1 line
2.20.1
Applied this and selected only
CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_POWERSAVE=y
After changing the governor from 'powersave' to 'performance' the board completely froze (i even lost access to the serial port)
Cheers
/Ilias
A message that is not in the archive (sent off-list or not yet received): CAC5LXJcCs4nr-qFOWzUJpUBAJ9ngG-cgeTCVCFBKFc1SPzHMuQ@mail.gmail.com
Hello Christian,
Quoted 8 lines
Hi,
I assume you use the 1000 MHz firmware. This does also not work on my Rev 7 board. But I'm pretty sure this is not a problem of the patches, because if I take a newer kernel (4.19.20/27) without the patches it also does not work. A kernel 4.19.17 does work for me. My opinion on that is that this is another problem which does just occure now because now the cpu frequency scaling is working with the right frequencies.
I am not sure which firmware i am running, i did all my tests on 5.0.0 and changing between governors worked fine without the patches
Regards
/Ilias
Quoted 63 lines
Ilias Apalodimas <[email protected]> schrieb am Do., 14. März 2019, 13:15:
Quoted 59 lines
Hi Gregory,
Quoted 12 lines
The clock parenting was not setup properly when DVFS was enabled. It was expected that the same clock source was used with and without DVFS which was not the case.
This patch fixes this issue, allowing to make the cpufreq support work when the CPU clocks source are not the default ones.
Fixes 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx")Cc <[email protected]>Reported-by Christian Neubert <[email protected]>Reported-by Ilias Apalodimas <[email protected]>Signed-off-by Gregory CLEMENT <[email protected]>Review
Quoted 5 lines
--- drivers/clk/mvebu/armada-37xx-periph.c | 11 +++++++++++ 1 file changed, 11 insertions(+)(quoted diff) +0
-0
b/drivers/clk/mvebu/armada-37xx-periph.cdrivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const
Quoted 4 lines
index
1f1cff428d78..26ed3c18a239100644drivers/clk/mvebu/armada-37xx-periph.c +0
-0@@ -671,6 +671,17 @@ static int armada_3700_add_composite_clk(conststruct
clk_periph_data*data,drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const struct clk_periph_data *data,
Quoted 13 lines
drivers/clk/mvebu/armada-37xx-periph.c +10
-0map =syscon_regmap_lookup_by_compatible ("marvell,armada-3700-nb-pm" ); pmcpu_clk->nb_pm_base = map; + +/* +* Use the same parent when DVFS is enabled that the +* default parent received at boot time. When this +* function is called, DVFS is not enabled yet, so we +* get the default parent and we can set the parent +* for DVFS. +*/ + if (clk_pm_cpu_set_parent(muxrate_hw, +
clk_pm_cpu_get_parent(muxrate_hw)))drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const · line 684
Quoted 1 line
drivers/clk/mvebu/armada-37xx-periph.c +1
-0+ dev_warn(dev, "Failed to setup default parentclock for DVFS\n");
drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const · line 687
Quoted 3 lines
drivers/clk/mvebu/armada-37xx-periph.c +0
-0} *hw = clk_hw_register_composite(dev, data->name,
data->parent_names,Quoted 3 lines
--
2.20.1Applied this and selected only
CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_POWERSAVE=yAfter changing the governor from 'powersave' to 'performance' the board completely froze (i even lost access to the serial port)
Cheers
/Ilias
A message that is not in the archive (sent off-list or not yet received): CAC5LXJf=f2bZLroSXFkGiF2W=1XzAgb_wwtpvZY7O9xv28wbVA@mail.gmail.com
Hi,
Quoted 7 lines
Hi,
the cpu frequency scaling never worked right (only on the 4.4 kernel from marvell). If you use the 1000 MHz firmware you are running with just 800 MHz (this is the case on my board with a current firmware).
Just have a look what the kernel thinks it is running at (frequency).
Ok, probably my bad here. By 'worked fine' i mean that this didn't lead to any freezes or panics. I know the actual frequency wasn't set properly
Regards
/Ilias
Quoted 91 lines
Regards,
ChristianIlias Apalodimas <[email protected]> schrieb am Do., 14. März 2019, 14:44:
Quoted 84 lines
Hello Christian,
Quoted 3 lines
Hi,
I assume you use the 1000 MHz firmware. This does also not work on my
Rev 7
Quoted 1 line
board. But I'm pretty sure this is not a problem of the patches, because
if
Quoted 2 lines
I take a newer kernel (4.19.20/27) without the patches it also does not work. A kernel 4.19.17 does work for me. My opinion on that is that this
is
Quoted 2 lines
another problem which does just occure now because now the cpu frequency scaling is working with the right frequencies.
I am not sure which firmware i am running, i did all my tests on 5.0.0 and changing between governors worked fine without the patches
Regards
/IliasQuoted 6 lines
Ilias Apalodimas <[email protected]> schrieb am Do., 14. März 2019, 13:15:
Quoted 2 lines
Hi Gregory,
Quoted 1 line
The clock parenting was not setup properly when DVFS was enabled. It
was
Quoted 1 line
Quoted 1 line
Quoted 1 line
expected that the same clock source was used with and without DVFS
which
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
was not the case.
This patch fixes this issue, allowing to make the cpufreq support
work
Quoted 53 lines
Quoted 53 lines
Quoted 7 lines
when the CPU clocks source are not the default ones.
Fixes 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx")Cc <[email protected]>Reported-by Christian Neubert <[email protected]>Reported-by Ilias Apalodimas <[email protected]>Signed-off-by Gregory CLEMENT <[email protected]>Review
Quoted 5 lines
--- drivers/clk/mvebu/armada-37xx-periph.c | 11 +++++++++++ 1 file changed, 11 insertions(+)(quoted diff) +0
-0
b/drivers/clk/mvebu/armada-37xx-periph.cdrivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const
Quoted 4 lines
index
1f1cff428d78..26ed3c18a239100644drivers/clk/mvebu/armada-37xx-periph.c +0
-0@@ -671,6 +671,17 @@ static int armada_3700_add_composite_clk(conststruct
clk_periph_data*data,drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const struct clk_periph_data *data,
Quoted 13 lines
drivers/clk/mvebu/armada-37xx-periph.c +10
-0map =syscon_regmap_lookup_by_compatible ("marvell,armada-3700-nb-pm" ); pmcpu_clk->nb_pm_base = map; + +/* +* Use the same parent when DVFS is enabled that the +* default parent received at boot time. When this +* function is called, DVFS is not enabled yet, so we +* get the default parent and we can set the parent +* for DVFS. +*/ + if (clk_pm_cpu_set_parent(muxrate_hw, +
clk_pm_cpu_get_parent(muxrate_hw)))drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const · line 684
Quoted 1 line
drivers/clk/mvebu/armada-37xx-periph.c +1
-0+ dev_warn(dev, "Failed to setup default parentclock for DVFS\n");
drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const · line 687
Quoted 3 lines
drivers/clk/mvebu/armada-37xx-periph.c +0
-0} *hw = clk_hw_register_composite(dev, data->name,
data->parent_names,Quoted 3 lines
--
2.20.1Applied this and selected only
CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_POWERSAVE=yAfter changing the governor from 'powersave' to 'performance' the board completely froze (i even lost access to the serial port)
Cheers
/Ilias
Gregory CLEMENT
maintainerHi Ilias,
Quoted 11 lines · Ilias Apalodimas
Hello Christian,
Quoted 8 lines
Hi,
I assume you use the 1000 MHz firmware. This does also not work on my Rev 7 board. But I'm pretty sure this is not a problem of the patches, because if I take a newer kernel (4.19.20/27) without the patches it also does not work. A kernel 4.19.17 does work for me. My opinion on that is that this is another problem which does just occure now because now the cpu frequency scaling is working with the right frequencies.
I am not sure which firmware i am running, i did all my tests on 5.0.0 and changing between governors worked fine without the patches
Curently my espressobin is broken so I tested the patches on the Armada 3700 DB and I didn't observe the issue you had.
The 3700 DB I used is configured to run at 800MHz.
Could you apply the following patch and sent me the boot log?
drivers/clk/mvebu/armada-37xx-periph.c +4 -1
@@ -452,14 +452,17 @@ static int clk_pm_cpu_set_parent(struct clk_hw *hw, u8 index)/* Set the parent clock for all the load level */ for (load_level =0 ; load_level <LOAD_LEVEL_NR ; load_level++) { -unsigned int reg, mask, val, +unsigned int reg, mask, val, old, offset =ARMADA_37XX_NB_TBG_SEL_OFF ;armada_3700_pm_dvfs_update_regs (load_level, ®, &offset); val = index << offset; mask =ARMADA_37XX_NB_TBG_SEL_MASK << offset; +regmap_read (base, reg, &old);regmap_update_bits (base, reg, mask, val); +pr_err ("%s old=%X -> val=0x%X load_level=%d\n" , + __func__, old, val, load_level); }return 0 ; }
Quoted 66 lines
Regards
/IliasQuoted 63 lines
Ilias Apalodimas <[email protected]> schrieb am Do., 14. März 2019, 13:15:
Quoted 59 lines
Hi Gregory,
Quoted 12 lines
The clock parenting was not setup properly when DVFS was enabled. It was expected that the same clock source was used with and without DVFS which was not the case.
This patch fixes this issue, allowing to make the cpufreq support work when the CPU clocks source are not the default ones.
Fixes 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx")Cc <[email protected]>Reported-by Christian Neubert <[email protected]>Reported-by Ilias Apalodimas <[email protected]>Signed-off-by Gregory CLEMENT <[email protected]>Review
Quoted 5 lines
--- drivers/clk/mvebu/armada-37xx-periph.c | 11 +++++++++++ 1 file changed, 11 insertions(+)(quoted diff) +0
-0
b/drivers/clk/mvebu/armada-37xx-periph.cdrivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const
Quoted 4 lines
index
1f1cff428d78..26ed3c18a239100644drivers/clk/mvebu/armada-37xx-periph.c +0
-0@@ -671,6 +671,17 @@ static int armada_3700_add_composite_clk(conststruct
clk_periph_data*data,drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const · line 683
Quoted 13 lines
drivers/clk/mvebu/armada-37xx-periph.c +10
-0map =syscon_regmap_lookup_by_compatible ("marvell,armada-3700-nb-pm" ); pmcpu_clk->nb_pm_base = map; + +/* +* Use the same parent when DVFS is enabled that the +* default parent received at boot time. When this +* function is called, DVFS is not enabled yet, so we +* get the default parent and we can set the parent +* for DVFS. +*/ + if (clk_pm_cpu_set_parent(muxrate_hw, +
clk_pm_cpu_get_parent(muxrate_hw)))drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const · line 684
Quoted 1 line
drivers/clk/mvebu/armada-37xx-periph.c +1
-0+ dev_warn(dev, "Failed to setup default parentclock for DVFS\n");
drivers/clk/mvebu/armada-37xx-periph.c static int armada_3700_add_composite_clk(const · line 687
Quoted 3 lines
drivers/clk/mvebu/armada-37xx-periph.c +0
-0} *hw = clk_hw_register_composite(dev, data->name,
data->parent_names,Quoted 3 lines
--
2.20.1Applied this and selected only
CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_PERFORMANCE=yCONFIG_CPU_FREQ_GOV_POWERSAVE=yAfter changing the governor from 'powersave' to 'performance' the board completely froze (i even lost access to the serial port)
Cheers
/Ilias
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
Hi Gregory,
Quoted 39 lines
Hi Ilias,
Quoted 11 lines · Ilias Apalodimas
Hello Christian,
Quoted 8 lines
Hi,
I assume you use the 1000 MHz firmware. This does also not work on my Rev 7 board. But I'm pretty sure this is not a problem of the patches, because if I take a newer kernel (4.19.20/27) without the patches it also does not work. A kernel 4.19.17 does work for me. My opinion on that is that this is another problem which does just occure now because now the cpu frequency scaling is working with the right frequencies.
I am not sure which firmware i am running, i did all my tests on 5.0.0 and changing between governors worked fine without the patches
Curently my espressobin is broken so I tested the patches on the Armada 3700 DB and I didn't observe the issue you had.
The 3700 DB I used is configured to run at 800MHz.
Could you apply the following patch and sent me the boot log?
drivers/clk/mvebu/armada-37xx-periph.c +1
-1@@ -452,14 +452,17 @@ static int clk_pm_cpu_set_parent(struct clk_hw *hw, u8 index)/* Set the parent clock for all the load level */ for (load_level =0 ; load_level <LOAD_LEVEL_NR ; load_level++) { -unsigned int reg, mask, val, +unsigned int reg, mask, val, old, offset =ARMADA_37XX_NB_TBG_SEL_OFF ;armada_3700_pm_dvfs_update_regs (load_level, ®, &offset);
drivers/clk/mvebu/armada-37xx-periph.c static int clk_pm_cpu_set_parent(struct clk_hw *hw, u8 index) · line 468
Quoted 10 lines
drivers/clk/mvebu/armada-37xx-periph.c +3
-0val = index << offset; mask =ARMADA_37XX_NB_TBG_SEL_MASK << offset; +regmap_read (base, reg, &old);regmap_update_bits (base, reg, mask, val); +pr_err ("%s old=%X -> val=0x%X load_level=%d\n" , + __func__, old, val, load_level); }return 0 ; }
[ 14.909524] clk_pm_cpu_set_parent old=28004840 -> val=0x6000000 load_level=0 [ 14.916424] clk_pm_cpu_set_parent old=2E004840 -> val=0x600 load_level=1 [ 14.923315] clk_pm_cpu_set_parent old=8880A8C0 -> val=0x6000000 load_level=2 [ 14.930572] clk_pm_cpu_set_parent old=8E80A8C0 -> val=0x600 load_level=3
Let me know if you need anything else
Regards
/Ilias
Gregory CLEMENT
maintainerHi Ilias,
Quoted 56 lines · Ilias Apalodimas
Hi Gregory,
Quoted 39 lines
Hi Ilias,
Quoted 11 lines · Ilias Apalodimas
Hello Christian,
Quoted 8 lines
Hi,
I assume you use the 1000 MHz firmware. This does also not work on my Rev 7 board. But I'm pretty sure this is not a problem of the patches, because if I take a newer kernel (4.19.20/27) without the patches it also does not work. A kernel 4.19.17 does work for me. My opinion on that is that this is another problem which does just occure now because now the cpu frequency scaling is working with the right frequencies.
I am not sure which firmware i am running, i did all my tests on 5.0.0 and changing between governors worked fine without the patches
Curently my espressobin is broken so I tested the patches on the Armada 3700 DB and I didn't observe the issue you had.
The 3700 DB I used is configured to run at 800MHz.
Could you apply the following patch and sent me the boot log?
drivers/clk/mvebu/armada-37xx-periph.c +1
-1@@ -452,14 +452,17 @@ static int clk_pm_cpu_set_parent(struct clk_hw *hw, u8 index)/* Set the parent clock for all the load level */ for (load_level =0 ; load_level <LOAD_LEVEL_NR ; load_level++) { -unsigned int reg, mask, val, +unsigned int reg, mask, val, old, offset =ARMADA_37XX_NB_TBG_SEL_OFF ;armada_3700_pm_dvfs_update_regs (load_level, ®, &offset);drivers/clk/mvebu/armada-37xx-periph.c static int clk_pm_cpu_set_parent(struct clk_hw *hw, u8 index) · line 468
Quoted 10 lines
drivers/clk/mvebu/armada-37xx-periph.c +3
-0val = index << offset; mask =ARMADA_37XX_NB_TBG_SEL_MASK << offset; +regmap_read (base, reg, &old);regmap_update_bits (base, reg, mask, val); +pr_err ("%s old=%X -> val=0x%X load_level=%d\n" , + __func__, old, val, load_level); }return 0 ; }[ 14.909524] clk_pm_cpu_set_parent old=28004840 -> val=0x6000000 load_level=0 [ 14.916424] clk_pm_cpu_set_parent old=2E004840 -> val=0x600 load_level=1 [ 14.923315] clk_pm_cpu_set_parent old=8880A8C0 -> val=0x6000000 load_level=2 [ 14.930572] clk_pm_cpu_set_parent old=8E80A8C0 -> val=0x600 load_level=3
Quoted 1 line
Let me know if you need anything else
Could you show me the output of "cat /sys/kernel/debug/clk/clk_summary"
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
For this, you just have to remove the avs node in arch/arm64/boot/dts/marvell/armada-37xx.dtsi and rebuild the dtb.
Thanks,
Gregory
Quoted 3 lines
Regards
/Ilias
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
Hi Gregory,
Quoted 11 lines
Quoted 8 lines
Quoted 1 line
[ 14.909524] clk_pm_cpu_set_parent old=28004840 -> val=0x6000000 load_level=0 [ 14.916424] clk_pm_cpu_set_parent old=2E004840 -> val=0x600 load_level=1 [ 14.923315] clk_pm_cpu_set_parent old=8880A8C0 -> val=0x6000000 load_level=2 [ 14.930572] clk_pm_cpu_set_parent old=8E80A8C0 -> val=0x600 load_level=3Let me know if you need anything else
Could you show me the output of "cat
/sys/kernel/debug/clk/clk_summary"
root@localhost ~ # cat /sys/kernel/debug/clk/clk_summary
enable prepare protect duty
clock count count count rate accuracy phase cycle
---------------------------------------------------------------------------------------------
xtal 2 3 0 25000000 0 0 50000
i2c_1 0 0 0 25000000 0 0 50000
i2c_2 0 0 0 25000000 0 0 50000
avs 0 0 0 25000000 0 0 50000
TBG-B-S 2 2 0 1000000000 0 0 50000
cpu 0 0 0 200000000 0 0 50000
usb32_ss_sys 1 1 0 125000000 0 0 50000
usb32_usb2_sys 0 0 0 100000000 0 0 50000
gbe_125 0 0 0 125000000 0 0 50000
gbe0_125 0 0 0 125000000 0 0 50000
gbe1_125 0 0 0 125000000 0 0 50000
gbe_core 1 1 0 250000000 0 0 50000
gbe_bm 0 0 0 250000000 0 0 50000
gbe0_core 1 1 0 250000000 0 0 50000
gbe1_core 0 0 0 250000000 0 0 50000
eip97 0 0 0 500000000 0 0 50000
trace 0 0 0 1000000000 0 0 50000
ddr_fclk 0 0 0 125000000 0 0 50000
pwm 0 0 0 50000000 0 0 50000
tscem_tmx 0 0 0 1000000000 0 0 50000
sec_dap 0 0 0 100000000 0 0 50000
sec_at 0 0 0 200000000 0 0 50000
TBG-A-S 0 0 0 1600000000 0 0 50000
sdio 0 0 0 400000000 0 0 50000
ddr_phy 0 0 0 400000000 0 0 50000
mmc 0 0 0 400000000 0 0 50000
TBG-B-P 0 0 0 500000000 0 0 50000
gbe_50 0 0 0 50000000 0 0 50000
gbe0_50 0 0 0 50000000 0 0 50000
gbe1_50 0 0 0 50000000 0 0 50000
TBG-A-P 0 1 0 800000000 0 0 50000
counter 0 0 0 160000000 0 0 50000
sqf 0 1 0 200000000 0 0 50000
tscem 0 0 0 200000000 0 0 50000
sata_host 0 0 0 200000000 0 0 50000root@localhost ~ #
Quoted 7 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.
Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return
Cheers
/Ilias
Quoted 57 lines · Ilias Apalodimas
Hi Gregory,
Quoted 11 lines
Quoted 8 lines
Quoted 1 line
[ 14.909524] clk_pm_cpu_set_parent old=28004840 -> val=0x6000000 load_level=0 [ 14.916424] clk_pm_cpu_set_parent old=2E004840 -> val=0x600 load_level=1 [ 14.923315] clk_pm_cpu_set_parent old=8880A8C0 -> val=0x6000000 load_level=2 [ 14.930572] clk_pm_cpu_set_parent old=8E80A8C0 -> val=0x600 load_level=3Let me know if you need anything else
Could you show me the output of "cat
/sys/kernel/debug/clk/clk_summary"root@localhost ~ # cat
/sys/kernel/debug/clk/clk_summary
enable prepare protect duty
clock count count count rate accuracy phase cycle
---------------------------------------------------------------------------------------------xtal 2 3 0 25000000 0 0 50000 i2c_1 0 0 0 25000000 0 0 50000 i2c_2 0 0 0 25000000 0 0 50000 avs 0 0 0 25000000 0 0 50000 TBG-B-S 2 2 0 1000000000 0 0 50000 cpu 0 0 0 200000000 0 0 50000 usb32_ss_sys 1 1 0 125000000 0 0 50000 usb32_usb2_sys 0 0 0 100000000 0 0 50000 gbe_125 0 0 0 125000000 0 0 50000 gbe0_125 0 0 0 125000000 0 0 50000 gbe1_125 0 0 0 125000000 0 0 50000 gbe_core 1 1 0 250000000 0 0 50000 gbe_bm 0 0 0 250000000 0 0 50000 gbe0_core 1 1 0 250000000 0 0 50000 gbe1_core 0 0 0 250000000 0 0 50000 eip97 0 0 0 500000000 0 0 50000 trace 0 0 0 1000000000 0 0 50000 ddr_fclk 0 0 0 125000000 0 0 50000 pwm 0 0 0 50000000 0 0 50000 tscem_tmx 0 0 0 1000000000 0 0 50000 sec_dap 0 0 0 100000000 0 0 50000 sec_at 0 0 0 200000000 0 0 50000 TBG-A-S 0 0 0 1600000000 0 0 50000 sdio 0 0 0 400000000 0 0 50000 ddr_phy 0 0 0 400000000 0 0 50000 mmc 0 0 0 400000000 0 0 50000 TBG-B-P 0 0 0 500000000 0 0 50000 gbe_50 0 0 0 50000000 0 0 50000 gbe0_50 0 0 0 50000000 0 0 50000 gbe1_50 0 0 0 50000000 0 0 50000 TBG-A-P 0 1 0 800000000 0 0 50000 counter 0 0 0 160000000 0 0 50000 sqf 0 1 0 200000000 0 0 50000 tscem 0 0 0 200000000 0 0 50000 sata_host 0 0 0 200000000 0 0 50000root@localhost ~ #
Quoted 3 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Quoted 6 lines
Quoted 4 lines
Could you disable it and check you still have the issue?
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return
@Ilias: Can you please try this now and confirm to Gregory ?
Signature · 1 line
viresh
Hi Viresh,
Quoted 11 lines
Quoted 9 lines
Quoted 7 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return@Ilias: Can you please try this now and confirm to Gregory ?
I am more overloaded than usual and totally forgot about this. Apologies. I'll try finding some time and do this.
Thanks
/Ilias
Quoted 7 lines · Ilias Apalodimas
Hi Viresh,
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return@Ilias: Can you please try this now and confirm to Gregory ?
I am more overloaded than usual and totally forgot about this. Apologies. I'll try finding some time and do this.
Ping Ilias.
Signature · 1 line
viresh
Hi Viresh, Gregory
Quoted 10 lines · Viresh Kumar
Quoted 9 lines · Ilias Apalodimas
Hi Viresh,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return@Ilias: Can you please try this now and confirm to Gregory ?
I am more overloaded than usual and totally forgot about this. Apologies. I'll try finding some time and do this.
Ping Ilias.
Sorry for the huge delay.
Applying this patch and removing tha 'avs' node from arch/arm64/boot/dts/marvell/armada-37xx.dtsi seems to work. Changing between governors does not freeze the board any more. I haven't checked the actual impact on the CPU speed but the values on /sys/devices/system/cpu/cpufreq/policy0/scaling_governor are correct
Cheers
/Ilias
Quoted 19 lines · Ilias Apalodimas
Hi Viresh, Gregory
Quoted 17 lines · Viresh Kumar
Quoted 15 lines · Ilias Apalodimas
Hi Viresh,
Quoted 11 lines
Quoted 9 lines
Quoted 7 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return@Ilias: Can you please try this now and confirm to Gregory ?
I am more overloaded than usual and totally forgot about this. Apologies. I'll try finding some time and do this.
Quoted 7 lines
Quoted 1 line
Ping Ilias.
Sorry for the huge delay.
Applying this patch and removing tha 'avs' node fromarch/arm64/boot/dts/marvell/armada-37xx.dtsiseems to work. Changing between governors does not freeze the board any more. I haven't checked the actual impact on the CPU speed but the values on/sys/devices/system/cpu/cpufreq/policy0/scaling_governorare correct
Thanks for testing it out. Lets see what Gregory has to say now.
Signature · 1 line
viresh
Quoted 21 lines · Viresh Kumar
Quoted 20 lines · Ilias Apalodimas
Hi Viresh, Gregory
Quoted 18 lines · Viresh Kumar
Quoted 7 lines · Ilias Apalodimas
Hi Viresh,
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return@Ilias: Can you please try this now and confirm to Gregory ?
I am more overloaded than usual and totally forgot about this. Apologies. I'll try finding some time and do this.
Ping Ilias.
Quoted 8 lines
Quoted 6 lines
Sorry for the huge delay.
Applying this patch and removing tha 'avs' node fromarch/arm64/boot/dts/marvell/armada-37xx.dtsiseems to work. Changing between governors does not freeze the board any more. I haven't checked the actual impact on the CPU speed but the values on/sys/devices/system/cpu/cpufreq/policy0/scaling_governorare correctThanks for testing it out. Lets see what Gregory has to say now.
@Gregory: Do you have any further advice for Ilias ?
Signature · 1 line
viresh
Quoted 29 lines · Viresh Kumar
Quoted 28 lines · Viresh Kumar
Quoted 26 lines · Ilias Apalodimas
Hi Viresh, Gregory
Quoted 10 lines · Viresh Kumar
Quoted 9 lines · Ilias Apalodimas
Hi Viresh,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Also, during this week-end, Christian suggested that the issue might come from the AVS support.
Could you disable it and check you still have the issue?
For this, you just have to remove the avs node in
arch/arm64/boot/dts/marvell/armada-37xx.dtsiand rebuild the dtb.Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Sure. You'll have to wait for a week though. Currently on a trip. I'll run that
once i return@Ilias: Can you please try this now and confirm to Gregory ?
I am more overloaded than usual and totally forgot about this. Apologies. I'll try finding some time and do this.
Ping Ilias.
Sorry for the huge delay.
Applying this patch and removing tha 'avs' node fromarch/arm64/boot/dts/marvell/armada-37xx.dtsiseems to work. Changing between governors does not freeze the board any more. I haven't checked the actual impact on the CPU speed but the values on/sys/devices/system/cpu/cpufreq/policy0/scaling_governorare correct
Quoted 3 lines
Quoted 1 line
Thanks for testing it out. Lets see what Gregory has to say now.
@Gregory: Do you have any further advice for Ilias ?
Ping.
Signature · 1 line
viresh