Skip to contentSkip to conversation

gpio: mockup: drop unneeded dependencies from Kconfig

PATCH In review Bartosz Golaszewski 1 participant 3 messages Mar 14, 2019 – Mar 22, 2019 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 gpio: mockup: drop unneeded dependencies from Kconfig

From: Bartosz Golaszewski <[email protected]>

The testing module doesn't need GPIO irqchip nor does it depend on sysfs. Remove unnecessary dependencies from Kconfig.

---
 drivers/gpio/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/Kconfig +1 -3
index 3f50526a771f..e9473e968d9a 100644
@@ -332,9 +332,7 @@ config GPIO_MM_LANTIQ
 
 config GPIO_MOCKUP
 	tristate "GPIO Testing Driver"
-	depends on GPIOLIB && SYSFS
-	select GPIO_SYSFS
-	select GPIOLIB_IRQCHIP
+	depends on GPIOLIB
 	select IRQ_SIM
 	help
 	  This enables GPIO Testing driver, which provides a way to test GPIO
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 gpio: mockup: move the driver out of the IOMEM drivers section

From: Bartosz Golaszewski <[email protected]>

The testing driver doesn't really depend on HAS_IOMEM. We may want to build it for testing purposes on architectures not supporting IOMEM, for example: on user-mode linux. Move it out of the "Memory Mapped GPIO drivers" section.

---
 drivers/gpio/Kconfig | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/gpio/Kconfig +12 -12
index e9473e968d9a..474ab3f7f9ce 100644
@@ -330,18 +330,6 @@ config GPIO_MM_LANTIQ
 	  (EBU) found on Lantiq SoCs. The gpios are output only as they are
 	  created by attaching a 16bit latch to the bus.
 
-config GPIO_MOCKUP
-	tristate "GPIO Testing Driver"
-	depends on GPIOLIB
-	select IRQ_SIM
-	help
-	  This enables GPIO Testing driver, which provides a way to test GPIO
-	  subsystem through sysfs(or char device) and debugfs. GPIO_SYSFS
-	  must be selected for this test.
-	  User could use it through the script in
-	  tools/testing/selftests/gpio/gpio-mockup.sh. Reference the usage in
-	  it.
-
 config GPIO_MPC5200
 	def_bool y
 	depends on PPC_MPC52xx
@@ -1440,4 +1428,16 @@ config GPIO_VIPERBOARD
 
 endmenu
 
+config GPIO_MOCKUP
+	tristate "GPIO Testing Driver"
+	depends on GPIOLIB
+	select IRQ_SIM
+	help
+	  This enables GPIO Testing driver, which provides a way to test GPIO
+	  subsystem through sysfs(or char device) and debugfs. GPIO_SYSFS
+	  must be selected for this test.
+	  User could use it through the script in
+	  tools/testing/selftests/gpio/gpio-mockup.sh. Reference the usage in
+	  it.
+
 endif
Signature · 1 line
2.20.1
#2 lore raw
In reply to Bartosz Golaszewski

czw., 14 mar 2019 o 16:08 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 27 lines

From: Bartosz Golaszewski <[email protected]>

The testing module doesn't need GPIO irqchip nor does it depend on sysfs. Remove unnecessary dependencies from Kconfig.

---
 drivers/gpio/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/Kconfig +1 -4
index 3f50526a771f..e9473e968d9a 100644
@@ -332,9 +332,7 @@ config GPIO_MM_LANTIQ
 
 config GPIO_MOCKUP
        tristate "GPIO Testing Driver"
-       depends on GPIOLIB && SYSFS
-       select GPIO_SYSFS
-       select GPIOLIB_IRQCHIP
+       depends on GPIOLIB
        select IRQ_SIM
        help
          This enables GPIO Testing driver, which provides a way to test GPIO
--
Quoted 2 lines

2.20.1

Both applied to for-next.

Bart