Skip to contentSkip to conversation

package/libpcap: disable dbus to break circular dependency

PATCH New Baruch Siach 3 participants 3 messages Mar 9, 2019 – Mar 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libpcap: disable dbus to break circular dependency

The optional dbus dependency of libpcap creates a circular dependency chain:

$ make libpcap-show-recursive-depends

Recursion detected for : systemd
which is a dependency of: dbus
which is a dependency of: libpcap
which is a dependency of: iptables
which is a dependency of: systemd
make: *** [package/libpcap/libpcap.mk:55: libpcap-show-recursive-depends] Error 1

Of all these dependencies the one of libpcap on dbus seems to be less useful. Drop it.

Fixes:
http://autobuild.buildroot.net/results/0b5d18bff816cbcee11e8645449701722d956de5/

---
 package/libpcap/libpcap.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
package/libpcap/libpcap.mk +2 -7
index 126087220b02..83188c8c4847 100644
@@ -16,6 +16,8 @@ LIBPCAP_CONF_ENV = \
 	CFLAGS="$(LIBPCAP_CFLAGS)"
 LIBPCAP_CFLAGS = $(TARGET_CFLAGS)
 LIBPCAP_CONF_OPTS = --disable-yydebug --with-pcap=linux --without-dag
+# Disable dbus to break recursive dependencies
+LIBPCAP_CONF_OPTS += --disable-dbus
 LIBPCAP_CONFIG_SCRIPTS = pcap-config
 
 # Omit -rpath from pcap-config output
@@ -32,13 +34,6 @@ else
 LIBPCAP_CONF_OPTS += --disable-bluetooth
 endif
 
-ifeq ($(BR2_PACKAGE_DBUS),y)
-LIBPCAP_CONF_OPTS += --enable-dbus
-LIBPCAP_DEPENDENCIES += dbus
-else
-LIBPCAP_CONF_OPTS += --disable-dbus
-endif
-
 ifeq ($(BR2_PACKAGE_LIBNL),y)
 LIBPCAP_DEPENDENCIES += libnl
 LIBPCAP_CFLAGS += "-I$(STAGING_DIR)/usr/include/libnl3"
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/libpcap: disable dbus to break circular dependency

Quoted 15 lines · On Sat, 9 Mar 2019 20:28:14 +0200 Baruch Siach <[email protected]> wrote:

The optional dbus dependency of libpcap creates a circular dependency chain:

$ make libpcap-show-recursive-depends

Recursion detected for : systemd
which is a dependency of: dbus
which is a dependency of: libpcap
which is a dependency of: iptables
which is a dependency of: systemd
make: *** [package/libpcap/libpcap.mk:55: libpcap-show-recursive-depends] Error 1

Of all these dependencies the one of libpcap on dbus seems to be less useful. Drop it.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/0b5d18bff816cbcee11e8645449701722d956de5/

---
 package/libpcap/libpcap.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libpcap: disable dbus to break circular dependency

In reply to Baruch Siach
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

The optional dbus dependency of libpcap creates a circular dependency chain:

$ make libpcap-show-recursive-depends

Recursion detected for : systemd
which is a dependency of: dbus
which is a dependency of: libpcap
which is a dependency of: iptables
which is a dependency of: systemd
make: *** [package/libpcap/libpcap.mk:55: libpcap-show-recursive-depends] Error 1

Quoted 7 lines

Of all these dependencies the one of libpcap on dbus seems to be less useful. Drop it.

Fixes:
http://autobuild.buildroot.net/results/0b5d18bff816cbcee11e8645449701722d956de5/

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard