net: openvswitch: fix a NULL pointer dereference
Subsystems (3)
PATCH 1/1 net: openvswitch: fix a NULL pointer dereference
upcall is dereferenced even when genlmsg_put fails. The fix goto out to avoid the NULL pointer dereference in this case.
Signed-off-by Kangjie Lu <[email protected]>
--- net/openvswitch/datapath.c | 4 ++++ 1 file changed, 4 insertions(+)
net/openvswitch/datapath.c +4 -0
@@ -448,6 +448,10 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb, upcall =genlmsg_put (user_skb,0 ,0 , &dp_packet_genl_family,0 , upcall_info->cmd); +if (!upcall) { + err = -EINVAL ; + goto out; + } upcall->dp_ifindex = dp_ifindex; err =ovs_nla_put_key (key, key,OVS_PACKET_ATTR_KEY , false, user_skb);
Signature · 1 line
2.17.1
From: Kangjie Lu <[email protected]>
Date: Thu, 14 Mar 2019 23:20:16 -0500
Quoted 4 lines
upcall is dereferenced even when
genlmsg_putfails. The fix goto out to avoid the NULL pointer dereference in this case.Signed-off-by Kangjie Lu <[email protected]>
Applied.