Skip to contentSkip to conversation

fs: affs: fix a NULL pointer dereference

PATCH In review Kangjie Lu 2 participants 2 messages Mar 15, 2019 – Mar 21, 2019

Subsystems (2)
lore
Share & tools
lore

Kangjie Lu

author
#0 lore raw

PATCH 1/1 fs: affs: fix a NULL pointer dereference

If affs_bread fails, do not use ext_bh to avoid NULL pointer
dereference

---
 fs/affs/file.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
fs/affs/file.c +4 -2
index a85817f54483..29cbc8eda085 100644
@@ -941,8 +941,10 @@ affs_truncate(struct inode *inode)
 		size = AFFS_SB(sb)->s_hashsize;
 		if (size > blkcnt - blk)
 			size = blkcnt - blk;
-		for (i = 0; i < size; i++, blk++)
-			affs_free_block(sb, be32_to_cpu(AFFS_BLOCK(sb, ext_bh, i)));
+		if (ext_bh) {
+			for (i = 0; i < size; i++, blk++)
+				affs_free_block(sb, be32_to_cpu(AFFS_BLOCK(sb, ext_bh, i)));
+		}
 		affs_free_block(sb, ext_key);
 		ext_key = be32_to_cpu(AFFS_TAIL(sb, ext_bh)->extension);
 		affs_brelse(ext_bh);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Kangjie Lu

If affs_bread fails, do not use ext_bh to avoid NULL pointer
dereference

Tanks for the patch. I'll need some more time to get familiar with the AFFS code to review your patch.