Skip to contentSkip to conversation

syscall: Add userfaultfd testcase

PATCH Superseded Christian Amann 3 participants 3 messages Mar 15, 2019 – Mar 18, 2019

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 syscall: Add userfaultfd testcase

This tests the userfaultfd syscall to handle pagefault events. It does so by registering a userfaultfd object to the address of a memory page. In a second thread it handles the event and writes data in the monitored memory page to indicate success.

---
 configure.ac                                       |   1 +
 include/lapi/syscalls/aarch64.in                   |   1 +
 include/lapi/syscalls/arm.in                       |   1 +
 include/lapi/syscalls/i386.in                      |   1 +
 include/lapi/syscalls/ia64.in                      |   1 +
 include/lapi/syscalls/powerpc.in                   |   1 +
 include/lapi/syscalls/powerpc64.in                 |   1 +
 include/lapi/syscalls/s390.in                      |   1 +
 include/lapi/syscalls/s390x.in                     |   1 +
 include/lapi/syscalls/sparc.in                     |   1 +
 include/lapi/syscalls/sparc64.in                   |   1 +
 include/lapi/syscalls/x86_64.in                    |   1 +
 runtest/syscalls                                   |   2 +
 testcases/kernel/syscalls/userfaultfd/.gitignore   |   1 +
 testcases/kernel/syscalls/userfaultfd/Makefile     |  15 +++
 .../kernel/syscalls/userfaultfd/userfaultfd01.c    | 128 +++++++++++++++++++++
 16 files changed, 158 insertions(+)
 create mode 100644 testcases/kernel/syscalls/userfaultfd/.gitignore
 create mode 100644 testcases/kernel/syscalls/userfaultfd/Makefile
 create mode 100644 testcases/kernel/syscalls/userfaultfd/userfaultfd01.c
configure.ac +1 -0
index e73f7d92e..9ae10b6a0 100644
@@ -45,6 +45,7 @@ AC_CHECK_HEADERS([ \
     linux/mempolicy.h \
     linux/module.h \
     linux/netlink.h \
+    linux/userfaultfd.h \
     mm.h \
     netinet/sctp.h \
     pthread.h \
include/lapi/syscalls/aarch64.in +1 -0
index 7ce148524..177dd0115 100644
@@ -258,6 +258,7 @@ process_vm_writev 271
 kcmp 272
 getrandom 278
 memfd_create 279
+userfaultfd 282
 membarrier 283
 execveat 281
 mlock2 284
include/lapi/syscalls/arm.in +1 -0
index 22c76d4f0..f4adedb2c 100644
@@ -343,6 +343,7 @@ renameat2 (__NR_SYSCALL_BASE+382)
 getrandom (__NR_SYSCALL_BASE+384)
 memfd_create (__NR_SYSCALL_BASE+385)
 execveat (__NR_SYSCALL_BASE+387)
+userfaultfd (__NR_SYSCALL_BASE+388)
 membarrier (__NR_SYSCALL_BASE+389)
 mlock2 (__NR_SYSCALL_BASE+390)
 copy_file_range (__NR_SYSCALL_BASE+391)
include/lapi/syscalls/i386.in +1 -0
index 7e485aebf..af5254f77 100644
@@ -341,6 +341,7 @@ renameat2 354
 getrandom 355
 memfd_create 356
 execveat 358
+userfaultfd 374
 membarrier 375
 mlock2 376
 copy_file_range 377
include/lapi/syscalls/ia64.in +1 -0
index 7c9a0ead6..c0aeed08b 100644
@@ -298,6 +298,7 @@ process_vm_writev 1333
 renameat2 1338
 getrandom 1339
 memfd_create 1340
+userfaultfd 1343
 membarrier 1344
 execveat 1342
 mlock2 1346
include/lapi/syscalls/powerpc.in +1 -0
index fc1f89945..6b6be58a7 100644
@@ -347,6 +347,7 @@ sched_getattr 356
 renameat2 357
 getrandom 359
 memfd_create 360
+userfaultfd 364
 membarrier 365
 execveat 362
 mlock2 378
include/lapi/syscalls/powerpc64.in +1 -0
index fc1f89945..6b6be58a7 100644
@@ -347,6 +347,7 @@ sched_getattr 356
 renameat2 357
 getrandom 359
 memfd_create 360
+userfaultfd 364
 membarrier 365
 execveat 362
 mlock2 378
include/lapi/syscalls/s390.in +1 -0
index 6d0c895fa..2a2ffe223 100644
@@ -331,6 +331,7 @@ sched_getattr 346
 renameat2 347
 getrandom 349
 memfd_create 350
+userfaultfd 355
 membarrier 356
 execveat 354
 mlock2 374
include/lapi/syscalls/s390x.in +1 -0
index 8105b5598..4c36ce17c 100644
@@ -330,6 +330,7 @@ sched_getattr 346
 renameat2 347
 getrandom 349
 memfd_create 350
+userfaultfd 355
 membarrier 356
 execveat 354
 mlock2 374
include/lapi/syscalls/sparc.in +1 -0
index 20a21a9ce..20dc37b01 100644
@@ -337,6 +337,7 @@ renameat2 345
 getrandom 347
 memfd_create 348
 membarrier 351
+userfaultfd 352
 execveat 350
 mlock2 356
 copy_file_range 357
include/lapi/syscalls/sparc64.in +1 -0
index 36ab39420..c100b8e3e 100644
@@ -313,6 +313,7 @@ renameat2 345
 getrandom 347
 memfd_create 348
 membarrier 351
+userfaultfd 352
 execveat 350
 mlock2 356
 copy_file_range 357
include/lapi/syscalls/x86_64.in +1 -0
index 6aa9d12a8..87849e5c0 100644
@@ -308,6 +308,7 @@ renameat2 316
 getrandom 318
 memfd_create 319
 execveat 322
+userfaultfd 323
 membarrier 324
 mlock2 325
 copy_file_range 326
runtest/syscalls +2 -0
index d752dba33..ebb4d69a5 100644
@@ -1464,6 +1464,8 @@ umount2_01 umount2_01
 umount2_02 umount2_02
 umount2_03 umount2_03
 
+userfaultfd01 userfaultfd01
+
 ustat01 ustat01
 ustat02 ustat02
 
testcases/kernel/syscalls/userfaultfd/.gitignore new file +1 -0
new file mode 100644
index 000000000..d819a2a7c
@@ -0,0 +1 @@
+/userfaultfd01
testcases/kernel/syscalls/userfaultfd/Makefile new file +15 -0
new file mode 100644
index 000000000..33fe59e5b
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+#
+#   Copyright (c) 2019 SUSE LLC
+#
+#   Author: Christian Amann <[email protected]>
+#
+
+top_srcdir		?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
+
+userfaultfd01: CFLAGS += -pthread
+
testcases/kernel/syscalls/userfaultfd/userfaultfd01.c new file +128 -0

128 lines not on this page · raw message

Signature · 1 line
2.16.4
#1 lore raw

PATCH v3 1/1 syscall: Add userfaultfd testcase

----- Original Message -----

Quoted 6 lines

This tests the userfaultfd syscall to handle pagefault events. It does so by registering a userfaultfd object to the address of a memory page. In a second thread it handles the event and writes data in the monitored memory page to indicate success.

Couple small nits below (no need to repost).

syscall -> syscalls in subject

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+static int userfaultfd(int flags)

If glibc ever provides func, my money would be on this :-). But looking at HEAD, we're safe now.

Thanks,
Jan

#2 lore raw

PATCH v3 1/1 syscall: Add userfaultfd testcase

Hi Christian, Jan,

Quoted 12 lines

----- Original Message -----

Quoted 6 lines

This tests the userfaultfd syscall to handle pagefault events. It does so by registering a userfaultfd object to the address of a memory page. In a second thread it handles the event and writes data in the monitored memory page to indicate success.

Couple small nits below (no need to repost).

Quoted 7 lines

syscall -> syscalls in subject

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+static int userfaultfd(int flags)

If glibc ever provides func, my money would be on this :-). But looking at HEAD, we're safe now.

Yes, I'd be for changing the name, see 651895c9f ("getcpu01: Rename getcpu to avoid conflict with glibc >= 2.29" :)

Nice work! Would it be possible to fix warnings?

userfaultfd01.c: In function ‘handle_thread’:
userfaultfd01.c:50:9: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

  uffd = (int) arg;
         ^

userfaultfd01.c:80:1: warning: no return statement in function returning non-void [-Wreturn-type]
}
^
In file included from userfaultfd01.c:19:
userfaultfd01.c: In function ‘run’:
userfaultfd01.c:108:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

    handle_thread, (void *) uffd);
                   ^
../../../../include/tst_safe_pthread.h:39:70: note: in definition of macro ‘SAFE_PTHREAD_CREATE’
  safe_pthread_create(__FILE__, __LINE__, thread_id, attr, thread_fn, arg)
                                                                      ^~~

Kind regards,
Petr