arm: fix hvc call
PATCH v2 1/1 arm: fix hvc call
HVC call makes use of 6 mandatory arguments rather than 7 in the same way as SMC calls. The 7th argument is optional (Client ID) for both HVC and SMC but is implemented as 16-bit parameter and register R7 or W7. The aim of this patch is just fix compilation error due to an invalid asm code in the HVC call so that's why the 7th argument is removed.
The issue does not report any error in a normal build as hvc_call is not used at all and is optimized by the compiler. Using -O0 triggers the error so the patch is intended to fix issues on a ongoing effor to build U-Boot with -O0.
---
Changes in v2:
- More comprehensive commit message
arch/arm/cpu/armv8/fwcall.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/cpu/armv8/fwcall.c +1 -2
@@ -28,7 +28,6 @@ static void hvc_call(struct pt_regs *args)"ldr x4, %4\n" "ldr x5, %5\n" "ldr x6, %6\n" -"ldr x7, %7\n" "hvc #0\n" "str x0, %0\n" "str x1, %1\n"
@@ -37,7 +36,7 @@ static void hvc_call(struct pt_regs *args) : "+m" (args->regs[0]), "+m" (args->regs[1]), "+m" (args->regs[2]), "+m" (args->regs[3]) : "m" (args->regs[4]), "m" (args->regs[5]), - "m" (args->regs[6]), "m" (args->regs[7]) + "m" (args->regs[6]) : "x0", "x1", "x2", "x3", "x4", "x5", "x6", "x7","x8" ,"x9" ,"x10" ,"x11" ,"x12" ,"x13" ,"x14" ,"x15" , "x16", "x17");
Signature · 1 line
1.8.3.1
PATCH v2 1/1 arm: fix hvc call
Quoted 10 lines
Am 25.02.2019 um 02:11 schrieb Ibai Erkiaga <[email protected]>:
HVC call makes use of 6 mandatory arguments rather than 7 in the same way as SMC calls. The 7th argument is optional (Client ID) for both HVC and SMC but is implemented as 16-bit parameter and register R7 or W7. The aim of this patch is just fix compilation error due to an invalid asm code in the HVC call so that's why the 7th argument is removed.
Quoted 6 lines
The issue does not report any error in a normal build as
hvc_callis not used at all and is optimized by the compiler. Using -O0 triggers the error so the patch is intended to fix issues on a ongoing effor to build U-Boot with -O0.Signed-off-by Ibai Erkiaga <[email protected]>
Alex
Quoted 32 lines
---
Changes in v2:
- More comprehensive commit message
arch/arm/cpu/armv8/fwcall.c| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)arch/arm/cpu/armv8/fwcall.c +1
-2@@ -28,7 +28,6 @@ static void hvc_call(struct pt_regs *args)"ldr x4, %4\n" "ldr x5, %5\n" "ldr x6, %6\n" -"ldr x7, %7\n" "hvc #0\n" "str x0, %0\n" "str x1, %1\n" @@ -37,7 +36,7 @@ static void hvc_call(struct pt_regs *args) : "+m" (args->regs[0]), "+m" (args->regs[1]), "+m" (args->regs[2]), "+m" (args->regs[3]) : "m" (args->regs[4]), "m" (args->regs[5]), - "m" (args->regs[6]), "m" (args->regs[7]) + "m" (args->regs[6]) : "x0", "x1", "x2", "x3", "x4", "x5", "x6", "x7","x8" ,"x9" ,"x10" ,"x11" ,"x12" ,"x13" ,"x14" ,"x15" , "x16", "x17");Signature · 1 line
1.8.3.1
PATCH v2 1/1 arm: fix hvc call
Hi Alex,
Quoted 20 lines
-----Original Message-----
From: Alexander Graf <[email protected]>
Sent: 25 February 2019 13:09
To: Ibai Erkiaga Elorza <[email protected]>
Cc: u-boot at lists.denx.de; Sumit Garg <[email protected]>; Heinrich Schuchardt <[email protected]>; Tom Rini <[email protected]>; Albert Aribaud <[email protected]>
Subject: Re: [U-Boot][PATCH v2] arm: fix hvc callQuoted 1 line
Am 25.02.2019 um 02:11 schrieb Ibai Erkiaga <ibai.erkiaga-
elorza at xilinx.com>:
Quoted 7 lines
HVC call makes use of 6 mandatory arguments rather than 7 in the same way as SMC calls. The 7th argument is optional (Client ID) for both HVC and SMC but is implemented as 16-bit parameter and register R7 or W7. The aim of this patch is just fix compilation error due to an invalid asm code in the HVC call so that's why the 7th argument is removed.
Quoted 9 lines
Quoted 6 lines
The issue does not report any error in a normal build as
hvc_callis not used at all and is optimized by the compiler. Using -O0 triggers the error so the patch is intended to fix issues on a ongoing effor to build U-Boot with -O0.Signed-off-by Ibai Erkiaga <[email protected]>Reviewed-by Alexander Graf <[email protected]>
Thanks for the review. Do I need to CC somebody else to the patch be accepted?
Quoted 34 lines
Alex
Quoted 32 lines
---
Changes in v2:
- More comprehensive commit message
arch/arm/cpu/armv8/fwcall.c| 3 +--1 file changed, 1 insertion(+), 2 deletions(-)arch/arm/cpu/armv8/fwcall.c +1
-3@@ -28,7 +28,6 @@ static void hvc_call(struct pt_regs *args)"ldr x4, %4\n" "ldr x5, %5\n" "ldr x6, %6\n" -"ldr x7, %7\n" "hvc #0\n" "str x0, %0\n" "str x1, %1\n" @@ -37,7 +36,7 @@ static void hvc_call(struct pt_regs *args) : "+m" (args->regs[0]), "+m" (args->regs[1]), "+m" (args->regs[2]), "+m" (args->regs[3]) : "m" (args->regs[4]), "m" (args->regs[5]), - "m" (args->regs[6]), "m" (args->regs[7]) + "m" (args->regs[6]) : "x0", "x1", "x2", "x3", "x4", "x5", "x6", "x7","x8" ,"x9" ,"x10" ,"x11" ,"x12" ,"x13" ,"x14" ,"x15" , "x16", "x17"); --1.8.3.1
PATCH v2 1/1 arm: fix hvc call
Quoted 27 lines · Ibai Erkiaga Elorza
Hi Alex,
Quoted 25 lines
-----Original Message-----
From: Alexander Graf <[email protected]>
Sent: 25 February 2019 13:09
To: Ibai Erkiaga Elorza <[email protected]>
Cc: u-boot at lists.denx.de; Sumit Garg <[email protected]>; Heinrich Schuchardt <[email protected]>; Tom Rini <[email protected]>; Albert Aribaud <[email protected]>
Subject: Re: [U-Boot][PATCH v2] arm: fix hvc callQuoted 1 line
Am 25.02.2019 um 02:11 schrieb Ibai Erkiaga <ibai.erkiaga-
elorza at xilinx.com>:
Quoted 12 lines
HVC call makes use of 6 mandatory arguments rather than 7 in the same way as SMC calls. The 7th argument is optional (Client ID) for both HVC and SMC but is implemented as 16-bit parameter and register R7 or W7. The aim of this patch is just fix compilation error due to an invalid asm code in the HVC call so that's why the 7th argument is removed.
The issue does not report any error in a normal build as
hvc_callis not used at all and is optimized by the compiler. Using -O0 triggers the error so the patch is intended to fix issues on a ongoing effor to build U-Boot with -O0.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Ibai Erkiaga <[email protected]>Reviewed-by Alexander Graf <[email protected]>Thanks for the review. Do I need to CC somebody else to the patch be accepted?
No, but I'm inclined currently to take for for the next release rather than right now, unless there's an important argument I'm missing? Which happens more than I'd care to admit ;)
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190315/6a9bda7f/attachment.sig>
PATCH v2 1/1 arm: fix hvc call
Hi Tom
Quoted 40 lines
-----Original Message-----
From: Tom Rini <[email protected]>
Sent: 15 March 2019 16:08
To: Ibai Erkiaga Elorza <[email protected]>
Cc: Alexander Graf <[email protected]>; u-boot at lists.denx.de; Sumit Garg <[email protected]>; Heinrich Schuchardt <[email protected]>; Albert Aribaud <[email protected]>
Subject: Re: [U-Boot][PATCH v2] arm: fix hvc callQuoted 21 lines · Ibai Erkiaga Elorza
Hi Alex,
Quoted 19 lines
-----Original Message-----
From: Alexander Graf <[email protected]>
Sent: 25 February 2019 13:09
To: Ibai Erkiaga Elorza <[email protected]>
Cc: u-boot at lists.denx.de; Sumit Garg <[email protected]>; Heinrich Schuchardt <[email protected]>; Tom Rini <[email protected]>; Albert Aribaud <[email protected]>
Subject: Re: [U-Boot][PATCH v2] arm: fix hvc callQuoted 1 line
Am 25.02.2019 um 02:11 schrieb Ibai Erkiaga <ibai.erkiaga-
elorza at xilinx.com>:
Quoted 6 lines
HVC call makes use of 6 mandatory arguments rather than 7 in the same way as SMC calls. The 7th argument is optional (Client ID) for both HVC and SMC but is implemented as 16-bit parameter and register R7 or W7. The aim of this patch is just fix compilation error due to an invalid asm code in the HVC call so that's why the 7th
argument is removed.
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
The issue does not report any error in a normal build as
hvc_callis not used at all and is optimized by the compiler. Using -O0 triggers the error so the patch is intended to fix issues on a ongoing effor to build U-Boot with -O0.Signed-off-by Ibai Erkiaga <[email protected]>
Quoted 9 lines
Quoted 3 lines
Quoted 1 line
Reviewed-by Alexander Graf <[email protected]>Thanks for the review. Do I need to CC somebody else to the patch be
accepted?
No, but I'm inclined currently to take for for the next release rather than right now, unless there's an important argument I'm missing? Which happens more than I'd care to admit ;)
No rush, I'm pretty new contributor and just wondering if something else was missing after Alexander's Review.
Quoted 2 lines
--
Tom
Ibai
PATCH v2 1/1 arm: fix hvc call
In reply to Ibai ErkiagaQuoted 6 lines · Ibai Erkiaga
HVC call makes use of 6 mandatory arguments rather than 7 in the same way as SMC calls. The 7th argument is optional (Client ID) for both HVC and SMC but is implemented as 16-bit parameter and register R7 or W7. The aim of this patch is just fix compilation error due to an invalid asm code in the HVC call so that's why the 7th argument is removed.
Quoted 6 lines
The issue does not report any error in a normal build as
hvc_callis not used at all and is optimized by the compiler. Using -O0 triggers the error so the patch is intended to fix issues on a ongoing effor to build U-Boot with -O0.Signed-off-by Ibai Erkiaga <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190424/38b32289/attachment.sig>