Skip to contentSkip to conversation

net/ixgbe: Restore vlan filter/extend for ixgbvef

PATCH Superseded David Harton 4 participants 22 messages Mar 6, 2019 – Mar 18, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ixgbe: Restore vlan filter/extend for ixgbvef

ixgevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.c +2 -4
index e92a70fb3..95c32257c 100644
@@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV
 	 * mode.
Signature · 1 line
2.19.1
#1 lore raw

Hi

Quoted 26 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Harton
Sent: Wednesday, March 6, 2019 11:24 PM
To: [email protected]; Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>
Cc: David Harton <[email protected]>
Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

ixgevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
index e92a70fb3..95c32257c 100644
@@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
 *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_get_rx_port_offloads(struct rte_eth_dev · line 2862

Quoted 10 lines
drivers/net/ixgbe/ixgbe_rxtx.c +2 -1
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)

Patchwork shows "build patch error" for ci/Performance-Testing. Seems this is the only place ixgbe_is_vf is used, so it can also be removed

Quoted 8 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV

* mode.
--
2.19.1

#2 lore raw

Hi,

Quoted 43 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 07, 2019 8:11 AM
To: David Harton (dharton) <[email protected]>; [email protected]; Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>
Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

Hi

Quoted 33 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Harton
Sent: Wednesday, March 6, 2019 11:24 PM
To: [email protected]; Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>
Cc: David Harton <[email protected]>
Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

ixgevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..95c32257c 100644

drivers/net/ixgbe/ixgbe_rxtx.c +2 -0
@@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
 *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
Quoted 8 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) · line 2861

Quoted 4 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -1
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)

Patchwork shows "build patch error" for ci/Performance-Testing. Seems this is the only place ixgbe_is_vf is used, so it can also be removed

Yes, I didn't notice that. Assuming people are good with the fundamental change I'll post a new patch with ixgbe_is_vf removed.

Thanks,
Dave

Quoted 10 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)

Quoted 6 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-

IOV

Quoted 3 lines

* mode.
--
2.19.1

#3 lore raw
In reply to David Harton

Hi, David Harton

Quoted 25 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Harton
Sent: Wednesday, March 6, 2019 11:24 PM
To: [email protected]; Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>
Cc: David Harton <[email protected]>
Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

ixgevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
index e92a70fb3..95c32257c 100644

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_get_rx_port_offloads(struct rte_eth_dev · line 2860

Quoted 8 lines
drivers/net/ixgbe/ixgbe_rxtx.c +2 -0
@@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
 *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 

Why do we set DEV_RX_OFFLOAD_VLAN_EXTEND for ixgbevf ?
It seems Ixgbevf do not support this configuration. Only pf does. But this ixgbe_get_rx_port_offloads () is used by both vf and pf.

Quoted 13 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -4
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-

IOV
* mode.
--
2.19.1

#4 lore raw

Hi

Quoted 39 lines

-----Original Message-----
From: Zhao1, Wei <[email protected]>
Sent: Friday, March 08, 2019 1:35 AM
To: David Harton (dharton) <[email protected]>; [email protected]; Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>
Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

Hi, David Harton

Quoted 29 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Harton
Sent: Wednesday, March 6, 2019 11:24 PM
To: [email protected]; Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>
Cc: David Harton <[email protected]>
Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

ixgevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..95c32257c 100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
 *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
Quoted 8 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev) · line 2859

Quoted 4 lines
drivers/net/ixgbe/ixgbe_rxtx.c +2 -0
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 

Why do we set DEV_RX_OFFLOAD_VLAN_EXTEND for ixgbevf ?
It seems Ixgbevf do not support this configuration. Only pf does. But this ixgbe_get_rx_port_offloads () is used by both vf and pf.

I'm personally happy only to move FILTER but I noticed that EXTEND used to be 'supported' and I see references to it elsewhere in ixgbevf code:

ixgbevf_dev_start()

    /* Set HW strip */
    mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
        ETH_VLAN_EXTEND_MASK;

ixgbe_vlan_offload_config()

    if (mask & ETH_VLAN_EXTEND_MASK) {
        if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)
            ixgbe_vlan_hw_extend_enable(dev);
        else
            ixgbe_vlan_hw_extend_disable(dev);
    }

These uses imply that EXTEND should be supported, correct?

Thanks,
Dave

Quoted 15 lines
Quoted 15 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -4
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-

IOV
* mode.
--
2.19.1

#5 lore raw

Hi,

Quoted 154 lines

-----Original Message-----

From: David Harton (dharton) [mailto:[email protected]]

Sent: Friday, March 8, 2019 8:39 PM

To: Zhao1, Wei <[email protected]>; [email protected]; Lu, Wenzhuo

<[email protected]>; Ananyev, Konstantin

<[email protected]>

Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for

ixgbvef

Hi

Quoted 92 lines

-----Original Message-----

From: Zhao1, Wei <[email protected]<mailto:[email protected]>>

Sent: Friday, March 08, 2019 1:35 AM

To: David Harton (dharton) <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Lu,

Wenzhuo <[email protected]<mailto:[email protected]>>; Ananyev, Konstantin

<[email protected]<mailto:[email protected]>>

Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend

for ixgbvef

Hi, David Harton

Quoted 62 lines

-----Original Message-----

From: dev [mailto:[email protected]] On Behalf Of David Harton

Sent: Wednesday, March 6, 2019 11:24 PM

To: [email protected]<mailto:[email protected]>; Lu, Wenzhuo <[email protected]<mailto:[email protected]>>; Ananyev,

Konstantin <[email protected]<mailto:[email protected]>>

Cc David Harton <[email protected]<mailto:[email protected]>>

Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend

for ixgbvef

ixgevf vlan strip and extend capabilities were removed when

migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

 drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..95c32257c 100644

--- a/drivers/net/ixgbe/ixgbe_rxtx.c

+++ b/drivers/net/ixgbe/ixgbe_rxtx.c

(quoted diff) +0 -0
@@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct
 

rte_eth_dev

*dev)

DEV_RX_OFFLOAD_TCP_CKSUM |

DEV_RX_OFFLOAD_KEEP_CRC |

DEV_RX_OFFLOAD_JUMBO_FRAME |

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +2 -0
+                     DEV_RX_OFFLOAD_VLAN_FILTER |
 
+                     DEV_RX_OFFLOAD_VLAN_EXTEND |
 
                        DEV_RX_OFFLOAD_SCATTER;
Quoted 5 lines

Why do we set DEV_RX_OFFLOAD_VLAN_EXTEND for ixgbevf ?

It seems Ixgbevf do not support this configuration. Only pf does.

But this ixgbe_get_rx_port_offloads () is used by both vf and pf.

I'm personally happy only to move FILTER but I noticed that EXTEND used to

be 'supported' and I see references to it elsewhere in ixgbevf code:

ixgbevf_dev_start()

    /* Set HW strip */

    mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |

        ETH_VLAN_EXTEND_MASK;

ixgbe_vlan_offload_config()

    if (mask & ETH_VLAN_EXTEND_MASK) {

        if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)

            ixgbe_vlan_hw_extend_enable(dev);

        else

            ixgbe_vlan_hw_extend_disable(dev);

    }
Quoted 1 line

These uses imply that EXTEND should be supported, correct?

No, not ixgbe_vlan_offload_config, but ixgbevf_vlan_offload_config,

ixgbevf_dev_start() is below:

                /* Set HW strip */

                mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |

                                ETH_VLAN_EXTEND_MASK;

                err = ixgbevf_vlan_offload_config(dev, mask);

static int

ixgbevf_vlan_offload_config(struct rte_eth_dev *dev, int mask)

{

                struct ixgbe_rx_queue *rxq;

                uint16_t i;

                int on = 0;



                /* VF function only support hw strip feature, others are not support */

                if (mask & ETH_VLAN_STRIP_MASK) {

                                for (i = 0; i < dev->data->nb_rx_queues; i++) {

                                                rxq = dev->data->rx_queues[i];

                                                on = !!(rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP);

                                                ixgbevf_vlan_strip_queue_set(dev, i, on);

                                }

                }



                return 0;

}

Quoted 37 lines

Thanks,

Dave

Quoted 29 lines
Quoted 29 lines



     if (hw->mac.type == ixgbe_mac_82598EB)

                     offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
(quoted diff) +0 -4
-   if (ixgbe_is_vf(dev) == 0)
 
-                   offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
 
-                                        DEV_RX_OFFLOAD_VLAN_EXTEND);
 
-
 
     /*
 
      * RSC is only supported by 82599 and x540 PF devices in a non-SR-

IOV

* mode.

--

2.19.1

#6 lore raw

PATCH v2 1/1 net/ixgbe: Restore vlan filter/extend for ixgbevf

In reply to David Harton

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.c +2 -21
index e92a70fb3..b1b83613e 100644
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)
 #endif
 }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev)
-{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)
 {
@@ -2853,15 +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV
 	 * mode.
Signature · 1 line
2.19.1
#7 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

Or, am I missing something?

Thanks,
Dave

Quoted 70 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +3 -21
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter,
 struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev)
-{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@ -2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-

IOV
* mode.
--
2.19.1

#8 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 11 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 5 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like VLAN_FILTER AND VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I assume you agree with that.

Quoted 4 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more insight?

And same question to VLAN_EXTEND

Quoted 76 lines

Or, am I missing something?

Thanks,
Dave

Quoted 70 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +3 -21
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev)
-{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@ -2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-

IOV
* mode.
--
2.19.1

#9 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi Qi,

Quoted 37 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 14, 2019 11:14 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 10 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 5 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like VLAN_FILTER AND VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I assume you agree with that.

Quoted 4 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

Quoted 5 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more insight?

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Quoted 2 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Thanks,
Dave

Quoted 79 lines
Quoted 21 lines

Or, am I missing something?

Thanks,
Dave

Quoted 13 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 57 lines
Quoted 57 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +3 -20
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@ -2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-

IOV
* mode.
--
2.19.1

#10 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 58 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 11:51 PM
To: Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi Qi,

Quoted 23 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 14, 2019 11:14 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 12 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi Qi,

Quoted 7 lines
Quoted 3 lines

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like VLAN_FILTER

AND

Quoted 1 line

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

assume you agree with that.

Quoted 7 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

Quoted 5 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more insight?

Quoted 7 lines

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver. Properly we need to remove it.

@Wei, would you help to confirm on that?

Thanks
Qi

Quoted 85 lines

Thanks,
Dave

Quoted 81 lines
Quoted 21 lines

Or, am I missing something?

Thanks,
Dave

Quoted 13 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 59 lines
Quoted 59 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads

API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +3 -21
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a

non-SR- IOV
* mode.
--
2.19.1

#11 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 76 lines

-----Original Message-----
From: Zhang, Qi Z
Sent: Friday, March 15, 2019 9:20 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]; Zhao1, Wei <[email protected]>
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 9 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 11:51 PM
To: Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 32 lines

Hi Qi,

Quoted 30 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 14, 2019 11:14 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 10 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 5 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like

VLAN_FILTER

Quoted 21 lines

AND

Quoted 2 lines

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

assume you agree with that.

Quoted 7 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

Quoted 5 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more insight?

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

Quoted 6 lines
Quoted 3 lines

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

It seems kernel pf enable vlan filter by default?
This vf fuction is depend on kernel pf.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Quoted 5 lines

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver.
Properly we need to remove it.

@Wei, would you help to confirm on that?

I will check that later.

Quoted 93 lines

Thanks
Qi

Quoted 38 lines

Thanks,
Dave

Quoted 34 lines
Quoted 22 lines

Or, am I missing something?

Thanks,
Dave

Quoted 14 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 11 lines
Quoted 11 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads

API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct

Quoted 6 lines
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct

ixgbe_adapter

Quoted 44 lines
Quoted 5 lines
Quoted 5 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct · line 2817

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev-

data-

Quoted 38 lines
Quoted 38 lines
Quoted 38 lines
drivers/net/ixgbe/ixgbe_rxtx.c +3 -18
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a

non-SR- IOV
* mode.
--
2.19.1

#12 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

In reply to Zhang, Qi Z

Hi,qi

Quoted 88 lines

-----Original Message-----
From: Zhang, Qi Z
Sent: Friday, March 15, 2019 9:20 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]; Zhao1, Wei <[email protected]>
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 9 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 11:51 PM
To: Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 32 lines

Hi Qi,

Quoted 30 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 14, 2019 11:14 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 10 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 5 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like

VLAN_FILTER

Quoted 17 lines

AND

Quoted 2 lines

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

assume you agree with that.

Quoted 7 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

Quoted 5 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more insight?

Quoted 7 lines

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Quoted 5 lines

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver.
Properly we need to remove it.

@Wei, would you help to confirm on that?

Yes, you are right, kernel pf do not has any code to set bit of IXGBE_DMATXCTL_GDV which enable double valn. So, that means (kernel pf host + dpdk vf) can not enable double valn feature. It seems only dpdk pf host + vf can do that.

Maybe we can change code to
"

	offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;

	if (ixgbe_is_vf(dev) == 0)
		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;

"
But that means when in ENV (kernel pf host + dpdk vf), this is much depended on kernel pf default configuration.

Quoted 93 lines

Thanks
Qi

Quoted 38 lines

Thanks,
Dave

Quoted 34 lines
Quoted 22 lines

Or, am I missing something?

Thanks,
Dave

Quoted 14 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 11 lines
Quoted 11 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads

API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct

Quoted 6 lines
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct

ixgbe_adapter

Quoted 44 lines
Quoted 5 lines
Quoted 5 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct · line 2817

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev-

data-

Quoted 38 lines
Quoted 38 lines
Quoted 38 lines
drivers/net/ixgbe/ixgbe_rxtx.c +3 -18
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a

non-SR- IOV
* mode.
--
2.19.1

#13 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 114 lines

-----Original Message-----
From: Zhao1, Wei
Sent: Friday, March 15, 2019 1:28 PM
To: Zhang, Qi Z <[email protected]>; David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi,qi

Quoted 89 lines

-----Original Message-----
From: Zhang, Qi Z
Sent: Friday, March 15, 2019 9:20 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]; Zhao1, Wei <[email protected]>
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 9 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 11:51 PM
To: Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 32 lines

Hi Qi,

Quoted 30 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 14, 2019 11:14 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 10 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 5 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like

VLAN_FILTER

Quoted 17 lines

AND

Quoted 2 lines

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

assume you agree with that.

Quoted 7 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

Quoted 5 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more insight?

Quoted 7 lines

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Quoted 5 lines

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver.
Properly we need to remove it.

@Wei, would you help to confirm on that?

Yes, you are right, kernel pf do not has any code to set bit of IXGBE_DMATXCTL_GDV which enable double valn.
So, that means (kernel pf host + dpdk vf) can not enable double valn feature. It seems only dpdk pf host + vf can do that.

Quoted 6 lines

Maybe we can change code to
"

	offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;

	if (ixgbe_is_vf(dev) == 0)
		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND; "

+1

Quoted 102 lines

But that means when in ENV (kernel pf host + dpdk vf), this is much depended on kernel pf default configuration.

Quoted 95 lines

Thanks
Qi

Quoted 39 lines

Thanks,
Dave

Quoted 35 lines
Quoted 23 lines

Or, am I missing something?

Thanks,
Dave

Quoted 15 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 11 lines
Quoted 11 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads

API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct

Quoted 6 lines
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct

ixgbe_adapter

Quoted 45 lines
Quoted 5 lines
Quoted 5 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct · line 2817

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev-

data-

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines
drivers/net/ixgbe/ixgbe_rxtx.c +4 -18
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
+*dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a

non-SR- IOV
* mode.
--
2.19.1

#14 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

In reply to Zhao1, Wei
Quoted 96 lines

Hi,qi

Quoted 92 lines

-----Original Message-----
From: Zhang, Qi Z
Sent: Friday, March 15, 2019 9:20 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]; Zhao1, Wei <[email protected]>
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 9 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 11:51 PM
To: Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 32 lines

Hi Qi,

Quoted 30 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 14, 2019 11:14 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 10 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 5 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like

VLAN_FILTER

Quoted 17 lines

AND

Quoted 2 lines

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

assume you agree with that.

Quoted 7 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling rte_eth_dev_configure().

Quoted 5 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more insight?

Quoted 7 lines

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver.
Properly we need to remove it.

Quoted 5 lines
Quoted 1 line

@Wei, would you help to confirm on that?

Yes, you are right, kernel pf do not has any code to set bit of IXGBE_DMATXCTL_GDV which enable double valn. So, that means (kernel pf host + dpdk vf) can not enable double valn feature. It seems only dpdk pf host + vf can do that.

Wonder can vf request pf what is supported?
Konstantin

Quoted 105 lines

Maybe we can change code to
"

	offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;

	if (ixgbe_is_vf(dev) == 0)
		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;

"
But that means when in ENV (kernel pf host + dpdk vf), this is much depended on kernel pf default configuration.

Quoted 93 lines

Thanks
Qi

Quoted 38 lines

Thanks,
Dave

Quoted 34 lines
Quoted 22 lines

Or, am I missing something?

Thanks,
Dave

Quoted 14 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 11 lines
Quoted 11 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads

API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct

Quoted 6 lines
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct

ixgbe_adapter

Quoted 44 lines
Quoted 5 lines
Quoted 5 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct · line 2817

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev-

data-

Quoted 38 lines
Quoted 38 lines
Quoted 38 lines
drivers/net/ixgbe/ixgbe_rxtx.c +3 -18
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a

non-SR- IOV
* mode.
--
2.19.1

#15 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi , Konstantin

Quoted 111 lines

-----Original Message-----
From: Ananyev, Konstantin
Sent: Friday, March 15, 2019 5:24 PM
To: Zhao1, Wei <[email protected]>; Zhang, Qi Z <[email protected]>; David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 67 lines

Hi,qi

Quoted 64 lines

-----Original Message-----
From: Zhang, Qi Z
Sent: Friday, March 15, 2019 9:20 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]; Zhao1, Wei <[email protected]>
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 9 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 11:51 PM
To: Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 32 lines

Hi Qi,

Quoted 30 lines

-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Thursday, March 14, 2019 11:14 AM
To: David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 10 lines

-----Original Message-----
From: David Harton (dharton) [mailto:[email protected]]
Sent: Thursday, March 14, 2019 9:38 PM
To: David Harton (dharton) <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 5 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like

VLAN_FILTER

Quoted 10 lines

AND

Quoted 2 lines

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

assume you agree with that.

Quoted 6 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling

rte_eth_dev_configure().

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more

insight?

Quoted 27 lines
Quoted 25 lines
Quoted 9 lines

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver.
Properly we need to remove it.

@Wei, would you help to confirm on that?

Quoted 7 lines
Quoted 1 line

Yes, you are right, kernel pf do not has any code to set bit of

IXGBE_DMATXCTL_GDV which enable double valn.

Quoted 1 line

So, that means (kernel pf host + dpdk vf) can not enable double valn

feature. It seems only dpdk pf host + vf can do that.

Wonder can vf request pf what is supported?
Konstantin

No such type of message defined in mailbox by now.

Quoted 109 lines
Quoted 10 lines

Maybe we can change code to
"

	offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;

	if (ixgbe_is_vf(dev) == 0)
		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND; "

But that means when in ENV (kernel pf host + dpdk vf), this is much

depended on kernel pf default configuration.

Quoted 98 lines
Quoted 98 lines

Thanks
Qi

Quoted 39 lines

Thanks,
Dave

Quoted 35 lines
Quoted 23 lines

Or, am I missing something?

Thanks,
Dave

Quoted 15 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 11 lines
Quoted 11 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads

API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct

Quoted 6 lines
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct

ixgbe_adapter

Quoted 45 lines
Quoted 5 lines
Quoted 5 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct · line 2817

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev-

data-

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines
drivers/net/ixgbe/ixgbe_rxtx.c +4 -18
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
+*dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a

non-SR- IOV
* mode.
--
2.19.1

#16 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi Wei,

Quoted 57 lines
Quoted 57 lines
Quoted 14 lines
Quoted 14 lines
Quoted 10 lines
Quoted 10 lines
Quoted 6 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like

VLAN_FILTER

Quoted 3 lines

AND

Quoted 2 lines

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

assume you agree with that.

Quoted 6 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling

rte_eth_dev_configure().

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more

insight?

Quoted 28 lines
Quoted 20 lines
Quoted 9 lines

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Quoted 5 lines

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver.
Properly we need to remove it.

@Wei, would you help to confirm on that?

Yes, you are right, kernel pf do not has any code to set bit of

Quoted 8 lines
Quoted 6 lines

IXGBE_DMATXCTL_GDV which enable double valn.

Quoted 1 line

So, that means (kernel pf host + dpdk vf) can not enable double valn

feature. It seems only dpdk pf host + vf can do that.

Wonder can vf request pf what is supported?
Konstantin

No such type of message defined in mailbox by now.

My thought was try to execute command (set vlan) with some dummy value, and analyze response to decide do we provide such capability or not. Or is too much hassle?

Quoted 110 lines
Quoted 110 lines
Quoted 11 lines

Maybe we can change code to
"

	offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;

	if (ixgbe_is_vf(dev) == 0)
		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND; "

But that means when in ENV (kernel pf host + dpdk vf), this is much

depended on kernel pf default configuration.

Quoted 98 lines
Quoted 98 lines

Thanks
Qi

Quoted 39 lines

Thanks,
Dave

Quoted 35 lines
Quoted 23 lines

Or, am I missing something?

Thanks,
Dave

Quoted 15 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 11 lines
Quoted 11 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads

API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct

Quoted 6 lines
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..b1b83613e 100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct

ixgbe_adapter

Quoted 45 lines
Quoted 5 lines
Quoted 5 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct · line 2817

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev-

data-

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines
drivers/net/ixgbe/ixgbe_rxtx.c +4 -18
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  { @@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
+*dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a

non-SR- IOV
* mode.
--
2.19.1

#17 lore raw

Re: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Quoted 75 lines

-----Original Message-----
From: Ananyev, Konstantin
Sent: Friday, March 15, 2019 9:00 PM
To: Zhao1, Wei <[email protected]>; Zhang, Qi Z <[email protected]>; David Harton (dharton) <[email protected]>
Cc: Lu, Wenzhuo <[email protected]>; [email protected]
Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

Hi Wei,

Quoted 63 lines
Quoted 63 lines
Quoted 14 lines
Quoted 14 lines
Quoted 10 lines
Quoted 10 lines
Quoted 6 lines

Hi Qi,

This patch was rejected with no feedback.

Can you share why?

Because as Zhao Wei explained in v1 thread, in ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and DEV_RX_OFFLOAD_VLAN_EXTEND are ignored This looks like

VLAN_FILTER

Quoted 3 lines

AND

Quoted 2 lines

VLAN_EXTEND offload is not supported and I didn't see you reply for that, so I

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

assume you agree with that.

Quoted 6 lines
Quoted 6 lines

Without this patch users are not able to call the rte_eth_dev_vlan_filter() API for ixgbevf based ports because VLAN_FILTER cannot be enabled when calling

rte_eth_dev_configure().

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

OK, seems vlan filter is able to be configured for ixgbevf, but I don't know how this will work because vlan filter table needs to be enabled first (ixgbe_vlan_hw_filter_enable) So at least when it work with a DPDK PF, vlan filter will not work, maybe kernel PF driver will enable it by default? Could you share more

insight?

Quoted 20 lines
Quoted 20 lines
Quoted 9 lines

I can't answer that but ixgbevf_vlan_filter_set() has been implemented for quite some time and it can no longer be called since the new offload flags are being enforced now.

I can share that rte_eth_dev_vlan_filter()/ixgbevf_vlan_filter_set() works properly with the propose change (VLAN traffic flows) where it doesn't without it.

Ok, if it is proved to work well with kernel PF, I think we should have this offload

Quoted 7 lines
Quoted 3 lines

And same question to VLAN_EXTEND

I actually don't care about extend but simply changed it because it seems to be in the same situation. I'm happy to leave it out of the patch if that grants acceptance.

Quoted 8 lines
Quoted 5 lines

Seems VLAN Extend is only supported by DPDK PF driver, I didn't see any related configuration in kernel driver. Properly we need to remove it.

@Wei, would you help to confirm on that?

Yes, you are right, kernel pf do not has any code to set bit of

IXGBE_DMATXCTL_GDV which enable double valn.

Quoted 2 lines

So, that means (kernel pf host + dpdk vf) can not enable double valn

feature. It seems only dpdk pf host + vf can do that.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Wonder can vf request pf what is supported?
Konstantin

No such type of message defined in mailbox by now.

My thought was try to execute command (set vlan) with some dummy value, and analyze response to decide do we provide such capability or not. Or is too much hassle?

Maybe hassle to certain extent for implement, I think.

Quoted 118 lines
Quoted 118 lines
Quoted 118 lines
Quoted 5 lines
Quoted 8 lines

Maybe we can change code to
"

	offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;

	if (ixgbe_is_vf(dev) == 0)
		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND; "

But that means when in ENV (kernel pf host + dpdk vf), this is much

depended on kernel pf default configuration.

Quoted 104 lines
Quoted 104 lines

Thanks
Qi

Quoted 41 lines

Thanks,
Dave

Quoted 37 lines
Quoted 23 lines

Or, am I missing something?

Thanks,
Dave

Quoted 15 lines

-----Original Message-----
From: David Harton <[email protected]>
Sent: Friday, March 08, 2019 3:35 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; David Harton (dharton) <[email protected]>
Subject: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration

time.

Quoted 13 lines
Quoted 13 lines
Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx

offloads
API\")

---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23
++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct

Quoted 7 lines
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index
e92a70fb3..b1b83613e
100644

drivers/net/ixgbe/ixgbe_rxtx.c +0 -0
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct

ixgbe_adapter

Quoted 48 lines
Quoted 5 lines
Quoted 5 lines

drivers/net/ixgbe/ixgbe_rxtx.c ixgbe_reset_rx_queue(struct · line 2817

Quoted 5 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -3
 *adapter, struct ixgbe_rx_queue *rxq)  #endif  }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev) -{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev-

data-

Quoted 42 lines
Quoted 42 lines
Quoted 42 lines
drivers/net/ixgbe/ixgbe_rxtx.c +0 -13
 >dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)  {

@@
-2853,15
+2836,13 @@ ixgbe_get_rx_port_offloads(struct

drivers/net/ixgbe/ixgbe_rxtx.c +4 -4
+rte_eth_dev
+*dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices

in a
non-SR- IOV
* mode.
--
2.19.1

#18 lore raw

PATCH v3 1/1 net/ixgbe: Restore vlan filter/extend for ixgbevf

In reply to David Harton

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.c +2 -2
index e92a70fb3..e71d3c188 100644
@@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
 	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
+		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV
Signature · 1 line
2.19.1
#19 lore raw

PATCH v4 1/1 net/ixgbe: Restore vlan filter for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable the vlan strip offload at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v4: fixed commit headline/log
v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.c +2 -2
index e92a70fb3..e71d3c188 100644
@@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
 	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
+		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV
Signature · 1 line
2.19.1
Acked-by on v4 1/1
#20 lore raw

Re: [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf

Quoted 50 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Harton
Sent: Saturday, March 16, 2019 12:09 AM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; Zhang, Qi Z <[email protected]>; David Harton <[email protected]>
Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable the vlan strip offload at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v4: fixed commit headline/log
v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.c +2 -2
index e92a70fb3..e71d3c188 100644
@@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
 *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
 	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
+		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	/*

* RSC is only supported by 82599 and x540 PF devices in a non-SR-
IOV
--
2.19.1

Applied
#21 lore raw

Re: [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf

Quoted 11 lines

-----Original Message-----
From: Zhao1, Wei
Sent: Monday, March 18, 2019 11:05 AM
To: David Harton <[email protected]>; [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf

Applied to dpdk-next-net-intel.

Thanks
Qi

Quoted 53 lines
Quoted 53 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of David Harton
Sent: Saturday, March 16, 2019 12:09 AM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Ananyev, Konstantin <[email protected]>; Zhang, Qi Z <[email protected]>; David Harton <[email protected]>
Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf

ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation.

Restoring the capbility to enable the vlan strip offload at configuration time.

Fixes ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")

---

v4: fixed commit headline/log
v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..e71d3c188 100644

drivers/net/ixgbe/ixgbe_rxtx.c +2 -2
@@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
 *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
 	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
+		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	/*

* RSC is only supported by 82599 and x540 PF devices in a non-SR-
IOV
--
2.19.1