fscrypt: remove WARN_ON_ONCE() when decryption fails
Eric Biggers
maintainerPATCH 1/1 fscrypt: remove WARN_ON_ONCE() when decryption fails
From: Eric Biggers <[email protected]>
If decrypting a block fails, fscrypt did a WARN_ON_ONCE(). But WARN is meant for kernel bugs, which this isn't; this could be hit by fuzzers using fault injection, for example. Also, there is already a proper warning message logged in fscrypt_do_page_crypto(), so the WARN doesn't add much.
Just remove the unnessary WARN.
--- fs/crypto/bio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
fs/crypto/bio.c +2 -4
@@ -37,12 +37,10 @@ static void __fscrypt_decrypt_bio(struct bio *bio, bool done)int ret =fscrypt_decrypt_page (page->mapping->host, page,PAGE_SIZE ,0 , page->index); -if (ret) { -WARN_ON_ONCE (1 ); +if (ret)SetPageError (page); - }else if (done) { +else if (done)SetPageUptodate (page); - }if (done)unlock_page (page); }
Signature · 1 line
2.21.0.360.g471c308f928-goog
Theodore Ts'o
maintainerQuoted 11 lines · Eric Biggers
From: Eric Biggers <[email protected]>
If decrypting a block fails, fscrypt did a
WARN_ON_ONCE(). But WARN is meant for kernel bugs, which this isn't; this could be hit by fuzzers using fault injection, for example. Also, there is already a proper warning message logged infscrypt_do_page_crypto(), so the WARN doesn't add much.Just remove the unnessary WARN.
Signed-off-by Eric Biggers <[email protected]>
Looks good, applied.
- Ted