Skip to contentSkip to conversation

package/nodejs: requires gcc 4.9

PATCH New Baruch Siach 2 participants 2 messages Mar 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/nodejs: requires gcc 4.9

BUILDING.md lists gcc 4.9.4 or newer as build prerequisite. This is needed for full C++11 support.

https://github.com/nodejs/node/commit/d13a65ad68c429884434cdcd94c52b79a6d69717

---
 package/nodejs/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
package/nodejs/Config.in +4 -4
index d2846f8d579d..ed6225b08efb 100644
@@ -7,19 +7,19 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
 	# libuv
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 
-comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 4.8, wchar"
+comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 4.9, wchar"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
-		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_USE_WCHAR
+		!BR2_HOST_GCC_AT_LEAST_4_9 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_USE_WCHAR
 
 config BR2_PACKAGE_NODEJS
 	bool "nodejs"
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
-	depends on BR2_HOST_GCC_AT_LEAST_4_8
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_HOST_GCC_AT_LEAST_4_9
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	depends on BR2_USE_WCHAR
 	# uses fork()
 	depends on BR2_USE_MMU
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/nodejs: requires gcc 4.9

Quoted 11 lines · On Fri, 15 Mar 2019 11:22:04 +0200 Baruch Siach <[email protected]> wrote:

BUILDING.md lists gcc 4.9.4 or newer as build prerequisite. This is needed for full C++11 support.

https://github.com/nodejs/node/commit/d13a65ad68c429884434cdcd94c52b79a6d69717

---
 package/nodejs/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com