Skip to contentSkip to conversation

Can't build product that uses DEFAULTTUNE="arm926ejs"

DISCUSSION Peter Kjellerstedt 3 participants 6 messages Mar 11, 2019 – Mar 16, 2019

lore
Share & tools
lore
#0 lore raw

I'm trying to build with master of OE-core and one of our products now fails with:

ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:

Error, the PACKAGE_ARCHS variable (all any noarch arm armv4 armv4t armv5 armv5t armv5e armv5te arm926ejste arm926ejse <BSP name withheld>) for DEFAULTTUNE (arm926ejs) does not contain TUNE_PKGARCH (arm926ejst).

I believe this is due to commit ac83d22e (arm-tunes: Remove -march option if mcpu is already added). If I build with Thud, TUNE_PKGARCH is "arm926ejste". The lack of the "e" at the end when building with master seems to be due to the definition of ARMPKGSFX_DSP as "${@bb.utils.contains('TUNE_FEATURES', [ 'armv5', 'dsp' ], 'e', '', d)}" and the fact that after commit ac83d22e, TUNE_FEATURES no longer contains 'armv5'.

//Peter

#1 lore raw
Quoted 12 lines · Peter Kjellerstedt

I'm trying to build with master of OE-core and one of our products now fails with:

ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:

Error, the PACKAGE_ARCHS variable (all any noarch arm armv4 armv4t armv5 armv5t armv5e armv5te arm926ejste arm926ejse <BSP name withheld>) for DEFAULTTUNE (arm926ejs) does not contain TUNE_PKGARCH (arm926ejst).

Quoted 7 lines

I believe this is due to commit ac83d22e (arm-tunes: Remove -march option if mcpu is already added). If I build with Thud, TUNE_PKGARCH is "arm926ejste". The lack of the "e" at the end when building with master seems to be due to the definition of ARMPKGSFX_DSP as "${@bb.utils.contains('TUNE_FEATURES', [ 'armv5', 'dsp' ], 'e', '', d)}" and the fact that after commit ac83d22e, TUNE_FEATURES no longer contains 'armv5'.

right this should now check for armv5t
armv5 has been removed from upstream gcc as well. So we only support armv5t viariants.

Quoted 2 lines

//Peter

#2 lore raw
Quoted 30 lines

-----Original Message-----
From: Khem Raj <[email protected]>
Sent: den 11 mars 2019 05:24
To: Peter Kjellerstedt <[email protected]>
Cc: OE Core ([email protected]) <openembedded- [email protected]>
Subject: Re: Can't build product that uses DEFAULTTUNE="arm926ejs"

Quoted 12 lines · Peter Kjellerstedt

I'm trying to build with master of OE-core and one of our products now fails with:

ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:

Error, the PACKAGE_ARCHS variable (all any noarch arm armv4 armv4t armv5 armv5t armv5e armv5te arm926ejste arm926ejse <BSP name withheld>) for DEFAULTTUNE (arm926ejs) does not contain TUNE_PKGARCH (arm926ejst).

Quoted 7 lines

I believe this is due to commit ac83d22e (arm-tunes: Remove -march option if mcpu is already added). If I build with Thud, TUNE_PKGARCH is "arm926ejste". The lack of the "e" at the end when building with master seems to be due to the definition of ARMPKGSFX_DSP as "${@bb.utils.contains('TUNE_FEATURES', [ 'armv5', 'dsp' ], 'e', '', d)}" and the fact that after commit ac83d22e, TUNE_FEATURES no longer contains 'armv5'.

Quoted 1 line

right this should now check for armv5t

There is no armv5t to check for.

Quoted 4 lines

armv5 has been removed from upstream gcc as well. So we only support armv5t variants.

Quoted 1 line

//Peter

I am by no means any expert on the tuning files (actually they mostly seem like black magic), but I devised an alternative solution for preferring -mcpu over -march that I think is less invasive and without unwanted side effects. I will publish it shortly.

//Peter

#3 lore raw
Quoted 38 lines · Peter Kjellerstedt
Quoted 31 lines

-----Original Message-----
From: Khem Raj <[email protected]>
Sent: den 11 mars 2019 05:24
To: Peter Kjellerstedt <[email protected]>
Cc: OE Core ([email protected]) <openembedded- [email protected]>
Subject: Re: Can't build product that uses DEFAULTTUNE="arm926ejs"

Quoted 12 lines · Peter Kjellerstedt

I'm trying to build with master of OE-core and one of our products now fails with:

ERROR: OE-core's config sanity checker detected a potential misconfiguration.
Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:

Error, the PACKAGE_ARCHS variable (all any noarch arm armv4 armv4t armv5 armv5t armv5e armv5te arm926ejste arm926ejse <BSP name withheld>) for DEFAULTTUNE (arm926ejs) does not contain TUNE_PKGARCH (arm926ejst).

Quoted 7 lines

I believe this is due to commit ac83d22e (arm-tunes: Remove -march option if mcpu is already added). If I build with Thud, TUNE_PKGARCH is "arm926ejste". The lack of the "e" at the end when building with master seems to be due to the definition of ARMPKGSFX_DSP as "${@bb.utils.contains('TUNE_FEATURES', [ 'armv5', 'dsp' ], 'e', '', d)}" and the fact that after commit ac83d22e, TUNE_FEATURES no longer contains 'armv5'.

Quoted 1 line

right this should now check for armv5t

There is no armv5t to check for.

Quoted 3 lines

armv5 has been removed from upstream gcc as well. So we only support armv5t variants.

Quoted 6 lines
Quoted 1 line
Quoted 1 line

//Peter

I am by no means any expert on the tuning files (actually they mostly seem like black magic), but I devised an alternative solution for preferring -mcpu over -march that I think is less invasive and without unwanted side effects. I will publish it shortly.

I saw you sent couple of patch to address this, however I think it can be addressed a bit differently and patch could
be simple. I would be keen if you try it out and see if that fixes your problem

https://patchwork.openembedded.org/patch/159591/

Quoted 3 lines

//Peter

#4 lore raw
Quoted 68 lines

-----Original Message-----
From: Khem Raj <[email protected]>
Sent: den 15 mars 2019 06:09
To: Peter Kjellerstedt <[email protected]>
Cc: OE Core ([email protected]) <openembedded- [email protected]>
Subject: Re: Can't build product that uses DEFAULTTUNE="arm926ejs"

Quoted 6 lines · Peter Kjellerstedt
Quoted 6 lines

-----Original Message-----
From: Khem Raj <[email protected]>
Sent: den 11 mars 2019 05:24
To: Peter Kjellerstedt <[email protected]>
Cc: OE Core ([email protected])

<openembedded-

Quoted 7 lines
Quoted 7 lines

[email protected]>
Subject: Re: Can't build product that uses DEFAULTTUNE="arm926ejs"

Quoted 2 lines · Peter Kjellerstedt

I'm trying to build with master of OE-core and one of our

products

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

now fails with:

ERROR: OE-core's config sanity checker detected a potential

misconfiguration.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Either fix the cause of this error or at your own risk

disable the checker

Quoted 1 line
Quoted 1 line
Quoted 1 line

(see sanity.conf). Following is the list of potential

problems / advisories:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Error, the PACKAGE_ARCHS variable (all any noarch arm armv4

armv4t armv5

Quoted 1 line
Quoted 1 line
Quoted 1 line

armv5t armv5e armv5te arm926ejste arm926ejse <BSP name

withheld>) for

Quoted 1 line
Quoted 1 line
Quoted 1 line

DEFAULTTUNE (arm926ejs) does not contain TUNE_PKGARCH

(arm926ejst).

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

I believe this is due to commit ac83d22e (arm-tunes: Remove -

march

Quoted 1 line
Quoted 1 line
Quoted 1 line

option if mcpu is already added). If I build with Thud,

TUNE_PKGARCH

Quoted 1 line
Quoted 1 line
Quoted 1 line

is "arm926ejste". The lack of the "e" at the end when building

with

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

master seems to be due to the definition of ARMPKGSFX_DSP as "${@bb.utils.contains('TUNE_FEATURES', [ 'armv5', 'dsp' ], 'e',

'', d)}"

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

and the fact that after commit ac83d22e, TUNE_FEATURES no longer contains 'armv5'.

right this should now check for armv5t

There is no armv5t to check for.

Quoted 1 line

armv5 has been removed from upstream gcc as well. So we only

support

Quoted 8 lines
Quoted 3 lines

armv5t variants.

Quoted 1 line

//Peter

I am by no means any expert on the tuning files (actually they mostly seem like black magic), but I devised an alternative solution for preferring -mcpu over -march that I think is less invasive and without unwanted side effects. I will publish it shortly.

Quoted 7 lines

I saw you sent couple of patch to address this, however I think it can be addressed a bit differently and patch could be simple. I would be keen if you try it out and see if that fixes your problem

https://patchwork.openembedded.org/patch/159591/

Quoted 1 line

//Peter

While I agree that your patch will solve the problem with arm926ejs, I believe there are advantages in applying my patches instead. In addition to fixing the problem with arm926ejs, my patches (patch set 4, not patch set 2 that is currently on master-next) also:

* make it so that there is no change to TUNE_FEATURES,
* make it explicit whether -mcpu or -march is used, and
* make the extra arguments added to -mcpu or -march for armv8 explicit.

That last point was something that confused me when I read the original tune files. I did not realize that those extra features were added to whatever -mcpu or -march happened to be added to TUNE_CCARGS before the arch-armv8a.inc file was included (especially as it was written to make it look as they were only added to the -march option).

//Peter

#5 lore raw
Quoted 10 lines · Peter Kjellerstedt

While I agree that your patch will solve the problem with arm926ejs, I believe there are advantages in applying my patches instead. In addition to fixing the problem with arm926ejs, my patches (patch set 4, not patch set 2 that is currently on master-next) also:

* make it so that there is no change to TUNE_FEATURES,
* make it explicit whether -mcpu or -march is used, and
* make the extra arguments added to -mcpu or -march for armv8 explicit.

Quoted 5 lines

That last point was something that confused me when I read the original tune files. I did not realize that those extra features were added to whatever -mcpu or -march happened to be added to TUNE_CCARGS before the arch-armv8a.inc file was included (especially as it was written to make it look as they were only added to the -march option).

For armv8 a larger redesign is actually required - it doesn't scale to have variables like TUNE_FEATURES_tune-armv8a-crc-crypto with 160k possible combinations[1] in gcc 8.

Quoted 1 line

//Peter

cu
Adrian

[1] target architectures 8.0-8.4 and 15 feature modifiers

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed