Skip to contentSkip to conversation

multipath-tools: document why dev_loss_tmo is set to infinity for HPE 3PAR

PATCH RESEND In review Xose Vazquez Perez 2 participants 2 messages Mar 16, 2019 – Mar 29, 2019 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 multipath-tools: document why dev_loss_tmo is set to infinity for HPE 3PAR

It's needed by Peer Persistence, documented in SLES and RHEL guides:
https://support.hpe.com/hpsc/doc/public/display?docId=a00053835
https://support.hpe.com/hpsc/doc/public/display?docId=c04448818

Cc Christophe Varoqui <[email protected]>
Cc DM-DEVEL ML <[email protected]>
---
 libmultipath/hwtable.c | 1 +
 1 file changed, 1 insertion(+)
libmultipath/hwtable.c +1 -0
index d3a8d9b..543bacd 100644
@@ -116,6 +116,7 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ALUA,
 		.no_path_retry = 18,
 		.fast_io_fail  = 10,
+		/* infinity is needed by Peer Persistence */
 		.dev_loss      = MAX_DEV_LOSS_TMO,
 	},
 	{
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Xose Vazquez Perez

It's needed by Peer Persistence, documented in SLES and RHEL guides:
https://support.hpe.com/hpsc/doc/public/display?docId=a00053835
https://support.hpe.com/hpsc/doc/public/display?docId=c04448818

Cc Christophe Varoqui <[email protected]>
Cc DM-DEVEL ML <[email protected]>
---
 libmultipath/hwtable.c | 1 +
 1 file changed, 1 insertion(+)
libmultipath/hwtable.c +0 -0
index d3a8d9b..543bacd 100644

libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 122

Quoted 7 lines
libmultipath/hwtable.c +1 -0
@@ -116,6 +116,7 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ALUA,
 		.no_path_retry = 18,
 		.fast_io_fail  = 10,
+		/* infinity is needed by Peer Persistence */
 		.dev_loss      = MAX_DEV_LOSS_TMO,
 	},
 	{

I'm not quite getting the benefit of adding this comment without further explanation what Peer Persistence is. Also, IMO, setting dev_loss_tmo to a higher value than the default (contrary to lowering it) doesn't require much justification.

But it can't really hurt, so: