Skip to contentSkip to conversation

dma: mediatek: addres minor style issues flagged by clang-format.

PATCH In review Armando Miraglia 2 participants 2 messages Mar 17, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma: mediatek: addres minor style issues flagged by clang-format.

Running clang-format on mtk-hsdma.c I noticed that few lines would not need to be wrapped, since they fit 80 columns. This change changes such lines to better fit the style-guide.

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/mt7621-dma/mtk-hsdma.c +2 -4
index 97571f1d697b..74c374f7bef4 100644
@@ -264,8 +264,7 @@ static void mtk_hsdma_reset(struct mtk_hsdam_engine *hsdma,
 	/* init desc value */
 	for (i = 0; i < HSDMA_DESCS_NUM; i++) {
 		chan->tx_ring[i].addr0 = 0;
-		chan->tx_ring[i].flags = HSDMA_DESC_LS0 |
-			HSDMA_DESC_DONE;
+		chan->tx_ring[i].flags = HSDMA_DESC_LS0 | HSDMA_DESC_DONE;
 	}
 	for (i = 0; i < HSDMA_DESCS_NUM; i++) {
 		chan->rx_ring[i].addr0 = 0;
@@ -435,8 +434,7 @@ static irqreturn_t mtk_hsdma_irq(int irq, void *devid)
 	if (likely(status & HSDMA_INT_RX_Q0))
 		tasklet_schedule(&hsdma->task);
 	else
-		dev_dbg(hsdma->ddev.dev, "unhandle irq status %08x\n",
-			status);
+		dev_dbg(hsdma->ddev.dev, "unhandle irq status %08x\n", status);
 	/* clean intr bits */
 	mtk_hsdma_write(hsdma, HSDMA_REG_INT_STATUS, status);
 
Signature · 1 line
2.21.0.360.g471c308f928-goog
Acked-by on v1 1/1
#1 lore raw
Quoted 25 lines · Armando Miraglia

Running clang-format on mtk-hsdma.c I noticed that few lines would not need to be wrapped, since they fit 80 columns. This change changes such lines to better fit the style-guide.

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -2
index 97571f1d697b..74c374f7bef4 100644
@@ -264,8 +264,7 @@ static void mtk_hsdma_reset(struct mtk_hsdam_engine *hsdma,
        /* init desc value */
        for (i = 0; i < HSDMA_DESCS_NUM; i++) {
                chan->tx_ring[i].addr0 = 0;
-               chan->tx_ring[i].flags = HSDMA_DESC_LS0 |
-                       HSDMA_DESC_DONE;
+               chan->tx_ring[i].flags = HSDMA_DESC_LS0 | HSDMA_DESC_DONE;
        }
        for (i = 0; i < HSDMA_DESCS_NUM; i++) {
                chan->rx_ring[i].addr0 = 0;

drivers/staging/mt7621-dma/mtk-hsdma.c static irqreturn_t mtk_hsdma_irq(int irq, void *devid) · line 440

Quoted 9 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -2
@@ -435,8 +434,7 @@ static irqreturn_t mtk_hsdma_irq(int irq, void *devid)
        if (likely(status & HSDMA_INT_RX_Q0))
                tasklet_schedule(&hsdma->task);
        else
-               dev_dbg(hsdma->ddev.dev, "unhandle irq status %08x\n",
-                       status);
+               dev_dbg(hsdma->ddev.dev, "unhandle irq status %08x\n", status);
        /* clean intr bits */
        mtk_hsdma_write(hsdma, HSDMA_REG_INT_STATUS, status);
 
Quoted 8 lines

--
2.21.0.360.g471c308f928-goog

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek