Skip to contentSkip to conversation

staging: vc04_services: Add blank line after struct declaration

PATCH In review Emanuel Bennici 2 participants 4 messages Mar 17, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 staging: vc04_services: Add blank line after struct declaration

---
 drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/vc04_services/interface/vchi/vchi.h +1 -0
index 7b13cb04c119..43eaf7703777 100644
@@ -55,6 +55,7 @@ struct vchi_version {
 	uint32_t version;
 	uint32_t version_min;
 };
+
 #define VCHI_VERSION(v_) { v_, v_ }
 #define VCHI_VERSION_EX(v_, m_) { v_, m_ }
 
Signature · 1 line
2.19.1
#2 lore raw

Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:

Quoted 6 lines · Emanuel Bennici
Quoted 4 lines
---
 drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
 1 file changed, 1 insertion(+)

I can not take patches without any changelog information, sorry.

Add blank Line after declaration of struct vchi_version to fix checkpatch.pl Check CHECK: Please use a blank line after function/struct/union/enum declarations.

---
 drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +

 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/staging/vc04_services/interface/vchi/vchi.h index 7b13cb04c119..43eaf7703777 100644

drivers/staging/vc04_services/interface/vchi/vchi.h +0 -0
@@ -55,6 +55,7 @@ struct vchi_version {

     uint32_t version;
     uint32_t version_min;
 };
+
 #define VCHI_VERSION(v_) { v_, v_ }
 #define VCHI_VERSION_EX(v_, m_) { v_, m_ }

Signature · 1 line
2.19.1
#3 lore raw
Quoted 9 lines · Emanuel Bennici

Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:

Quoted 6 lines · Emanuel Bennici
Quoted 4 lines
---
 drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
 1 file changed, 1 insertion(+)

I can not take patches without any changelog information, sorry.

Quoted 9 lines

Add blank Line after declaration of struct vchi_version to fix checkpatch.pl Check CHECK: Please use a blank line after function/struct/union/enum declarations.

---
 drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +

 1 file changed, 1 insertion(+)

<snip>

Sorry, I can't take a patch that I have to hand-edit either.

Please fix up and resend the series correctly, with a proper version information about what changed from the previous patch series as the kernel process documentation explains.

thanks,

greg k-h