staging: speakup: fix line over 80 characters.
PATCH 1/1 staging: speakup: fix line over 80 characters.
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
--- drivers/staging/speakup/kobjects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/speakup/kobjects.c +2 -2
@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: here we need temp to be updated */ index =simple_strtoul (cp, &temp,10 );if (index >255 ) { rejected++;
@@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: here we need temp to be updated */ index =simple_strtoul (cp, &temp,10 );while ((temp < linefeed) && (*temp ==' ' || *temp =='\t' ))
Signature · 1 line
2.20.1
Quoted 11 lines · Jules Irenge
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".--- drivers/staging/speakup/kobjects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/speakup/kobjects.c +0
-0
drivers/staging/speakup/kobjects.c static ssize_t chars_chartab_store(struct kobject *kobj, · line 157
Quoted 5 lines
drivers/staging/speakup/kobjects.c +1
-1@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: here we need temp to be updated */
It's only a few characters over 80. Maybe you can rephrase the comment instead.
julia
Quoted 22 lines
drivers/staging/speakup/kobjects.c +1
-2index =simple_strtoul (cp, &temp,10 );if (index >255 ) { rejected++;@@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: here we need temp to be updated */ index =simple_strtoul (cp, &temp,10 );while ((temp < linefeed) && (*temp ==' ' || *temp =='\t' )) --2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190317033946.12585-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 11 lines · Jules Irenge
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".--- drivers/staging/speakup/kobjects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/speakup/kobjects.c +0
-0
drivers/staging/speakup/kobjects.c static ssize_t chars_chartab_store(struct kobject *kobj, · line 157
Quoted 5 lines
drivers/staging/speakup/kobjects.c +1
-1@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: here we need temp to be updated */
No, never put code or comments this far to the left. Instead, properly line-wrap them.
thanks,
greg k-h