Skip to contentSkip to conversation

test/py: Fix pytest4 deprecation warnings

PATCH New Marek Vasut 2 participants 17 messages Mar 13, 2019 – Mar 17, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
---
 test/py/conftest.py | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
test/py/conftest.py +4 -8
index e40cbf0ba1..745ca5ac4a 100644
@@ -431,11 +431,9 @@ def setup_boardspec(item):
         Nothing.
     """
 
-    mark = item.get_marker('boardspec')
-    if not mark:
-        return
     required_boards = []
-    for board in mark.args:
+    for boards in item.iter_markers('boardspec'):
+        board = boards.args[0]
         if board.startswith('!'):
             if ubconfig.board_type == board[1:]:
                 pytest.skip('board "%s" not supported' % ubconfig.board_type)
@@ -459,10 +457,8 @@ def setup_buildconfigspec(item):
         Nothing.
     """
 
-    mark = item.get_marker('buildconfigspec')
-    if not mark:
-        return
-    for option in mark.args:
+    for options in item.iter_markers('buildconfigspec'):
+        option = options.args[0]
         if not ubconfig.buildconfig.get('config_' + option.lower(), None):
             pytest.skip('.config feature "%s" not enabled' % option.lower())
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 7 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

Quoted 6 lines

In both cases, the later suggestion is applicable.

Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190313/3c7aead8/attachment.sig>
#2 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines
Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 17 lines · Marek Vasut
Quoted 16 lines · Tom Rini
Quoted 13 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Quoted 6 lines
Quoted 3 lines

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

And wrt making our python stuff happier with newer versions, I'm far more worried about all of the python2-and-not-3 scripts we have currently. :(

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190313/1b6b7b0d/attachment.sig>
#4 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 22 lines · Tom Rini
Quoted 21 lines · Marek Vasut
Quoted 19 lines · Tom Rini
Quoted 7 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

Quoted 6 lines

In both cases, the later suggestion is applicable.

Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

Quoted 8 lines
Quoted 2 lines

That's what's in debian testing though, so maybe we need to support it somehow.

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Quoted 3 lines

And wrt making our python stuff happier with newer versions, I'm far more worried about all of the python2-and-not-3 scripts we have currently. :(

Right

Signature · 2 lines
Best regards,
Marek Vasut
#5 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines
Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190313/6b0391e7/attachment.sig>
#6 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 33 lines · Tom Rini
Quoted 32 lines · Marek Vasut
Quoted 30 lines · Tom Rini
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Tom Rini
Quoted 13 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Quoted 6 lines
Quoted 3 lines

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Quoted 5 lines
Quoted 1 line

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

While I'm not a python expert, shouldn't virtualenv help with that ?

Signature · 2 lines
Best regards,
Marek Vasut
#7 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 34 lines · Marek Vasut
Quoted 33 lines · Tom Rini
Quoted 32 lines · Marek Vasut
Quoted 30 lines · Tom Rini
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Tom Rini
Quoted 13 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>
Quoted 6 lines
Quoted 3 lines

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190313/e6e8e5fa/attachment.sig>
#8 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 37 lines · Tom Rini
Quoted 36 lines · Marek Vasut
Quoted 35 lines · Tom Rini
Quoted 33 lines · Marek Vasut
Quoted 22 lines · Tom Rini
Quoted 21 lines · Marek Vasut
Quoted 19 lines · Tom Rini
Quoted 7 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

Quoted 6 lines

In both cases, the later suggestion is applicable.

Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

Quoted 8 lines
Quoted 2 lines

That's what's in debian testing though, so maybe we need to support it somehow.

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

Signature · 2 lines
Best regards,
Marek Vasut
#9 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines
Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

So no, I'm not going to change the setup that's working for existing installs today. Frankly, the whole thing has me sighing rather loudly and figuring the only path forward is that yes, we'll have to mandate _everyone_ use a virtualenv and some helper script around that so it's not too painful. But all of that is much less important that getting away from python2.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190313/471bd000/attachment.sig>
#10 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 51 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines
Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

Quoted 8 lines

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

I don't think I get your point here. Sure, old distros might need to change and start using virtualenv because the software is just too old. We cannot support all kinds of old stuff. If the API we're using is getting deprecated, let's just switch to the new one and ask the users of old software to upgrade (?).

Quoted 6 lines

So no, I'm not going to change the setup that's working for existing installs today. Frankly, the whole thing has me sighing rather loudly and figuring the only path forward is that yes, we'll have to mandate _everyone_ use a virtualenv and some helper script around that so it's not too painful. But all of that is much less important that getting away from python2.

I think that's a bit off-topic here. However, what's still stuck on python2 ?

Signature · 2 lines
Best regards,
Marek Vasut
#11 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 61 lines · Marek Vasut
Quoted 51 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines
Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

Quoted 8 lines

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

Quoted 5 lines

I don't think I get your point here. Sure, old distros might need to change and start using virtualenv because the software is just too old. We cannot support all kinds of old stuff. If the API we're using is getting deprecated, let's just switch to the new one and ask the users of old software to upgrade (?).

My point is that "pin to a newer pytest version" is not something I want right now. It will break existing setups and provide nothing in return. There's not some new feature of pytest we're missing out on. My take away from all of this is that we need to move the whole thing into being wrapped up, for everyone, as we cannot expect random community python modules to remove an API in an extremely quick fashion. If you're motivated enough over this to go off and do that, yes, sure. But I will not take a patch this patch as-is, as it breaks travis-ci. I will not take a v2 of this patch that is the above plus pinning to a new pytest as that's just going to push the problem from "Debian/Buster and others people need to continue to setup virtualenv" to "Ubuntu 16.04 and other people now need to setup virtualenv". That's just pushing the problem around and not making anything better.

Quoted 9 lines
Quoted 6 lines

So no, I'm not going to change the setup that's working for existing installs today. Frankly, the whole thing has me sighing rather loudly and figuring the only path forward is that yes, we'll have to mandate _everyone_ use a virtualenv and some helper script around that so it's not too painful. But all of that is much less important that getting away from python2.

I think that's a bit off-topic here. However, what's still stuck on python2 ?

$ git grep -il python2
Documentation/sphinx/kerneldoc.py
Makefile
scripts/dtc/pylibfdt/Makefile
scripts/dtc/pylibfdt/setup.py
scripts/fill_scrapyard.py
scripts/mailmapper
test/py/test.py
tools/binman/binman.py
tools/buildman/buildman.py
tools/dtoc/dtoc.py
tools/genboardscfg.py
tools/microcode-tool.py
tools/moveconfig.py
tools/patman/patman.py
tools/rkmux.py
Quoted 4 lines
Signature · 3 lines
-- 
Best regards,
Marek Vasut
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190313/dfbecdcc/attachment.sig>
#12 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 62 lines · Tom Rini
Quoted 61 lines · Marek Vasut
Quoted 59 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines
Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

Quoted 8 lines
Quoted 5 lines

I don't think I get your point here. Sure, old distros might need to change and start using virtualenv because the software is just too old. We cannot support all kinds of old stuff. If the API we're using is getting deprecated, let's just switch to the new one and ask the users of old software to upgrade (?).

My point is that "pin to a newer pytest version" is not something I want right now. It will break existing setups and provide nothing in return.

Besides, using latest code instead of old stuff, as we should ? If your existing setup breaks, maybe you should update your existing setup.

Quoted 6 lines

There's not some new feature of pytest we're missing out on. My take away from all of this is that we need to move the whole thing into being wrapped up, for everyone, as we cannot expect random community python modules to remove an API in an extremely quick fashion. If you're motivated enough over this to go off and do that, yes, sure. But I will not take a patch this patch as-is, as it breaks travis-ci.

Cool, and without this patch, all the tests fail on debian testing. So maybe travis needs an update ?

Quoted 6 lines

I will not
take a v2 of this patch that is the above plus pinning to a new pytest as that's just going to push the problem from "Debian/Buster and others people need to continue to setup virtualenv" to "Ubuntu 16.04 and other people now need to setup virtualenv". That's just pushing the problem around and not making anything better.

I think everyone should just setup virtualenv if their setup is too old?

Quoted 32 lines
Quoted 9 lines
Quoted 6 lines

So no, I'm not going to change the setup that's working for existing installs today. Frankly, the whole thing has me sighing rather loudly and figuring the only path forward is that yes, we'll have to mandate _everyone_ use a virtualenv and some helper script around that so it's not too painful. But all of that is much less important that getting away from python2.

I think that's a bit off-topic here. However, what's still stuck on python2 ?

$ git grep -il python2
Documentation/sphinx/kerneldoc.py
Makefile
scripts/dtc/pylibfdt/Makefile
scripts/dtc/pylibfdt/setup.py
scripts/fill_scrapyard.py
scripts/mailmapper
test/py/test.py
tools/binman/binman.py
tools/buildman/buildman.py
tools/dtoc/dtoc.py
tools/genboardscfg.py
tools/microcode-tool.py
tools/moveconfig.py
tools/patman/patman.py
tools/rkmux.py
Quoted 4 lines
Signature · 3 lines
-- 
Best regards,
Marek Vasut
Signature · 2 lines
Best regards,
Marek Vasut
#13 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 69 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Marek Vasut
Quoted 51 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines

Signed-off-by: Marek Vasut <[email protected]>
Cc: Igor Opaniuk <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

Quoted 8 lines

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

I don't think I get your point here. Sure, old distros might need to change and start using virtualenv because the software is just too old. We cannot support all kinds of old stuff. If the API we're using is getting deprecated, let's just switch to the new one and ask the users of old software to upgrade (?).

Quoted 4 lines
Quoted 2 lines

My point is that "pin to a newer pytest version" is not something I want right now. It will break existing setups and provide nothing in return.

Besides, using latest code instead of old stuff, as we should ?

We should? What's the reason we need to upgrade? What problem we have is being fixed?

Quoted 1 line

If your existing setup breaks, maybe you should update your existing setup.

No, we don't break existing setups.

Quoted 8 lines
Quoted 6 lines

There's not some new feature of pytest we're missing out on. My take away from all of this is that we need to move the whole thing into being wrapped up, for everyone, as we cannot expect random community python modules to remove an API in an extremely quick fashion. If you're motivated enough over this to go off and do that, yes, sure. But I will not take a patch this patch as-is, as it breaks travis-ci.

Cool, and without this patch, all the tests fail on debian testing.

Everyone else is using virtualenv.

Quoted 1 line

So maybe travis needs an update ?

Please go ${search_engine} the problem. TL;DR, sure, just as soon as that's possible!

Quoted 8 lines
Quoted 6 lines

I will not
take a v2 of this patch that is the above plus pinning to a new pytest as that's just going to push the problem from "Debian/Buster and others people need to continue to setup virtualenv" to "Ubuntu 16.04 and other people now need to setup virtualenv". That's just pushing the problem around and not making anything better.

I think everyone should just setup virtualenv if their setup is too old?

Nope. If we're going to do anything about this, we're going to fix the problem so we don't have the problem again in a year, when another API gets removed. We're not going to break people that have a working setup already.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190315/551d8c8d/attachment.sig>
#14 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 70 lines · Tom Rini
Quoted 69 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Marek Vasut
Quoted 51 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 19 lines · Tom Rini

On Wed, Mar 13, 2019 at 05:08:14AM +0100, Marek Vasut wrote:

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Signed-off-by: Marek Vasut <[email protected]>
Cc: Igor Opaniuk <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll
need to use virtualenv to set that up if needed. There is not, AFAICT,
a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

Quoted 8 lines

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

I don't think I get your point here. Sure, old distros might need to change and start using virtualenv because the software is just too old. We cannot support all kinds of old stuff. If the API we're using is getting deprecated, let's just switch to the new one and ask the users of old software to upgrade (?).

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

My point is that "pin to a newer pytest version" is not something I want right now. It will break existing setups and provide nothing in return.

Besides, using latest code instead of old stuff, as we should ?

We should? What's the reason we need to upgrade? What problem we have is being fixed?

With this reasoning, we could've stuck to gcc 2.95 too though. Why didn't we ?

Quoted 3 lines
Quoted 1 line

If your existing setup breaks, maybe you should update your existing setup.

No, we don't break existing setups.

Heh? Seems to happen all the time with the DM/DT stuff.

Quoted 10 lines
Quoted 8 lines
Quoted 6 lines

There's not some new feature of pytest we're missing out on. My take away from all of this is that we need to move the whole thing into being wrapped up, for everyone, as we cannot expect random community python modules to remove an API in an extremely quick fashion. If you're motivated enough over this to go off and do that, yes, sure. But I will not take a patch this patch as-is, as it breaks travis-ci.

Cool, and without this patch, all the tests fail on debian testing.

Everyone else is using virtualenv.

Everyone else, but ancient systems, OK.

Quoted 4 lines
Quoted 1 line

So maybe travis needs an update ?

Please go ${search_engine} the problem. TL;DR, sure, just as soon as that's possible!

So why can't travis use virtualenv ? How do other systems set up various python versions on travis ?

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

I will not
take a v2 of this patch that is the above plus pinning to a new pytest as that's just going to push the problem from "Debian/Buster and others people need to continue to setup virtualenv" to "Ubuntu 16.04 and other people now need to setup virtualenv". That's just pushing the problem around and not making anything better.

Quoted 6 lines
Quoted 1 line

I think everyone should just setup virtualenv if their setup is too old?

Nope. If we're going to do anything about this, we're going to fix the problem so we don't have the problem again in a year, when another API gets removed. We're not going to break people that have a working setup already.

I think I'll use that argument at some point :)

Signature · 2 lines
Best regards,
Marek Vasut
#15 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

Quoted 116 lines · Marek Vasut
Quoted 70 lines · Tom Rini
Quoted 69 lines · Marek Vasut
Quoted 68 lines · Tom Rini
Quoted 66 lines · Marek Vasut
Quoted 51 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut

On 3/13/19 12:19 PM, Tom Rini wrote:
On Wed, Mar 13, 2019 at 05:08:14AM +0100, Marek Vasut wrote:

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Signed-off-by: Marek Vasut <[email protected]>
Cc: Igor Opaniuk <[email protected]>
Cc: Tom Rini <[email protected]>
Cc: Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll
need to use virtualenv to set that up if needed. There is not, AFAICT,
a way to support both versions.

That's what's in debian testing though, so maybe we need to support it
somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

Quoted 8 lines

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

I don't think I get your point here. Sure, old distros might need to change and start using virtualenv because the software is just too old. We cannot support all kinds of old stuff. If the API we're using is getting deprecated, let's just switch to the new one and ask the users of old software to upgrade (?).

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

My point is that "pin to a newer pytest version" is not something I want right now. It will break existing setups and provide nothing in return.

Besides, using latest code instead of old stuff, as we should ?

We should? What's the reason we need to upgrade? What problem we have is being fixed?

With this reasoning, we could've stuck to gcc 2.95 too though. Why didn't we ?

Quoted 3 lines
Quoted 1 line

If your existing setup breaks, maybe you should update your existing setup.

No, we don't break existing setups.

Heh? Seems to happen all the time with the DM/DT stuff.

Quoted 10 lines
Quoted 8 lines
Quoted 6 lines

There's not some new feature of pytest we're missing out on. My take away from all of this is that we need to move the whole thing into being wrapped up, for everyone, as we cannot expect random community python modules to remove an API in an extremely quick fashion. If you're motivated enough over this to go off and do that, yes, sure. But I will not take a patch this patch as-is, as it breaks travis-ci.

Cool, and without this patch, all the tests fail on debian testing.

Everyone else is using virtualenv.

Everyone else, but ancient systems, OK.

Quoted 4 lines
Quoted 1 line

So maybe travis needs an update ?

Please go ${search_engine} the problem. TL;DR, sure, just as soon as that's possible!

So why can't travis use virtualenv ? How do other systems set up various python versions on travis ?

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

I will not
take a v2 of this patch that is the above plus pinning to a new pytest as that's just going to push the problem from "Debian/Buster and others people need to continue to setup virtualenv" to "Ubuntu 16.04 and other people now need to setup virtualenv". That's just pushing the problem around and not making anything better.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

I think everyone should just setup virtualenv if their setup is too old?

Nope. If we're going to do anything about this, we're going to fix the problem so we don't have the problem again in a year, when another API gets removed. We're not going to break people that have a working setup already.

I think I'll use that argument at some point :)

I don't even know what to say at this point.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190316/d7bfef90/attachment.sig>
#16 lore raw

PATCH 1/1 test/py: Fix pytest4 deprecation warnings

In reply to Tom Rini
Quoted 68 lines · Tom Rini
Quoted 61 lines · Marek Vasut
Quoted 51 lines · Tom Rini
Quoted 42 lines · Marek Vasut
Quoted 41 lines · Tom Rini
Quoted 40 lines · Marek Vasut
Quoted 38 lines · Tom Rini
Quoted 26 lines · Marek Vasut
Quoted 25 lines · Tom Rini
Quoted 23 lines · Marek Vasut
Quoted 11 lines · Tom Rini
Quoted 9 lines · Marek Vasut

Fix the following spit from pytest:

u-boot/test/py/conftest.py:438: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
for board in mark.args:

In both cases, the later suggestion is applicable.

Quoted 8 lines
Quoted 4 lines
Cc Igor Opaniuk <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

Deferred, for now we don't support newer pytest than 2.8.7 and you'll need to use virtualenv to set that up if needed. There is not, AFAICT, a way to support both versions.

That's what's in debian testing though, so maybe we need to support it somehow.

Quoted 7 lines
Quoted 5 lines

Yes, I'm _very_ frustrated at the speed at which pytest went from "this is the API" to "this API is deprecated" to "this API doesn't work and here's the new, incompatible API". Debian/testing needs to use virtualenv to setup a python area with older pytest installed, just like we do in .travis.yml.

Can't we rather have people use the new APIs and virtualenv new python?

Not as easily, no. Debian/testing may have something much newer but Debian/stable doesn't, and I don't know what Ubuntu/18.04 has off-hand but it's probably inbetween and so on.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

While I'm not a python expert, shouldn't virtualenv help with that ?

Yes, and breaking old setups is usually frowned upon and making new setups conform to the existing ways is how things are usually done.

If you use venv with old setup, won't that give you the new python you need ?

Quoted 8 lines

No, you don't need to. Travis is special in that it's based on Ubuntu 14.04 (!!!!) and so we needed to use pip there to setup anything, and have for forever. That in turn lead to us hitting this problem a while back, when "pip install pytest" first gave us something where the old behavior became a fatal error. That leads to installing the last version before pytest starts to complain about changing APIs. Normally old distributions however ship with 2.8.7 anyways and don't need virtaulenv.

Quoted 5 lines

I don't think I get your point here. Sure, old distros might need to change and start using virtualenv because the software is just too old. We cannot support all kinds of old stuff. If the API we're using is getting deprecated, let's just switch to the new one and ask the users of old software to upgrade (?).

Quoted 13 lines

My point is that "pin to a newer pytest version" is not something I want right now. It will break existing setups and provide nothing in return. There's not some new feature of pytest we're missing out on. My take away from all of this is that we need to move the whole thing into being wrapped up, for everyone, as we cannot expect random community python modules to remove an API in an extremely quick fashion. If you're motivated enough over this to go off and do that, yes, sure. But I will not take a patch this patch as-is, as it breaks travis-ci. I will not take a v2 of this patch that is the above plus pinning to a new pytest as that's just going to push the problem from "Debian/Buster and others people need to continue to setup virtualenv" to "Ubuntu 16.04 and other people now need to setup virtualenv". That's just pushing the problem around and not making anything better.

I might not have been clear enough here, so let me elaborate a little more. We do not follow now-normal conventions for using python modules. We need to change things such that 'make tests' does a 'pip -r requirements.txt' so that we use pip to install everything, and we need to setup a virtualenv to do that in. At that point we'll be following normal conventions and best practices (more closely anyhow, ugh, test.py is another python2 script) and can easily move from pytest 2.8.7 to whatever-later-version because we can do it atomically and not break anyone. As a bonus we'll have better control over our QA environment which is a good thing. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190317/f837486d/attachment.sig>