Skip to contentSkip to conversation

arm: kirkwood: lsxl: disable dcache

PATCH New Michael Walle 2 participants 2 messages Mar 17, 2019 – Mar 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: kirkwood: lsxl: disable dcache

Both the network as well as the USB driver are not working with the data cache enabled.

---
 include/configs/lsxl.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/lsxl.h +1 -0
index 9d4be18413..728263910e 100644
@@ -32,6 +32,7 @@
 #define CONFIG_SHOW_BOOT_PROGRESS
 
 #define CONFIG_KIRKWOOD_GPIO
+#define CONFIG_SYS_DCACHE_OFF
 
 /*
  * Commands configuration
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 arm: kirkwood: lsxl: disable dcache

Quoted 14 lines · Michael Walle

Both the network as well as the USB driver are not working with the data cache enabled.

---
 include/configs/lsxl.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/lsxl.h +0 -0
index 9d4be18413..728263910e 100644

include/configs/lsxl.h line 36

Quoted 5 lines
include/configs/lsxl.h +1 -0
@@ -32,6 +32,7 @@
 #define CONFIG_SHOW_BOOT_PROGRESS
 
 #define CONFIG_KIRKWOOD_GPIO
+#define CONFIG_SYS_DCACHE_OFF
 

Having said that I'm wondering if this should be in arch/arm/mach-kirkwood/include/mach/config.h or automatically selected via Kconfig. As far as I can tell prior to commit 93b283d49f93 ("ARM:
CPU: arm926ejs: Consolidate cache routines to common file") the kirkwood boards didn't have and dcache support. It might be possible to update the various drivers to use the proper DMA apis but for 2019.03 I think it might be safer just to run with CONFIG_SYS_DCACHE_OFF.

Quoted 9 lines
include/configs/lsxl.h +0 -1
 /*
  * Commands configuration
--

2.11.0

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot