ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration
Subsystems (2)
PATCH 1/1 ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration
From: Colin Ian King <[email protected]>
The function snd_opl3_drum_switch declaration in the header file has the order of the two arguments on_off and vel swapped when compared to the definition arguments of vel and on_off. Fix this by swapping them around to match the definition.
This error predates the git history, so no idea when this error was introduced.
--- sound/drivers/opl3/opl3_voice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/drivers/opl3/opl3_voice.h +1 -1
@@ -41,7 +41,7 @@ void snd_opl3_timer_func(struct timer_list *t);/* Prototypes for opl3_drums.c */ void snd_opl3_load_drums (struct snd_opl3 *opl3); -void snd_opl3_drum_switch (struct snd_opl3 *opl3,int note,int on_off,int vel,struct snd_midi_channel *chan); +void snd_opl3_drum_switch (struct snd_opl3 *opl3,int note,int vel,int on_off,struct snd_midi_channel *chan);/* Prototypes for opl3_oss.c */ #if IS_ENABLED (CONFIG_SND_SEQUENCER_OSS )
Signature · 1 line
2.20.1
Takashi Iwai
AppliedQuoted 8 lines · Colin King
From: Colin Ian King <[email protected]>
The function
snd_opl3_drum_switchdeclaration in the header file has the order of the two argumentson_offand vel swapped when compared to the definition arguments of vel andon_off. Fix this by swapping them around to match the definition.
Quoted 4 lines
This error predates the git history, so no idea when this error was introduced.
Signed-off-by Colin Ian King <[email protected]>
Thanks, applied.
Takashi