percpu: stop printing kernel addresses
Subsystems (2)
PATCH 1/1 percpu: stop printing kernel addresses
Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), at boot "____ptrval____" is printed instead of actual addresses:
percpu: Embedded 38 pages/cpu @(____ptrval____) s124376 r0 d31272 u524288
Instead of changing the print to "%px", and leaking kernel addresses, just remove the print completely, cfr. e.g. commit 071929dbdd865f77 ("arm64: Stop printing the virtual memory layout").
--- mm/percpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
mm/percpu.c +4 -4
@@ -2567,8 +2567,8 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size, ai->groups[group].base_offset = areas[group] - base; } -pr_info ("Embedded %zu pages/cpu @%p s%zu r%zu d%zu u%zu\n" , -PFN_DOWN (size_sum), base, ai->static_size, ai->reserved_size, +pr_info ("Embedded %zu pages/cpu s%zu r%zu d%zu u%zu\n" , +PFN_DOWN (size_sum), ai->static_size, ai->reserved_size, ai->dyn_size, ai->unit_size); rc =pcpu_setup_first_chunk (ai, base);
@@ -2692,8 +2692,8 @@ int __init pcpu_page_first_chunk(size_t reserved_size, }/* we're ready, commit */ -pr_info ("%d %s pages/cpu @%p s%zu r%zu d%zu\n" , - unit_pages, psize_str, vm.addr, ai->static_size, +pr_info ("%d %s pages/cpu s%zu r%zu d%zu\n" , + unit_pages, psize_str, ai->static_size, ai->reserved_size, ai->dyn_size); rc =pcpu_setup_first_chunk (ai, vm.addr);
Signature · 1 line
2.20.1
Hi Matteo,
Quoted 43 lines · Matteo Croce
Since commit
ad67b74d2469d9b8("printk: hash addresses printed with %p"), at boot "____ptrval____" is printed instead of actual addresses:percpu: Embedded 38 pages/cpu @(____ptrval____) s124376 r0 d31272 u524288Instead of changing the print to "%px", and leaking kernel addresses, just remove the print completely, cfr. e.g. commit
071929dbdd865f77("arm64: Stop printing the virtual memory layout").Signed-off-by Matteo Croce <[email protected]>--- mm/percpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)mm/percpu.c +4
-4@@ -2567,8 +2567,8 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size, ai->groups[group].base_offset = areas[group] - base; } -pr_info ("Embedded %zu pages/cpu @%p s%zu r%zu d%zu u%zu\n" , -PFN_DOWN (size_sum), base, ai->static_size, ai->reserved_size, +pr_info ("Embedded %zu pages/cpu s%zu r%zu d%zu u%zu\n" , +PFN_DOWN (size_sum), ai->static_size, ai->reserved_size, ai->dyn_size, ai->unit_size); rc =pcpu_setup_first_chunk (ai, base);@@ -2692,8 +2692,8 @@ int __init pcpu_page_first_chunk(size_t reserved_size, }/* we're ready, commit */ -pr_info ("%d %s pages/cpu @%p s%zu r%zu d%zu\n" , - unit_pages, psize_str, vm.addr, ai->static_size, +pr_info ("%d %s pages/cpu s%zu r%zu d%zu\n" , + unit_pages, psize_str, ai->static_size, ai->reserved_size, ai->dyn_size); rc =pcpu_setup_first_chunk (ai, vm.addr);Signature · 1 line
2.20.1
I've applied this to for-5.1-fixes.
Thanks,
Dennis