Skip to contentSkip to conversation

ARM: kirkwood: disable dcache for Kirkwood boards

PATCH Superseded Chris Packham 2 participants 2 messages Mar 18, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: kirkwood: disable dcache for Kirkwood boards

Prior to commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache routines to common file") the kirkwood boards didn't have and dcache support. The network and usb drivers rely on this. Set CONFIG_SYS_DCACHE_OFF in the Kirkwood specific config.h.

---

 arch/arm/mach-kirkwood/include/mach/config.h | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-kirkwood/include/mach/config.h +1 -0
index fcd903887bff..3a4014e308b3 100644
@@ -26,6 +26,7 @@
 #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
 #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
 #define CONFIG_KIRKWOOD_PCIE_INIT       /* Enable PCIE Port0 for kernel */
+#define CONFIG_SYS_DCACHE_OFF		/* Disable data cache */
 
 /*
  * By default kwbimage.cfg from board specific folder is used
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 ARM: kirkwood: disable dcache for Kirkwood boards

Hi Chris,

Quoted 17 lines · Chris Packham

Prior to commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache routines to common file") the kirkwood boards didn't have and dcache support. The network and usb drivers rely on this. Set CONFIG_SYS_DCACHE_OFF in the Kirkwood specific config.h.

---

  arch/arm/mach-kirkwood/include/mach/config.h | 1 +
  1 file changed, 1 insertion(+)
arch/arm/mach-kirkwood/include/mach/config.h +0 -0
index fcd903887bff..3a4014e308b3 100644

arch/arm/mach-kirkwood/include/mach/config.h line 29

Quoted 4 lines
arch/arm/mach-kirkwood/include/mach/config.h +1 -0
@@ -26,6 +26,7 @@
  #define CONFIG_KIRKWOOD_EGIGA_INIT	/* Enable GbePort0/1 for kernel */
  #define CONFIG_KIRKWOOD_RGMII_PAD_1V8	/* Set RGMII Pad voltage to 1.8V */
  #define CONFIG_KIRKWOOD_PCIE_INIT       /* Enable PCIE Port0 for kernel */
+#define CONFIG_SYS_DCACHE_OFF		/* Disable data cache */

Thanks for taking care of this. I agree, that such a generic approach to disable the d-cache (for now) is better than a board specific one. But could you please add a short comment to the header to describe the background, similar to this commit message here? Perhaps also with a note that some drivers need updating / fixing before this "workaround" can be removed again?

Thanks,
Stefan