Skip to contentSkip to conversation

spi: pxa2xx-pci: Drop unused header inclusion

PATCH In review Andy Shevchenko 3 participants 3 messages Mar 18, 2019 – Mar 19, 2019

Subsystems (3)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 spi: pxa2xx-pci: Drop unused header inclusion

There is nothing in the driver which requires OF specific header to be included.

Remove it for good.

---
 drivers/spi/spi-pxa2xx-pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-pxa2xx-pci.c +0 -1
index 33029ca0687a..d456c5251b5d 100644
@@ -5,7 +5,6 @@
  */
 #include <linux/clk-provider.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
 #include <linux/pci.h>
 #include <linux/platform_device.h>
 #include <linux/spi/pxa2xx_spi.h>
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Andy Shevchenko

There is nothing in the driver which requires OF specific header to be included.

Remove it for good.

---
  drivers/spi/spi-pxa2xx-pci.c | 1 -
  1 file changed, 1 deletion(-)
drivers/spi/spi-pxa2xx-pci.c +0 -0
index 33029ca0687a..d456c5251b5d 100644

drivers/spi/spi-pxa2xx-pci.c line 10

Quoted 7 lines
drivers/spi/spi-pxa2xx-pci.c +0 -1
@@ -5,7 +5,6 @@
   */
  #include <linux/clk-provider.h>
  #include <linux/module.h>
-#include <linux/of_device.h>
  #include <linux/pci.h>
  #include <linux/platform_device.h>
  #include <linux/spi/pxa2xx_spi.h>

Yes, looks like not needed since 0202775bc3a2 ("spi/pxa2xx-pci: switch to use pcim_* interfaces").

maintainer
#2 lore raw

Applied "spi: pxa2xx-pci: Drop unused header inclusion" to the spi tree

In reply to Andy Shevchenko

The patch

spi: pxa2xx-pci: Drop unused header inclusion

has been applied to the spi tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 9384d0e6facc9f5b325a2d401e9ed6bb49507a2a Mon Sep 17 00:00:00 2001

From: Andy Shevchenko <[email protected]>
Date: Mon, 18 Mar 2019 16:42:37 +0200
Subject: [PATCH] spi: pxa2xx-pci: Drop unused header inclusion

There is nothing in the driver which requires OF specific header to be included.

Remove it for good.

---
 drivers/spi/spi-pxa2xx-pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-pxa2xx-pci.c +0 -1
index 1727fdfbac28..4b162fdca35f 100644
@@ -5,7 +5,6 @@
  */
 #include <linux/clk-provider.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
 #include <linux/pci.h>
 #include <linux/platform_device.h>
 #include <linux/spi/pxa2xx_spi.h>
Signature · 1 line
2.20.1