Skip to contentSkip to conversation

Eliminate camel case

PATCH In review vatsalanarang 2 participants 3 messages Mar 18, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Eliminate camel case

Issue reported by checkpatch.pl tool

---
 drivers/staging/sm750fb/ddk750_display.c | 5 ++---
 drivers/staging/sm750fb/ddk750_power.h   | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_display.c +2 -2
index 7f28e4cc4c79..6380e1536598 100644
@@ -147,8 +147,8 @@ void ddk750_set_logical_disp_out(enum disp_output output)
 
 	if (output & PNL_SEQ_USAGE) {
 		/* set  panel sequence */
-		sw_panel_power_sequence
-		((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4);
+		sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
+				4);
 	}
 
 	if (output & DAC_USAGE)
@@ -156,4 +156,3 @@ void ddk750_set_logical_disp_out(enum disp_output output)
 
 	if (output & DPMS_USAGE)
 		ddk750_set_dpms((output & DPMS_MASK) >> DPMS_OFFSET);

}

drivers/staging/sm750fb/ddk750_power.h +1 -1
index e48c74ecbbd1..7002567a47d2 100644
@@ -9,7 +9,7 @@ enum dpms {
 	crtDPMS_OFF = 0x3,
 };
 
-#define setDAC(off) {							\
+#define set_DAC(off) {							\
 	poke32(MISC_CTRL,						\
 	       (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 13 lines · vatsalanarang

Issue reported by checkpatch.pl tool

---
 drivers/staging/sm750fb/ddk750_display.c | 5 ++---
 drivers/staging/sm750fb/ddk750_power.h   | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)
drivers/staging/sm750fb/ddk750_display.c +0 -0
index 7f28e4cc4c79..6380e1536598 100644

drivers/staging/sm750fb/ddk750_display.c void ddk750_set_logical_disp_out(enum disp_output output) · line 151

Quoted 7 lines
drivers/staging/sm750fb/ddk750_display.c +2 -2
@@ -147,8 +147,8 @@ void ddk750_set_logical_disp_out(enum disp_output output)
 
 	if (output & PNL_SEQ_USAGE) {
 		/* set  panel sequence */
-		sw_panel_power_sequence
-		((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4);
+		sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET,
+				4);

This is not what your subject said it was doing :(

Also, it doesn't look correct, right?

And your From: line needs to match your signed-off-by line.

And finally, this is patch 2/2? Where is 1/2?

thanks,

greg k-h

#2 lore raw
In reply to vatsalanarang

Patch 1/2 is under the heading:Edit CamelCase function names to make code more readable; as the heading earlier was too long so I made it concise

Quoted 7 lines
drivers/staging/sm750fb/ddk750_display.c +1 -2
-                sw_panel_power_sequence 
-                ((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, 4); 
+                sw_panel_power_sequence((output & PNL_SEQ_MASK) >> 

PNL_SEQ_OFFSET,
+ 4);

I corrected its camelcase in earlier patch,if the patchset should have similar title, I will combine both and resend it.
thanks,
Vatsala