Skip to contentSkip to conversation

firmware: vpd: Drop __iomem usage for memremap() memory

PATCH New Stephen Boyd 1 participant 1 message Mar 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 firmware: vpd: Drop __iomem usage for memremap() memory

memremap() doesn't return an iomem pointer, so we can just use memcpy() and drop the __iomem annotation here. This silences a sparse warning.

Cc Guenter Roeck <[email protected]>
Cc Dmitry Torokhov <[email protected]>
Cc Anton Vasilyev <[email protected]>

---

Changes from v1:
* Added RB and fixed signoff

 drivers/firmware/google/vpd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/google/vpd.c +2 -2
index c0c0b4e4e281..f240946ed701 100644
@@ -254,7 +254,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
 
 static int vpd_sections_init(phys_addr_t physaddr)
 {
-	struct vpd_cbmem __iomem *temp;
+	struct vpd_cbmem *temp;
 	struct vpd_cbmem header;
 	int ret = 0;
 
@@ -262,7 +262,7 @@ static int vpd_sections_init(phys_addr_t physaddr)
 	if (!temp)
 		return -ENOMEM;
 
-	memcpy_fromio(&header, temp, sizeof(struct vpd_cbmem));
+	memcpy(&header, temp, sizeof(struct vpd_cbmem));
 	memunmap(temp);
 
 	if (header.magic != VPD_CBMEM_MAGIC)
Signature · 1 line
Sent by a computer through tubes