package/libpcap: fix bluez circular dependency
PATCH v2 1/1 package/libpcap: fix bluez circular dependency
The optional bluez_utils dependency of libpcap creates a circular dependency:
$ make dbus-show-recursive-depends
Recursion detected for : systemd
which is a dependency of: dbus
which is a dependency of: bluez_utils
which is a dependency of: libpcap
which is a dependency of: iptables
which is a dependency of: systemd
make: *** [package/dbus/dbus.mk:121: dbus-show-recursive-depends] Error 1
Drop support for bluez_utils. For bluez5_utils, which also depends on dbus, we only need the headers in the bluez5_utils-headers package. Use that to break the circular dependency.
Fixes:
http://autobuild.buildroot.net/results/9c3/9c3ee798fa6bb501a20a7892c0b085d2b279b664/
---
v2: keep bluez5_utils, and use bluez5_utils-headers (Yann)
--- package/libpcap/libpcap.mk | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/libpcap/libpcap.mk +2 -4
@@ -26,10 +26,8 @@ define LIBPCAP_CONFIG_REMOVE_RPATH endef LIBPCAP_POST_BUILD_HOOKS = LIBPCAP_CONFIG_REMOVE_RPATH -ifeq ($(BR2_PACKAGE_BLUEZ_UTILS),y) -LIBPCAP_DEPENDENCIES += bluez_utils -else ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y) -LIBPCAP_DEPENDENCIES += bluez5_utils +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y) +LIBPCAP_DEPENDENCIES += bluez5_utils-headers else LIBPCAP_CONF_OPTS += --disable-bluetooth endif
Signature · 1 line
2.20.1
Thomas Petazzoni
AppliedPATCH v2 1/1 package/libpcap: fix bluez circular dependency
Quoted 20 lines · On Sun, 17 Mar 2019 21:09:46 +0200 Baruch Siach <[email protected]> wrote:
The optional
bluez_utilsdependency of libpcap creates a circular dependency:$ make dbus-show-recursive-dependsRecursion detected for : systemd
which is a dependency of: dbus
which is a dependency of:bluez_utils
which is a dependency of: libpcap
which is a dependency of: iptables
which is a dependency of: systemd
make: *** [package/dbus/dbus.mk:121: dbus-show-recursive-depends] Error 1Drop support for
bluez_utils. Forbluez5_utils, which also depends on dbus, we only need the headers in the bluez5_utils-headers package. Use that to break the circular dependency.Fixes:
http://autobuild.buildroot.net/results/9c3/9c3ee798fa6bb501a20a7892c0b085d2b279b664/
Quoted 7 lines
Suggested-by Yann E. MORIN <[email protected]>Signed-off-by Baruch Siach <[email protected]>---
v2: keepbluez5_utils, and use bluez5_utils-headers (Yann)--- package/libpcap/libpcap.mk | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/libpcap: fix bluez circular dependency
In reply to Baruch SiachQuoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
The optional
bluez_utilsdependency of libpcap creates a circular dependency:$ make dbus-show-recursive-dependsRecursion detected for : systemd
which is a dependency of: dbus
which is a dependency of:bluez_utils
which is a dependency of: libpcap
which is a dependency of: iptables
which is a dependency of: systemd
make: *** [package/dbus/dbus.mk:121: dbus-show-recursive-depends] Error 1Drop support for
bluez_utils. Forbluez5_utils, which also depends on dbus, we only need the headers in the bluez5_utils-headers package. Use that to break the circular dependency.
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/9c3/9c3ee798fa6bb501a20a7892c0b085d2b279b664/Suggested-by Yann E. MORIN <[email protected]>Signed-off-by Baruch Siach <[email protected]>---
v2: keepbluez5_utils, and use bluez5_utils-headers (Yann)
Committed to 2019.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard