package/gst1-plugins-bad: add webrtc option
PATCH v2 1/1 package/gst1-plugins-bad: add webrtc option
- remove old webrtc Config.in.legacy entry introduced by [1] (misnamed webrtc option was introduced with 2017.02, renamed to webrtcdsp for 2017.08 and although backported to 2017.02.4)
[1] https://git.buildroot.net/buildroot/commit/?id=4c06d2490a07f0b88f42c56c7409899fd2f5608a
---
Changes v1 -> v2:
- renamed option form webrtcbin to webrtc
- remove legacy webrtc Config.in.legacy entry
--- Config.in.legacy | 10 ---------- package/gstreamer1/gst1-plugins-bad/Config.in | 11 +++++++++++ .../gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 7 +++++++ 3 files changed, 18 insertions(+), 10 deletions(-)
Config.in.legacy +0 -10
@@ -1685,16 +1685,6 @@ config BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_MAD bool "mad (*.mp3 audio) removed" select BR2_LEGACY -config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC - bool "gst1-plugins-bad webrtc renamed to webrtcdsp" - select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTCDSP - select BR2_LEGACY - help - The WebRTC plugin in GStreamer 1.x has always been named - webrtcdsp, but was wrongly introduced in Buildroot under the - name webrtc. Therefore, we have renamed the option to match - the actual name of the GStreamer plugin. - config BR2_STRIP_none bool "Strip command 'none' has been removed" select BR2_LEGACY
package/gstreamer1/gst1-plugins-bad/Config.in +11 -0
@@ -558,6 +558,17 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBP help Webp image format plugin +config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC + bool "webrtc" + depends on !BR2_STATIC_LIBS # libnice -> gnutls + select BR2_PACKAGE_GST1_PLUGINS_BASE # libgstsdp + select BR2_PACKAGE_LIBNICE + help + WebRTC plugins (webrtcbin - a bin for webrtc connections) + +comment "webrtc needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS + config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTCDSP bool "webrtcdsp" # All depends from webrtc-audio-processing
package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk +7 -0
@@ -703,6 +703,13 @@ else GST1_PLUGINS_BAD_CONF_OPTS += --disable-webp endif +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC),y) +GST1_PLUGINS_BAD_CONF_OPTS += --enable-webrtc +GST1_PLUGINS_BAD_DEPENDENCIES += gst1-plugins-base libnice +else +GST1_PLUGINS_BAD_CONF_OPTS += --disable-webrtc +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTCDSP),y) GST1_PLUGINS_BAD_CONF_OPTS += --enable-webrtcdsp GST1_PLUGINS_BAD_DEPENDENCIES += webrtc-audio-processing
Signature · 1 line
2.21.0
Thomas Petazzoni
AppliedPATCH v2 1/1 package/gst1-plugins-bad: add webrtc option
Quoted 11 lines · On Sat, 16 Mar 2019 23:14:40 +0100 Peter Seiderer <[email protected]> wrote:
- remove old webrtc Config.in.legacy entry introduced by [1] (misnamed webrtc option was introduced with 2017.02, renamed to webrtcdsp for 2017.08 and although backported to 2017.02.4)
[1] https://git.buildroot.net/buildroot/commit/?id=4c06d2490a07f0b88f42c56c7409899fd2f5608a
Signed-off-by Peter Seiderer <[email protected]>---
Changes v1 -> v2:
- renamed option form webrtcbin to webrtc
- remove legacy webrtc Config.in.legacy entry
Quoted 5 lines
--- Config.in.legacy | 10 ---------- package/gstreamer1/gst1-plugins-bad/Config.in | 11 +++++++++++ .../gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 7 +++++++ 3 files changed, 18 insertions(+), 10 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com