spi: pxa2xx: Adjust DMA burst size per platform
Subsystems (3)
Andy Shevchenko
reviewerv3 cover spi: pxa2xx: Adjust DMA burst size per platform
On some platforms DMA burst size is not the same as hard coded default Fix the driver to support them.
In v4:
- fix s/master/controller/g
In v3:
- drop threshold print since it's easy to calculate constant (Jarkko)
- split one more unrelated change to a separate patch,
but independent from this series (Jarkko)
In v2:
- drop unrelated changes (Jarkko, Robert)
- don't include Robert's tag due to changes in the patch
Andy Shevchenko (2):
spi: pxa2xx: Debug print DMA burst size
spi: pxa2xx-pci: Drop unused header inclusion
drivers/spi/spi-pxa2xx-pci.c | 1 - drivers/spi/spi-pxa2xx.c | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1
Andy Shevchenko
reviewerPATCH v4 1/2 spi: pxa2xx: Debug print DMA burst size
It's useful during debug to see what DMA burst size is.
--- drivers/spi/spi-pxa2xx.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/spi/spi-pxa2xx.c +3 -0
@@ -1333,6 +1333,9 @@ static int setup(struct spi_device *spi)dev_warn (&spi->dev,"in setup: DMA burst size reduced to match bits_per_word\n" ); } +dev_dbg (&spi->dev, +"in setup: DMA burst size set to %u\n" , + chip->dma_burst_size); }switch (drv_data->ssp_type) {
Signature · 1 line
2.20.1
Andy Shevchenko
reviewerPATCH v4 2/2 spi: pxa2xx-pci: Drop unused header inclusion
In reply to Andy ShevchenkoThere is nothing in the driver which requires OF specific header to be included.
Remove it for good.
--- drivers/spi/spi-pxa2xx-pci.c | 1 - 1 file changed, 1 deletion(-)
drivers/spi/spi-pxa2xx-pci.c +0 -1
@@ -5,7 +5,6 @@*/ #include <linux/clk-provider.h> #include <linux/module.h> -#include <linux/of_device.h> #include <linux/pci.h> #include <linux/platform_device.h> #include <linux/spi/pxa2xx_spi.h>
Signature · 1 line
2.20.1
Andy Shevchenko
reviewerQuoted 2 lines · Andy Shevchenko
On some platforms DMA burst size is not the same as hard coded default Fix the driver to support them.
Oops, nor subject nor patches are correct in this series. I have sent v5 corrected.
Sorry for the noise.
Quoted 24 lines
In v4:
- fix s/master/controller/gIn v3:
- drop threshold print since it's easy to calculate constant (Jarkko)
- split one more unrelated change to a separate patch,
but independent from this series (Jarkko)In v2:
- drop unrelated changes (Jarkko, Robert)
- don't include Robert's tag due to changes in the patchAndy Shevchenko (2):
spi: pxa2xx: Debug print DMA burst size
spi: pxa2xx-pci: Drop unused header inclusiondrivers/spi/spi-pxa2xx-pci.c | 1 - drivers/spi/spi-pxa2xx.c | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-)Signature · 1 line
2.20.1
Signature · 2 lines
With Best Regards, Andy Shevchenko