Skip to contentSkip to conversation

package/libpcap: fix bluez5_utils-headers dependency

PATCH New Fabrice Fontaine 4 participants 4 messages Mar 18, 2019 – Mar 27, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libpcap: fix bluez5_utils-headers dependency

Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils dependency by bluez5_utils-headers without replacing the test on BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS

Fix this mistake and also add a select on BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set so the user does not have to do it

Fixes:
- http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8

---
 package/libpcap/Config.in  | 1 +
 package/libpcap/libpcap.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/libpcap/Config.in +1 -0
index 643acbef6e..74429f209a 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBPCAP
 	bool "libpcap"
+	select BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS
 	select BR2_PACKAGE_ZLIB
 	help
 	  A system-independent library for user-level network packet
package/libpcap/libpcap.mk +1 -1
index 2f46426d37..ebceca5273 100644
@@ -26,7 +26,7 @@ define LIBPCAP_CONFIG_REMOVE_RPATH
 endef
 LIBPCAP_POST_BUILD_HOOKS = LIBPCAP_CONFIG_REMOVE_RPATH
 
-ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y)
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_HEADERS),y)
 LIBPCAP_DEPENDENCIES += bluez5_utils-headers
 else
 LIBPCAP_CONF_OPTS += --disable-bluetooth
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 package/libpcap: fix bluez5_utils-headers dependency

Hi Fabrice,

Quoted 4 lines · Fabrice Fontaine

Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils dependency by bluez5_utils-headers without replacing the test on BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS

Quoted 8 lines

Fix this mistake and also add a select on BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set so the user does not have to do it

Fixes:
- http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8

Thanks,
baruch

Quoted 30 lines
---
 package/libpcap/Config.in  | 1 +
 package/libpcap/libpcap.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/libpcap/Config.in +1 -0
index 643acbef6e..74429f209a 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBPCAP
 	bool "libpcap"
+	select BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS
 	select BR2_PACKAGE_ZLIB
 	help
 	  A system-independent library for user-level network packet
package/libpcap/libpcap.mk +1 -1
index 2f46426d37..ebceca5273 100644
@@ -26,7 +26,7 @@ define LIBPCAP_CONFIG_REMOVE_RPATH
 endef
 LIBPCAP_POST_BUILD_HOOKS = LIBPCAP_CONFIG_REMOVE_RPATH
 
-ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS),y)
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_HEADERS),y)
 LIBPCAP_DEPENDENCIES += bluez5_utils-headers
 else
 LIBPCAP_CONF_OPTS += --disable-bluetooth
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/libpcap: fix bluez5_utils-headers dependency

In reply to Fabrice Fontaine
Quoted 8 lines · On Mon, 18 Mar 2019 23:40:42 +0100 Fabrice Fontaine…

Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils dependency by bluez5_utils-headers without replacing the test on BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS

Fix this mistake and also add a select on BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set so the user does not have to do it

Quoted 8 lines

Fixes:
- http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8

---
 package/libpcap/Config.in  | 1 +
 package/libpcap/libpcap.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/libpcap: fix bluez5_utils-headers dependency

In reply to Fabrice Fontaine
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Commit c46afc37dc877f1e94ffde0d77585290711b27ec changed bluez5-utils dependency by bluez5_utils-headers without replacing the test on BR2_PACKAGE_BLUEZ5_UTILS by BR2_PACKAGE_BLUEZ5_UTILS_HEADERS

Quoted 8 lines

Fix this mistake and also add a select on BR2_PACKAGE_BLUEZ5_UTILS_HEADERS if BR2_PACKAGE_BLUEZ5_UTILS is set so the user does not have to do it

Fixes:
- http://autobuild.buildroot.org/results/c6828df1f3782564451ddd4187ff026679bf37d8

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard