HID: logitech: Handle 0 scroll events for the m560
Subsystems (3)
PATCH 1/1 HID: logitech: Handle 0 scroll events for the m560
hidpp_scroll_counter_handle_scroll() doesn't expect a 0-value scroll event, it gets interpreted as a negative scroll direction event. This can cause scroll direction resets and thus broken scrolling.
Reported-and-tested-by Aimo Metsälä <[email protected]>
Signed-off-by Peter Hutterer <[email protected]>
--- drivers/hid/hid-logitech-hidpp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/hid/hid-logitech-hidpp.c +3 -2
@@ -2608,8 +2608,9 @@ static int m560_raw_event(struct hid_device *hdev, u8 *data, int size)input_report_rel (mydata->input,REL_Y , v); v =hid_snto32 (data[6 ],8 ); -hidpp_scroll_counter_handle_scroll ( - &hidpp->vertical_wheel_counter, v); +if (v !=0 ) +hidpp_scroll_counter_handle_scroll ( + &hidpp->vertical_wheel_counter, v);input_sync (mydata->input); }
Signature · 1 line
2.20.1
Quoted 8 lines · Peter Hutterer
hidpp_scroll_counter_handle_scroll()doesn't expect a 0-value scroll event, it gets interpreted as a negative scroll direction event. This can cause scroll direction resets and thus broken scrolling.Reported-and-tested-by Aimo Metsälä <[email protected]>Signed-off-by Peter Hutterer <[email protected]>---
Added the 'Fixes' and "cc: stable" tags and patch applied to for-5.1/upstream-fixes
Cheers,
Benjamin
Quoted 22 lines
drivers/hid/hid-logitech-hidpp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/hid/hid-logitech-hidpp.c +3
-3@@ -2608,8 +2608,9 @@ static int m560_raw_event(struct hid_device *hdev, u8 *data, int size)input_report_rel (mydata->input,REL_Y , v); v =hid_snto32 (data[6 ],8 ); -hidpp_scroll_counter_handle_scroll ( - &hidpp->vertical_wheel_counter, v); +if (v !=0 ) +hidpp_scroll_counter_handle_scroll ( + &hidpp->vertical_wheel_counter, v);input_sync (mydata->input); } --2.20.1