Staging: mt7621-dma: Add blank line after declarations
Subsystems (2)
PATCH 1/1 Staging: mt7621-dma: Add blank line after declarations
Add a blank line after declaration to mute checkpatch.pl warning:
WARNING: Missing a blank line after declarations
--- drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {struct device_dma_parameters dma_parms;void __iomem *base;struct tasklet_struct task; +volatile unsigned long chan_issued;struct mtk_hsdma_chan chan[1 ];
Signature · 1 line
2.11.0
Greg Kroah-Hartman
maintainerQuoted 13 lines · Wentao Cai
Add a blank line after declaration to mute checkpatch.pl warning:
WARNING: Missing a blank line after declarationsSigned-off-by Wentao Cai <[email protected]>--- drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/mt7621-dma/mtk-hsdma.c +0
-0
drivers/staging/mt7621-dma/mtk-hsdma.c struct mtk_hsdam_engine { · line 161
Quoted 5 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +1
-0@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {struct device_dma_parameters dma_parms;void __iomem *base;struct tasklet_struct task; +volatile unsigned long chan_issued;
Please look at what you did here and compare it to what the checkpatch warning said it was doing. Hint, checkpatch is wrong here...
Always use your brain when dealing with checkpatch as it is just a dumb perl script :)
thanks,
greg k-h
Quoted 25 lines · gregkh
Review
Quoted 9 lines · Wentao Cai
Add a blank line after declaration to mute checkpatch.pl warning:
WARNING: Missing a blank line after declarationsSigned-off-by Wentao Cai <[email protected] <javascript:>>---
drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/staging/mt7621-dma/mtk-hsdma.cdrivers/staging/mt7621-dma/mtk-hsdma.c struct mtk_hsdam_engine { · line 161
Quoted 9 lines
index
97571f1d697b..beeff4258b19100644drivers/staging/mt7621-dma/mtk-hsdma.c +1
-0@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {struct device_dma_parameters dma_parms;void __iomem *base;struct tasklet_struct task; +volatile unsigned long chan_issued;Please look at what you did here and compare it to what the checkpatch warning said it was doing. Hint, checkpatch is wrong here...
Quoted 4 lines
Always use your brain when dealing with checkpatch as it is just a dumb perl script :)
Sorry, I'll be more careful next time.
Wentao
Quoted 4 lines
thanks,
greg k-h