vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static
Subsystems (3)
PATCH 1/1 vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static
Fixes the following sparse warning:
drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
symbol 'tce_iommu_driver_ops' was not declared. Should it be static?
Fixes 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")
Signed-off-by Wang Hai <[email protected]>
--- drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vfio/vfio_iommu_spapr_tce.c +1 -1
@@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,mutex_unlock (&container->lock); } -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { .name ="iommu-vfio-powerpc" , .owner =THIS_MODULE , .open = tce_iommu_open,
Signature · 1 line
1.8.3.1
Quoted 7 lines · Wang Hai
Fixes the following sparse warning:
drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
symbol 'tce_iommu_driver_ops' was not declared. Should it be static?Fixes 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")Signed-off-by Wang Hai <[email protected]>
I am curious - what exactly did you do to get this warning?
Anyway,
Reviewed-by Alexey Kardashevskiy <[email protected]>
Quoted 18 lines
--- drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vfio/vfio_iommu_spapr_tce.c +1
-1@@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,mutex_unlock (&container->lock); } -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { .name ="iommu-vfio-powerpc" , .owner =THIS_MODULE , .open = tce_iommu_open,
Signature · 1 line
Alexey
Alex Williamson
AppliedQuoted 8 lines · On Wed, 20 Mar 2019 02:47:23 -0400 Wang Hai <[email protected]> wrote:
Fixes the following sparse warning:
drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
symbol 'tce_iommu_driver_ops' was not declared. Should it be static?Fixes 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")Signed-off-by Wang Hai <[email protected]>---
Applied to vfio for-linus branch for v5.1 with Alexey's R-b. Thanks!
Alex
Quoted 16 lines
drivers/vfio/vfio_iommu_spapr_tce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vfio/vfio_iommu_spapr_tce.c +1
-1@@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,mutex_unlock (&container->lock); } -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = { .name ="iommu-vfio-powerpc" , .owner =THIS_MODULE , .open = tce_iommu_open,