Skip to contentSkip to conversation

bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

PATCH In review Peter Oskolkov 2 participants 2 messages Mar 20, 2019 – Mar 21, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

This helper is useful if a bpf tc filter sets skb->tstamp.

---
 net/core/filter.c | 2 ++
 1 file changed, 2 insertions(+)
net/core/filter.c +2 -0
index 647c63a7b25b..c6d016d9c4b8 100644
@@ -5719,6 +5719,8 @@ tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
 		return &bpf_tcp_sock_proto;
 	case BPF_FUNC_get_listener_sock:
 		return &bpf_get_listener_sock_proto;
+	case BPF_FUNC_skb_ecn_set_ce:
+		return &bpf_skb_ecn_set_ce_proto;
 #endif
 	default:
 		return bpf_base_func_proto(func_id);
Signature · 1 line
2.21.0.225.g810b269d1ac-goog
#1 lore raw
Quoted 12 lines · Peter Oskolkov

This helper is useful if a bpf tc filter sets skb->tstamp.

---
 net/core/filter.c | 2 ++
 1 file changed, 2 insertions(+)
net/core/filter.c +0 -0
index 647c63a7b25b..c6d016d9c4b8 100644

net/core/filter.c tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) · line 5723

Quoted 5 lines
net/core/filter.c +2 -0
@@ -5719,6 +5719,8 @@ tc_cls_act_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
 		return &bpf_tcp_sock_proto;
 	case BPF_FUNC_get_listener_sock:
 		return &bpf_get_listener_sock_proto;
+	case BPF_FUNC_skb_ecn_set_ce:
+		return &bpf_skb_ecn_set_ce_proto;

makes sense, but I would like to see a selftest that it was tested properly.