regulator: rn5t618: Constify regulator_desc
PATCH 1/1 regulator: rn5t618: Constify regulator_desc
The regulator_desc never need to be modified, so define them as const as a hint to the compiler that they can go into .rodata.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/rn5t618-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/regulator/rn5t618-regulator.c +4 -4
@@ -46,7 +46,7 @@ static const struct regulator_ops rn5t618_reg_ops = { .vsel_mask = (vmask), \ } -static struct regulator_desc rn5t567_regulators[] = { +static const struct regulator_desc rn5t567_regulators[] = {/* DCDC */ REG (DCDC1 ,DC1CTL ,BIT (0 ),DC1DAC ,0xff ,600000 ,3500000 ,12500 ),REG (DCDC2 ,DC2CTL ,BIT (0 ),DC2DAC ,0xff ,600000 ,3500000 ,12500 ),
@@ -63,7 +63,7 @@ static struct regulator_desc rn5t567_regulators[] = { REG(LDORTC2, LDOEN2, BIT(5), LDORTC2DAC, 0x7f, 900000, 3500000, 25000), }; -static struct regulator_desc rn5t618_regulators[] = { +static const struct regulator_desc rn5t618_regulators[] = {/* DCDC */ REG (DCDC1 ,DC1CTL ,BIT (0 ),DC1DAC ,0xff ,600000 ,3500000 ,12500 ),REG (DCDC2 ,DC2CTL ,BIT (0 ),DC2DAC ,0xff ,600000 ,3500000 ,12500 ),
@@ -79,7 +79,7 @@ static struct regulator_desc rn5t618_regulators[] = { REG(LDORTC2, LDOEN2, BIT(5), LDORTC2DAC, 0x7f, 900000, 3500000, 25000), }; -static struct regulator_desc rc5t619_regulators[] = { +static const struct regulator_desc rc5t619_regulators[] = {/* DCDC */ REG (DCDC1 ,DC1CTL ,BIT (0 ),DC1DAC ,0xff ,600000 ,3500000 ,12500 ),REG (DCDC2 ,DC2CTL ,BIT (0 ),DC2DAC ,0xff ,600000 ,3500000 ,12500 ),
@@ -107,7 +107,7 @@ static int rn5t618_regulator_probe(struct platform_device *pdev)struct rn5t618 *rn5t618 =dev_get_drvdata (pdev->dev.parent);struct regulator_config config = { };struct regulator_dev *rdev; -struct regulator_desc *regulators; +const struct regulator_desc *regulators;int i;int num_regulators =0 ;
Signature · 1 line
2.17.1
Quoted 4 lines · Axel Lin
The
regulator_descnever need to be modified, so define them as const as a hint to the compiler that they can go into .rodata.Signed-off-by Axel Lin <[email protected]>
Looks good to me.
Reviewed-by Stefan Agner <[email protected]>
--
Stefan
Quoted 45 lines
--- drivers/regulator/rn5t618-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/regulator/rn5t618-regulator.c +4
-4@@ -46,7 +46,7 @@ static const struct regulator_ops rn5t618_reg_ops = { .vsel_mask = (vmask), \ } -static struct regulator_desc rn5t567_regulators[] = { +static const struct regulator_desc rn5t567_regulators[] = {/* DCDC */ REG (DCDC1 ,DC1CTL ,BIT (0 ),DC1DAC ,0xff ,600000 ,3500000 ,12500 ),REG (DCDC2 ,DC2CTL ,BIT (0 ),DC2DAC ,0xff ,600000 ,3500000 ,12500 ),@@ -63,7 +63,7 @@ static struct regulator_desc rn5t567_regulators[] = { REG(LDORTC2, LDOEN2, BIT(5), LDORTC2DAC, 0x7f, 900000, 3500000, 25000), }; -static struct regulator_desc rn5t618_regulators[] = { +static const struct regulator_desc rn5t618_regulators[] = {/* DCDC */ REG (DCDC1 ,DC1CTL ,BIT (0 ),DC1DAC ,0xff ,600000 ,3500000 ,12500 ),REG (DCDC2 ,DC2CTL ,BIT (0 ),DC2DAC ,0xff ,600000 ,3500000 ,12500 ),@@ -79,7 +79,7 @@ static struct regulator_desc rn5t618_regulators[] = { REG(LDORTC2, LDOEN2, BIT(5), LDORTC2DAC, 0x7f, 900000, 3500000, 25000), }; -static struct regulator_desc rc5t619_regulators[] = { +static const struct regulator_desc rc5t619_regulators[] = {/* DCDC */ REG (DCDC1 ,DC1CTL ,BIT (0 ),DC1DAC ,0xff ,600000 ,3500000 ,12500 ),REG (DCDC2 ,DC2CTL ,BIT (0 ),DC2DAC ,0xff ,600000 ,3500000 ,12500 ),@@ -107,7 +107,7 @@ static int rn5t618_regulator_probe(struct platform_device *pdev)struct rn5t618 *rn5t618 =dev_get_drvdata (pdev->dev.parent);struct regulator_config config = { };struct regulator_dev *rdev; -struct regulator_desc *regulators; +const struct regulator_desc *regulators;int i;int num_regulators =0 ;