net: phy: Add DP83825I to the DP83822 driver
Subsystems (3)
PATCH v2 1/1 net: phy: Add DP83825I to the DP83822 driver
Add the DP83825I ethernet PHY to the DP83822 driver. These devices share the same WoL register bits and addresses.
The phy_driver init was made into a macro as there may be future devices appended to this driver that will share the register space.
http://www.ti.com/lit/gpn/dp83825i
---
v2 - Updated id and mask to new ID_MATCH macro, removed extra line - https://lore.kernel.org/patchwork/patch/1052329/
drivers/net/phy/dp83822.c | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-)
drivers/net/phy/dp83822.c +20 -14
@@ -15,6 +15,8 @@#include <linux/netdevice.h> #define DP83822_PHY_ID 0x2000a240 +#define DP83825I_PHY_ID 0x2000a150 +#define DP83822_DEVADDR 0x1f#define MII_DP83822_PHYSCR 0x11
@@ -304,26 +306,30 @@ static int dp83822_resume(struct phy_device *phydev)return 0 ; } +#define DP83822_PHY_DRIVER (_id, _name) \ + { \ + PHY_ID_MATCH_MODEL(_id), \ + .name = (_name), \ + .features = PHY_BASIC_FEATURES, \ + .soft_reset = dp83822_phy_reset, \ + .config_init = dp83822_config_init, \ + .get_wol = dp83822_get_wol, \ + .set_wol = dp83822_set_wol, \ + .ack_interrupt = dp83822_ack_interrupt, \ + .config_intr = dp83822_config_intr, \ + .suspend = dp83822_suspend, \ + .resume = dp83822_resume, \ + } +static struct phy_driver dp83822_driver[] = { - { - .phy_id =DP83822_PHY_ID , - .phy_id_mask =0xfffffff0 , - .name ="TI DP83822" , - .features =PHY_BASIC_FEATURES , - .config_init = dp83822_config_init, - .soft_reset = dp83822_phy_reset, - .get_wol = dp83822_get_wol, - .set_wol = dp83822_set_wol, - .ack_interrupt = dp83822_ack_interrupt, - .config_intr = dp83822_config_intr, - .suspend = dp83822_suspend, - .resume = dp83822_resume, - }, +DP83822_PHY_DRIVER (DP83822_PHY_ID ,"TI DP83822" ), +DP83822_PHY_DRIVER (DP83825I_PHY_ID ,"TI DP83825I" ), };module_phy_driver (dp83822_driver);static struct mdio_device_id __maybe_unused dp83822_tbl[] = { {DP83822_PHY_ID ,0xfffffff0 }, + {DP83825I_PHY_ID ,0xfffffff0 }, { }, };MODULE_DEVICE_TABLE (mdio, dp83822_tbl);
Signature · 1 line
2.20.1.390.gb5101f9297
From: Dan Murphy <[email protected]>
Date: Wed, 20 Mar 2019 07:36:55 -0500
Quoted 6 lines
Add the DP83825I ethernet PHY to the DP83822 driver. These devices share the same WoL register bits and addresses.
The
phy_driverinit was made into a macro as there may be future devices appended to this driver that will share the register space.
Quoted 7 lines
http://www.ti.com/lit/gpn/dp83825i
Reviewed-by Florian Fainelli <[email protected]>Signed-off-by Dan Murphy <[email protected]>---
v2 - Updated id and mask to new
ID_MATCHmacro, removed extra line - https://lore.kernel.org/patchwork/patch/1052329/
Applied, thanks.