Skip to contentSkip to conversation

staging: netlogic: replace skb_put/pull pair with skb_reserve

PATCH New Ivan Safonov 1 participant 1 message Mar 20, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: netlogic: replace skb_put/pull pair with skb_reserve

The sequence

    skb_put(skb);
    skb_pull(skb);

leads to the same result as

    skb_reserve(skb);

but second is a little shorter and clearer.

---
 drivers/staging/netlogic/xlr_net.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/netlogic/xlr_net.c +1 -2
index 10f14a5cf490..1897b711d66d 100644
@@ -87,8 +87,7 @@ static inline unsigned char *xlr_alloc_skb(void)
 	if (!skb)
 		return NULL;
 	skb_data = skb->data;
-	skb_put(skb, MAC_SKB_BACK_PTR_SIZE);
-	skb_pull(skb, MAC_SKB_BACK_PTR_SIZE);
+	skb_reserve(skb, MAC_SKB_BACK_PTR_SIZE);
 	memcpy(skb_data, &skb, buf_len);
 
 	return skb->data;
Signature · 1 line
2.19.2