Skip to contentSkip to conversation

fixup! qemu: backport patches to fix cves

PATCH In review [email protected] 2 participants 4 messages Mar 20, 2019 – Mar 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fixup! qemu: backport patches to fix cves

From: Kai Kang <[email protected]>

---
 meta/recipes-devtools/qemu/qemu/0015-fix-CVE-2018-20124.patch | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/qemu/qemu/0015-fix-CVE-2018-20124.patch +2 -2
index ad846958a7..985b819409 100644
@@ -38,7 +38,7 @@ index d7a4bbd9..7f8028f8 100644
 -        comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
 +    if (!num_sge || num_sge > MAX_SGE) {
 +        pr_dbg("invalid num_sge=%d\n", num_sge);
-+        comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx);
++        comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
          return;
      }
  
@@ -51,7 +51,7 @@ index d7a4bbd9..7f8028f8 100644
 -        comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
 +    if (!num_sge || num_sge > MAX_SGE) {
 +        pr_dbg("invalid num_sge=%d\n", num_sge);
-+        comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx);
++        comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
          return;
      }
  
Signature · 1 line
2.20.0
#1 lore raw

Hi Kai Kang,

Quoted 6 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, March 20, 2019 4:16 PM
To: [email protected]
Cc: [email protected]; [email protected]
Subject: [PATCH] fixup! qemu: backport patches to fix cves

Just wondering if you were able to reproduce mentioned problem on your side before fixing it?

Given Richard's input this problem was supposed to be caught before your previous commit hit OE master branch but somehow it slipped through the cracks...

Or otherwise my setup should be somehow very special if it only happens for me.

-Alexey

author
#2 lore raw
Quoted 11 lines · Alexey Brodkin

Hi Kai Kang,

Quoted 6 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, March 20, 2019 4:16 PM
To: [email protected]
Cc: [email protected]; [email protected]
Subject: [PATCH] fixup! qemu: backport patches to fix cves

Just wondering if you were able to reproduce mentioned problem on your side before fixing it?

Quoted 6 lines

Given Richard's input this problem was supposed to be caught before your previous commit hit OE master branch but somehow it slipped through the cracks...

Or otherwise my setup should be somehow very special if it only happens for me.

I can reproduce the build failure with default configure:

$ . poky/oe-init-build-env
$ bitbake qemu-system-native

It should be covered by autobuilder. :(

And there is no error to build qemu and qemu-native  that hw/rdma/rdma_backend.c is not even compiled because:

* CONFIG_PCI is not set for qemu-native

* CONFIG_PVRDMA is not set for qemu

Regards,
Kai

Quoted 4 lines

-Alexey

Signature · 1 line
Kai Kang
#3 lore raw

Hi Kai,

Quoted 31 lines

-----Original Message-----
From: Kang Kai <[email protected]>
Sent: Thursday, March 21, 2019 6:27 AM
To: Alexey Brodkin <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] fixup! qemu: backport patches to fix cves

Quoted 11 lines · Alexey Brodkin

Hi Kai Kang,

Quoted 6 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, March 20, 2019 4:16 PM
To: [email protected]
Cc: [email protected]; [email protected]
Subject: [PATCH] fixup! qemu: backport patches to fix cves

Just wondering if you were able to reproduce mentioned problem on your side before fixing it?

Quoted 6 lines

Given Richard's input this problem was supposed to be caught before your previous commit hit OE master branch but somehow it slipped through the cracks...

Or otherwise my setup should be somehow very special if it only happens for me.

I can reproduce the build failure with default configure:

$ . poky/oe-init-build-env
$ bitbake qemu-system-native
Quoted 7 lines

It should be covered by autobuilder. :(

And there is no error to build qemu and qemu-native  that hw/rdma/rdma_backend.c is not even compiled because:

* CONFIG_PCI is not set for qemu-native
* CONFIG_PVRDMA is not set for qemu

Thanks for confirmation!

Richard, FWIW I hit this issue building "build-appliance-image" which I use for smoke-testing as there're quite a few packages being built.

-Alexey