Skip to contentSkip to conversation

Gummiboot fixup

PATCH New Esben Haabendal 2 participants 5 messages Mar 20, 2019

lore
Share & tools
lore
#0 lore raw

v2 cover Gummiboot fixup

From: Esben Haabendal <[email protected]>

These patches fixes gummiboot for building with toolchains using newer gcc and glibc versions.

Changes since v1:
- Formatted patch with git format-patch and added SoB

Esben Haabendal (3):
gummiboot: use new official upstream git repository
gummiboot: upgrade to last commit before being removed
gummiboot: fix compatibility with newer glibc versions

 ...w-building-with-newer-glibc-versions.patch | 31 +++++++++++++++++++
 boot/gummiboot/gummiboot.mk                   |  4 +--
 2 files changed, 33 insertions(+), 2 deletions(-)
 create mode 100644 boot/gummiboot/0001-Allow-building-with-newer-glibc-versions.patch
Signature · 1 line
2.21.0
#1 lore raw

PATCH v2 1/3 gummiboot: use new official upstream git repository

From: Esben Haabendal <[email protected]>

---
 boot/gummiboot/gummiboot.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/gummiboot/gummiboot.mk +1 -1
index 85a5daaeab69..0e67e5e8ce0e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GUMMIBOOT_SITE = http://cgit.freedesktop.org/gummiboot
+GUMMIBOOT_SITE = https://gitlab.freedesktop.org/archived-projects/gummiboot.git
 GUMMIBOOT_SITE_METHOD = git
 GUMMIBOOT_VERSION = 43
 GUMMIBOOT_LICENSE = LGPL-2.1+
Signature · 1 line
2.21.0
#2 lore raw

PATCH v2 2/3 gummiboot: upgrade to last commit before being removed

In reply to Esben Haabendal

From: Esben Haabendal <[email protected]>

This upgrades to version 48 plus the last commits done after that. Note, that after that, gummiboot is officially dead, so there will be no more upstream commits after this.

For various reasons, there are still users of gummiboot, so let's base our work on the latest gummiboot "version".

---
 boot/gummiboot/gummiboot.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/gummiboot/gummiboot.mk +1 -1
index 0e67e5e8ce0e..748e87030e7b 100644
@@ -6,7 +6,7 @@
 
 GUMMIBOOT_SITE = https://gitlab.freedesktop.org/archived-projects/gummiboot.git
 GUMMIBOOT_SITE_METHOD = git
-GUMMIBOOT_VERSION = 43
+GUMMIBOOT_VERSION = 2bcd919c681c952eb867ef1bdb458f1bc49c2d55
 GUMMIBOOT_LICENSE = LGPL-2.1+
 GUMMIBOOT_LICENSE_FILES = LICENSE
 
Signature · 1 line
2.21.0
#3 lore raw

PATCH v2 3/3 gummiboot: fix compatibility with newer glibc versions

In reply to Esben Haabendal

From: Esben Haabendal <[email protected]>

---
 ...w-building-with-newer-glibc-versions.patch | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 boot/gummiboot/0001-Allow-building-with-newer-glibc-versions.patch
boot/gummiboot/0001-Allow-building-with-newer-glibc-versions.patch new file +31 -0
new file mode 100644
index 000000000000..b35cd499bce0
@@ -0,0 +1,31 @@
+From 40ab4167b5a45c772304a879c71b47d54de3b0e3 Mon Sep 17 00:00:00 2001
+From: Esben Haabendal <[email protected]>
+Date: Wed, 20 Mar 2019 14:19:40 +0100
+Subject: [PATCH] Allow building with newer glibc versions
+
+Newer glibc versions does not include sys/sysmacros.h from sys/types.h
+anymore.  Including it unconditionally should be safe.
+
+See https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html for why
+this was done.
+
+Signed-off-by: Esben Haabendal <[email protected]>
+---
+ src/setup/setup.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/setup/setup.c b/src/setup/setup.c
+index 6a4275a2ae36..53429375a146 100644
+--- a/src/setup/setup.c
++++ b/src/setup/setup.c
+@@ -37,6 +37,7 @@
+ #include <ftw.h>
+ #include <stdbool.h>
+ #include <blkid.h>
++#include <sys/sysmacros.h>
+ 
+ #include "efivars.h"
+ 
+-- 
+2.21.0
+
Signature · 1 line
2.21.0
#4 lore raw

v2 cover Gummiboot fixup

In reply to Esben Haabendal
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Esben" == Esben Haabendal <[email protected]> writes:

From: Esben Haabendal <[email protected]>
These patches fixes gummiboot for building with toolchains using newer gcc and glibc versions.

Quoted 7 lines

Changes since v1:
- Formatted patch with git format-patch and added SoB

Esben Haabendal (3):
gummiboot: use new official upstream git repository
gummiboot: upgrade to last commit before being removed
gummiboot: fix compatibility with newer glibc versions

Committed series, thanks.

It would be great if you could send a patch to add an entry to the DEVELOPERS file for gummiboot.

Signature · 1 line
Bye, Peter Korsgaard