staging: pi433: fix line over 80 characters
PATCH 1/2 staging: pi433: fix line over 80 characters
Fix coding style issues which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by Jules Irenge <[email protected]>
--- drivers/staging/pi433/pi433_if.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/pi433/pi433_if.c +6 -3
@@ -479,7 +479,8 @@ pi433_receive(void *data)/* length byte enabled? */ if (dev->rx_cfg.enable_length_byte ==OPTION_ON ) { retval =wait_event_interruptible (dev->fifo_wait_queue, - dev->free_in_fifo <FIFO_SIZE ); + dev->free_in_fifo < +FIFO_SIZE );if (retval)/* wait was interrupted */ goto abort;
@@ -500,7 +501,8 @@ pi433_receive(void *data) bytes_total--; retval =wait_event_interruptible (dev->fifo_wait_queue, - dev->free_in_fifo <FIFO_SIZE ); + dev->free_in_fifo < +FIFO_SIZE );if (retval)/* wait was interrupted */ goto abort;
@@ -513,7 +515,8 @@ pi433_receive(void *data)while (dev->rx_position < bytes_total) {if (!rf69_get_flag (dev->spi, payload_ready)) { retval =wait_event_interruptible (dev->fifo_wait_queue, - dev->free_in_fifo <FIFO_SIZE ); + dev->free_in_fifo < +FIFO_SIZE );if (retval)/* wait was interrupted */ goto abort; }
Signature · 1 line
2.20.1
PATCH 2/2 staging: pi433: fix line over 80 characters
Fix coding style issues which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
Signed-off-by Jules Irenge <[email protected]>
--- drivers/staging/pi433/pi433_if.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/staging/pi433/pi433_if.c +6 -5
@@ -45,10 +45,10 @@#include "pi433_if.h" #include "rf69.h" -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ -#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ -#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ -#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ +#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ +#define NUM_DIO 2static dev_t pi433_dev;static DEFINE_IDR (pi433_idr);
@@ -672,7 +672,8 @@ pi433_tx_thread(void *data)if (retval <0 )return retval;if (tx_cfg.enable_length_byte ==OPTION_ON ) { - retval =rf69_set_payload_length (spi, size * tx_cfg.repetitions); + retval =rf69_set_payload_length (spi, size * + tx_cfg.repetitions);if (retval <0 )return retval; }else {
Signature · 1 line
2.20.1
Greg KH
maintainerQuoted 7 lines · Jules Irenge
Fix coding style issues which solves checkpatch.pl warning:
"WARNING: line over 80 characters".Signed-off-by Jules Irenge <[email protected]>--- drivers/staging/pi433/pi433_if.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
You sent 2 patches that did different things, yet had the same subject line :(
Please look at how other patch series are named and resend.
Quoted 20 lines
drivers/staging/pi433/pi433_if.c +4
-4@@ -45,10 +45,10 @@#include "pi433_if.h" #include "rf69.h" -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ -#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ -#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ -#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ +#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ +#define NUM_DIO 2static dev_t pi433_dev;static DEFINE_IDR (pi433_idr);
drivers/staging/pi433/pi433_if.c pi433_tx_thread(void *data) · line 676
Quoted 6 lines
drivers/staging/pi433/pi433_if.c +2
-1@@ -672,7 +672,8 @@ pi433_tx_thread(void *data)if (retval <0 )return retval;if (tx_cfg.enable_length_byte ==OPTION_ON ) { - retval =rf69_set_payload_length (spi, size * tx_cfg.repetitions); + retval =rf69_set_payload_length (spi, size * + tx_cfg.repetitions);
This should be broken at the , which makes it easier to understand.
thanks,
greg k-h