Skip to contentSkip to conversation

dt-bindings: clock: g12a-aoclk: expose CLKID_AO_CTS_OSCIN

PATCH Applied Neil Armstrong 2 participants 3 messages Mar 21, 2019 – Apr 1, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: clock: g12a-aoclk: expose CLKID_AO_CTS_OSCIN

When submitted v2 of the G12A AO-CLK IDs, the CLKID_AO_CTS_OSCIN was moved to the internal non-exported bindings, but this clock is necessary for the second AO-CEC-B module since it embeds the 32768Hz dual-divider clock generator unlike the AO-CEC-A module.

Export it back to the public bindings.

Fixes be3d960b0aeb ("dt-bindings: clk: add G12A AO Clock and Reset Bindings")
---
 drivers/clk/meson/g12a-aoclk.h          | 1 -
 include/dt-bindings/clock/g12a-aoclkc.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/clk/meson/g12a-aoclk.h +0 -1
index 666b4493822c..a67c8a7cd7c4 100644
@@ -17,7 +17,6 @@
  * will remain defined here.
  */
 #define CLKID_AO_SAR_ADC_DIV	17
-#define CLKID_AO_CTS_OSCIN	19
 #define CLKID_AO_32K_PRE	20
 #define CLKID_AO_32K_DIV	21
 #define CLKID_AO_32K_SEL	22
include/dt-bindings/clock/g12a-aoclkc.h +1 -0
index 5ac66a2eee0f..e916e49ff288 100644
@@ -28,6 +28,7 @@
 #define CLKID_AO_CLK81		15
 #define CLKID_AO_SAR_ADC_SEL	16
 #define CLKID_AO_SAR_ADC_CLK	18
+#define CLKID_AO_CTS_OSCIN	19
 #define CLKID_AO_32K		23
 #define CLKID_AO_CEC		27
 #define CLKID_AO_CTS_RTC_OSCIN	28
Signature · 1 line
2.21.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Neil Armstrong

When submitted v2 of the G12A AO-CLK IDs, the CLKID_AO_CTS_OSCIN was moved to the internal non-exported bindings, but this clock is necessary for the second AO-CEC-B module since it embeds the 32768Hz dual-divider clock generator unlike the AO-CEC-A module.

Quoted 9 lines

Export it back to the public bindings.

Fixes be3d960b0aeb ("dt-bindings: clk: add G12A AO Clock and Reset Bindings")
---
 drivers/clk/meson/g12a-aoclk.h          | 1 -
 include/dt-bindings/clock/g12a-aoclkc.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
author Applied
#2 lore raw
In reply to Neil Armstrong
Quoted 32 lines · Neil Armstrong

When submitted v2 of the G12A AO-CLK IDs, the CLKID_AO_CTS_OSCIN was moved to the internal non-exported bindings, but this clock is necessary for the second AO-CEC-B module since it embeds the 32768Hz dual-divider clock generator unlike the AO-CEC-A module.

Export it back to the public bindings.

Fixes be3d960b0aeb ("dt-bindings: clk: add G12A AO Clock and Reset Bindings")
---
 drivers/clk/meson/g12a-aoclk.h          | 1 -
 include/dt-bindings/clock/g12a-aoclkc.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/clk/meson/g12a-aoclk.h +0 -1
index 666b4493822c..a67c8a7cd7c4 100644
@@ -17,7 +17,6 @@
  * will remain defined here.
  */
 #define CLKID_AO_SAR_ADC_DIV	17
-#define CLKID_AO_CTS_OSCIN	19
 #define CLKID_AO_32K_PRE	20
 #define CLKID_AO_32K_DIV	21
 #define CLKID_AO_32K_SEL	22
include/dt-bindings/clock/g12a-aoclkc.h +0 -0
index 5ac66a2eee0f..e916e49ff288 100644

include/dt-bindings/clock/g12a-aoclkc.h line 34

Quoted 7 lines
include/dt-bindings/clock/g12a-aoclkc.h +1 -0
@@ -28,6 +28,7 @@
 #define CLKID_AO_CLK81		15
 #define CLKID_AO_SAR_ADC_SEL	16
 #define CLKID_AO_SAR_ADC_CLK	18
+#define CLKID_AO_CTS_OSCIN	19
 #define CLKID_AO_32K		23
 #define CLKID_AO_CEC		27
 #define CLKID_AO_CTS_RTC_OSCIN	28

Applied to next/headers for Linux 5.2-rc1