Skip to contentSkip to conversation

spi: export tracepoint symbols to modules

PATCH In review Arnd Bergmann 3 participants 3 messages Mar 21, 2019 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: export tracepoint symbols to modules

The newly added tracepoints in the spi-mxs driver cause a link error when the driver is a loadable module:

ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!

I'm not quite sure where to put the export statements, but directly after the inclusion of the header seems as good as any other place.

Fixes f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")
---
 drivers/spi/spi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spi.c +2 -0
index 93986f879b09..e5d38152888a 100644
@@ -36,6 +36,8 @@
 
 #define CREATE_TRACE_POINTS
 #include <trace/events/spi.h>
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_start);
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_stop);
 
 #include "internals.h"
 
Signature · 1 line
2.20.0
maintainer
#1 lore raw

Applied "spi: export tracepoint symbols to modules" to the spi tree

The patch

spi: export tracepoint symbols to modules

has been applied to the spi tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From ca1438dcb34c7fcad63b6ce14ea63a870b92a69b Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Thu, 21 Mar 2019 13:42:25 +0100
Subject: [PATCH] spi: export tracepoint symbols to modules

The newly added tracepoints in the spi-mxs driver cause a link error when the driver is a loadable module:

ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!

I'm not quite sure where to put the export statements, but directly after the inclusion of the header seems as good as any other place.

Fixes f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")
---
 drivers/spi/spi.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spi.c +2 -0
index 2be394d3bc59..bd2a424672df 100644
@@ -36,6 +36,8 @@
 
 #define CREATE_TRACE_POINTS
 #include <trace/events/spi.h>
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_start);
+EXPORT_TRACEPOINT_SYMBOL(spi_transfer_stop);
 
 #include "internals.h"
 
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

The newly added tracepoints in the spi-mxs driver cause a link error when the driver is a loadable module:

ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!

I'm not quite sure where to put the export statements, but directly after the inclusion of the header seems as good as any other place.

I agree it looks a bit ugly, but I don't have a better idea either.

Quoted 3 lines
Fixes f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")

Looks right:

Thanks for finding and fixing that.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |