quota: fix a problem about transfer quota
PATCH 1/1 quota: fix a problem about transfer quota
Run script as below with root(has the CAP_SYS_RESOUCE), we will trigger a problem with "Disk quota exceeded". The resons is that after 7b9ca4c61, __dquot_transfer will call dquot_add_space with flags=0, dquot_add_space thinks it's a preallocation, then return -EDQUOT. Fix it by set flags as DQUOT_SPACE_WARN.
mkfs.ext4 -O quota,project /dev/vdb
mount -o prjquota /dev/vdb /mnt
setquota -P 23 1 1 0 0 /dev/vdb
dd if=/dev/zero of=/mnt/test-file bs=4K count=1
chattr -p 23 test-file
Fixes 7b9ca4c61("quota: Reduce contention on dq_data_lock")
Signed-off-by yangerkun <[email protected]>
--- fs/quota/dquot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/quota/dquot.c +2 -2
@@ -1993,8 +1993,8 @@ int __dquot_transfer(struct inode *inode, struct dquot **transfer_to) &warn_to[cnt]);if (ret) goto over_quota; - ret =dquot_add_space (transfer_to[cnt], cur_space, rsv_space,0 , - &warn_to[cnt]); + ret =dquot_add_space (transfer_to[cnt], cur_space, rsv_space, +DQUOT_SPACE_WARN , &warn_to[cnt]);if (ret) {spin_lock (&transfer_to[cnt]->dq_dqb_lock);dquot_decr_inodes (transfer_to[cnt], inode_usage);
Signature · 1 line
2.9.5