drm/panel: Add Novatek NT35596 panel
Subsystems (4)
v2 cover drm/panel: Add Novatek NT35596 panel
This is v2 series for Novatek NT35596 panel driver. here is previous series set[2]
Since there is no proper programming guide for NT35596 IC, the driver init sequence is referenced from [1] but analyzed based on datasheet.
NT35596 support several regulators on the chip, among those ony 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on sequence. Right now driver added code for 3-regulator based power-on sequence since MTF050FHDI-03 panel support. This power-on sequence may be moved to panel_desc in future, if there is any new panel would come up with other type of sequence.
Changes for v2:
- control enable/disable calls using enable, prepare flags
- comment on delays
- move 120ms delay on power-on since it is part of power-on sequence
- fix driver name as novatek-nt35596
[2] https://patchwork.freedesktop.org/series/57490/#rev1
[1] https://android.googlesource.com/kernel/msm/+/android-msm-shamu-3.10-lollipop-mr1/arch/arm/boot/dts/qcom/dsi-panel-nt35596-1080p-video.dtsi
Any inputs?
Jagan.
Jagan Teki (4):
dt-bindings: Add vendor prefix for novatek
dt-bindings: Add vendor prefix for microtech
dt-bindings: display: Add Novatek NT35596 panel documentation drm/panel: Add Novatek NT35596 panel driver
.../display/panel/novatek,nt35596.txt | 32 + .../devicetree/bindings/vendor-prefixes.txt | 2 + MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 13 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-novatek-nt35596.c | 895 ++++++++++++++++++ 6 files changed, 949 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt35596.c
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v2 1/4 dt-bindings: Add vendor prefix for novatek
Add vendor prefix for novatek.
Novatek Microelectronics Corp. is a leading fabless chip design company specializing in the design, development and sales of a wide range of display driver ICs & SoC solutions.
--- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -281,6 +281,7 @@ nintendo Nintendo nlt NLT Technologies, Ltd. nokia Nokia nordic Nordic Semiconductor +novatek Novatek Microelectronics Corp. novtech NovTech, Inc. nutsboard NutsBoard nuvoton Nuvoton Technology Corporation
Signature · 1 line
2.18.0.321.gffc6fa0e3
Re: [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek
Quoted 11 lines · Jagan Teki
Add vendor prefix for novatek.
Novatek Microelectronics Corp. is a leading fabless chip design company specializing in the design, development and sales of a wide range of display driver ICs & SoC solutions.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 2/4 dt-bindings: Add vendor prefix for microtech
In reply to Jagan TekiAdd vendor prefix for microtech, known as Microtech Technology Company Limited. a known producer for Liquid Crytal Display modules and Touch Panels.
--- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -249,6 +249,7 @@ micrel Micrel Inc. microchip Microchip Technology Inc. microcrystal Micro Crystal AG micron Micron Technology Inc. +microtech Microtech Technology Company Limited mikroe MikroElektronika d.o.o. minix MINIX Technology Ltd. miramems MiraMEMS Sensing Technology Co., Ltd.
Signature · 1 line
2.18.0.321.gffc6fa0e3
Re: [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech
Quoted 9 lines · Jagan Teki
Add vendor prefix for microtech, known as Microtech Technology Company Limited. a known producer for Liquid Crytal Display modules and Touch Panels.
Signed-off-by Jagan Teki <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)
PATCH v2 3/4 dt-bindings: display: Add Novatek NT35596 panel documentation
In reply to Jagan TekiNovatek NT35596 is a single-chip IC solution for small or medium-sized LTPS TFT LCD panels. NT35596 provides several system interfaces like MIPI/SPI/I2C.
Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip.
NT35596 support several regulators on the chip, among those only 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on sequence.
Out of four regulators MTF050FHDI-03 panel do support 3-regulator based power-on sequence, so this patch documented these 3 needful regulators and rest can be add while supporting new panels on the similar chip IC.
--- .../display/panel/novatek,nt35596.txt | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt
Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt new file +32 -0
@@ -0,0 +1,32 @@ +Novatek NT35596 based LCD panels + +Novatek NT35596 is a single-chip IC solution for small or medium-sized +LTPS TFT LCD panels. NT35596 provides several system interfaces like +MIPI/SPI/I2C. + +Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which +has inbuilt NT35596 IC chip. + +Required properties: +- compatible: must be "novatek,nt35596" and one of + * "microtech,mtf050fhdi-03" +- reset-gpios: a GPIO phandle for the reset pin + +Required properties for microtech,mtf050fhdi-03: +- reg: DSI virtual channel used by that screen +- dvdd-supply: I/O system regulator +- avdd-supply: analog regulator for MIPI circuit +- avee-supply: analog regulator for MIPI circuit + +Optional properties: +- backlight: phandle for the backlight control. + +panel@0 { + compatible = "microtech,mtf050fhdi-03", "novatek,nt35596"; + reg = <0>; + dvdd-supply = <®_dldo2>; /* VCC-MIPI */ + avdd-supply = <®_dc1sw>; /* AVDD_5V0 */ + avee-supply = <®_dc1sw>; /* AVEE_5V */ + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; +};
Signature · 6 lines
2.18.0.321.gffc6fa0e3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 3/4] dt-bindings: display: Add Novatek NT35596 panel documentation
Quoted 14 lines · Jagan Teki
Novatek NT35596 is a single-chip IC solution for small or medium-sized LTPS TFT LCD panels. NT35596 provides several system interfaces like MIPI/SPI/I2C.
Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip.
NT35596 support several regulators on the chip, among those only 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on sequence.
Out of four regulators MTF050FHDI-03 panel do support 3-regulator based power-on sequence, so this patch documented these 3 needful regulators and rest can be add while supporting new panels on the similar chip IC.
Quoted 6 lines
Signed-off-by Jagan Teki <[email protected]>--- .../display/panel/novatek,nt35596.txt | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 4/4 drm/panel: Add Novatek NT35596 panel driver
In reply to Jagan TekiNovatek NT35596 is a single-chip IC solution for small or medium-sized LTPS TFT LCD panels. NT35596 provides several system interfaces like MIPI/SPI/I2C.
Currently added support for Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip.
NT35596 support several regulators on the chip, among those only 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used for power-on sequence.
This driver added code for 3-regulator based power-on sequence as of now since MTF050FHDI-03 panel support it. This power-on sequence may be moved to panel_desc in future, if any new panel would come up with other type of sequence.
--- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 13 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-novatek-nt35596.c | 895 ++++++++++++++++++ 4 files changed, 915 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt35596.c
MAINTAINERS +6 -0
@@ -4922,6 +4922,12 @@ S: Maintained F: drivers/gpu/drm/tinydrm/hx8357d.c F: Documentation/devicetree/bindings/display/himax,hx8357d.txt +DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS +M: Jagan Teki <[email protected]> +S: Maintained +F: drivers/gpu/drm/panel/panel-novatek-nt35596.c +F: Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt + DRM DRIVER FOR INTEL I810 VIDEO CARDS S: Orphan / Obsolete F: drivers/gpu/drm/i810/
drivers/gpu/drm/panel/Kconfig +13 -0
@@ -119,6 +119,19 @@ config DRM_PANEL_LG_LG4573 Say Y here if you want to enable support for LG4573 RGB panel. To compile this driver as a module, choose M here. +config DRM_PANEL_NOVATEK_NT35596 + tristate "Novatek NT35596 panel driver" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for the Novatek NT35596 + panel controller driver. + + Novatek NT35596 is a single-chip IC solution for small or medium + sized LTPS TFT LCD panels. NT35596 provides several system interfaces + like MIPI/SPI/I2C. + config DRM_PANEL_OLIMEX_LCD_OLINUXINO tristate "Olimex LCD-OLinuXino panel" depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
@@ -10,6 +10,7 @@ obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o obj-$(CONFIG_DRM_PANEL_JDI_LT070ME05000) += panel-jdi-lt070me05000.o obj-$(CONFIG_DRM_PANEL_KINGDISPLAY_KD097D04) += panel-kingdisplay-kd097d04.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o +obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35596) += panel-novatek-nt35596.o obj-$(CONFIG_DRM_PANEL_OLIMEX_LCD_OLINUXINO) += panel-olimex-lcd-olinuxino.o obj-$(CONFIG_DRM_PANEL_ORISETECH_OTM8009A) += panel-orisetech-otm8009a.o obj-$(CONFIG_DRM_PANEL_PANASONIC_VVX10F034N00) += panel-panasonic-vvx10f034n00.o
drivers/gpu/drm/panel/panel-novatek-nt35596.c new file +895 -0
895 lines not on this page · raw message
Signature · 1 line
2.18.0.321.gffc6fa0e3
Re: [PATCH v2 4/4] drm/panel: Add Novatek NT35596 panel driver
Hi Jagan.
Thanks for this new panel driver.
A few notes, please see inline comments below.
Quoted 23 lines · Jagan Teki
Novatek NT35596 is a single-chip IC solution for small or medium-sized LTPS TFT LCD panels. NT35596 provides several system interfaces like MIPI/SPI/I2C.
Currently added support for Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip.
NT35596 support several regulators on the chip, among those only 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used for power-on sequence.
This driver added code for 3-regulator based power-on sequence as of now since MTF050FHDI-03 panel support it. This power-on sequence may be moved to
panel_descin future, if any new panel would come up with other type of sequence.Signed-off-by Jagan Teki <[email protected]>---
MAINTAINERS +0
-0
MAINTAINERS S: Maintained · line 4930
Quoted 9 lines
MAINTAINERS +6
-0@@ -4922,6 +4922,12 @@ S: Maintained F: drivers/gpu/drm/tinydrm/hx8357d.c F: Documentation/devicetree/bindings/display/himax,hx8357d.txt +DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS +M: Jagan Teki <[email protected]> +S: Maintained +F: drivers/gpu/drm/panel/panel-novatek-nt35596.c +F: Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt +
I recall the entries in MAINTAINERS come in alphabetic order based on their headline.
So this is the wrong order as "I" comes before "N":
DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS DRM DRIVER FOR INTEL I810 VIDEO CARDS
Please move
Quoted 15 lines
MAINTAINERS +15
-0+#define NT35596_CMD_LEN 2 + +struct nt35596_panel_desc { + const struct drm_display_mode *mode; + unsigned int lanes; + unsigned long flags; + enum mipi_dsi_pixel_format format; + const struct nt35596_init_cmd *panel_cmds; + unsigned int num_panel_cmds; +}; + +struct nt35596 { + struct drm_panel panel; + struct mipi_dsi_device *dsi; + const struct nt35596_panel_desc *desc;
MAINTAINERS S: Maintained
Quoted 10 lines
MAINTAINERS +9
-0+ + struct backlight_device *backlight; + struct regulator *dvdd; + struct regulator *avdd; + struct regulator *avee; + struct gpio_desc *reset; + + bool prepared; + bool enabled;
We should move these flags to the core as more and more drivers seems to neeed them.
Something you could take a shot at?
Quoted 13 lines
MAINTAINERS +13
-0+}; + +static inline struct nt35596 *panel_to_nt35596(struct drm_panel *panel) +{ + return container_of(panel, struct nt35596, panel); +} + +struct nt35596_init_cmd { + u8 data[NT35596_CMD_LEN]; +}; + +static const struct nt35596_init_cmd microtech_mtf050fhdi_cmds[] = { + { .data = { 0xFF, 0xEE } },
...
Quoted 32 lines
MAINTAINERS +32
-0+ /* Exit CMD1, Turn-off Tear ON */ + { .data = { 0xFF, 0x00 } }, + { .data = { 0x35, 0x00 } }, +}; + +static int nt35596_power_on(struct nt35596 *nt35596) +{ + int ret; + + ret = regulator_enable(nt35596->dvdd); + if (ret) + return ret; + + /* T_power_ramp_up for VDDI */ + msleep(2); + + ret = regulator_enable(nt35596->avdd); + if (ret) + return ret; + + /* T_power_ramp_up for AVDD/AVEE */ + msleep(5); + + ret = regulator_enable(nt35596->avee); + if (ret) + return ret; + + msleep(10); + + gpiod_set_value(nt35596->reset, 0); + + msleep(120);
MAINTAINERS
Quoted 10 lines
MAINTAINERS +10
-0+ + gpiod_set_value(nt35596->reset, 1); + + /* wait for 120ms after reset deassert */ + msleep(120); + + return 0; +} + +static int nt35596_power_off(struct nt35596 *nt35596)
This function never fails. Should you check regulator_disable()? (Mst drivers skips check of regulator_disable() and it seems safe to skip it here too.
Make it a void function if it cannot error out.
Quoted 51 lines
MAINTAINERS +51
-0+{ + gpiod_set_value(nt35596->reset, 0); + + msleep(10); + + regulator_disable(nt35596->avee); + + /* T_power_ramp_down for AVEE/AVDD */ + msleep(5); + + regulator_disable(nt35596->avdd); + + /* T_power_ramp_down for VDDI */ + msleep(2); + + regulator_disable(nt35596->dvdd); + + return 0; +} + +static int nt35596_prepare(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + struct mipi_dsi_device *dsi = nt35596->dsi; + const struct nt35596_panel_desc *desc = nt35596->desc; + int ret, i; + + if (nt35596->prepared) + return 0; + + ret = nt35596_power_on(nt35596); + if (ret) + return ret; + + for (i = 0; i < desc->num_panel_cmds; i++) { + const struct nt35596_init_cmd *cmd = &desc->panel_cmds[i]; + + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, + NT35596_CMD_LEN); + if (ret < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to write cmd %d: %d\n", i, ret); + goto power_off; + } + } + + ret = mipi_dsi_dcs_exit_sleep_mode(dsi); + if (ret < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to exit from sleep mode: %d\n", ret); + goto power_off;
MAINTAINERS
Quoted 10 lines
MAINTAINERS +10
-0+ } + + /* wait for 120ms after sending exit sleep mode */ + msleep(120); + + ret = mipi_dsi_dcs_set_display_on(dsi); + if (ret < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to set display on: %d\n", ret); + goto power_off;
In the unprepare function we take care to exter sellp mode before we power off. Should we not do the same here in this error case. We managed to exit sleep mode just above (or so we think at least).
Quoted 61 lines
MAINTAINERS +61
-0+ } + + nt35596->prepared = true; + + return 0; + +power_off: + if (nt35596_power_off(nt35596)) + DRM_DEV_ERROR(panel->dev, "failed to power off\n"); + return ret; +} + +static int nt35596_enable(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + + if (nt35596->enabled) + return 0; + + backlight_enable(nt35596->backlight); + + nt35596->enabled = true; + + return 0; +} + +static int nt35596_disable(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + + if (!nt35596->enabled) + return 0; + + backlight_disable(nt35596->backlight); + + nt35596->enabled = false; + + return 0; +} + +static int nt35596_unprepare(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + + if (!nt35596->prepared) + return 0; + + mipi_dsi_dcs_set_display_off(nt35596->dsi); + + mipi_dsi_dcs_enter_sleep_mode(nt35596->dsi); + + /* wait for 120ms after sending enter sleep mode */ + msleep(120); + + nt35596_power_off(nt35596); + + nt35596->prepared = false; + + return 0; +} +
MAINTAINERS
Quoted 10 lines
MAINTAINERS +10
-0+static int nt35596_get_modes(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + const struct drm_display_mode *desc_mode = nt35596->desc->mode; + struct drm_display_mode *mode; + + mode = drm_mode_duplicate(panel->drm, desc_mode); + if (!mode) { + DRM_DEV_ERROR(&nt35596->dsi->dev, + "failed to add mode %ux%ux@%u\n",
Please remove the extra "x" here ^
We want it to print "failed to add mode 1080x1920@50" and not
"failed to add mode 1080x1920x@50".
Quoted 66 lines
MAINTAINERS +66
-0+ desc_mode->hdisplay, + desc_mode->vdisplay, + desc_mode->vrefresh); + return -ENOMEM; + } + + drm_mode_set_name(mode); + drm_mode_probed_add(panel->connector, mode); + + panel->connector->display_info.width_mm = desc_mode->width_mm; + panel->connector->display_info.height_mm = desc_mode->height_mm; + + return 1; +} + +static const struct drm_panel_funcs nt35596_funcs = { + .disable = nt35596_disable, + .unprepare = nt35596_unprepare, + .prepare = nt35596_prepare, + .enable = nt35596_enable, + .get_modes = nt35596_get_modes, +}; + +static const struct drm_display_mode microtech_mtf050fhdi_mode = { + .clock = 147000, + + .hdisplay = 1080, + .hsync_start = 1080 + 408, + .hsync_end = 1080 + 408 + 4, + .htotal = 1080 + 408 + 4 + 38, + + .vdisplay = 1920, + .vsync_start = 1920 + 9, + .vsync_end = 1920 + 9 + 12, + .vtotal = 1920 + 9 + 12 + 9, + .vrefresh = 50, + + .width_mm = 64, + .height_mm = 118, + + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, +}; + +static const struct nt35596_panel_desc microtech_mtf050fhdi_desc = { + .mode = µtech_mtf050fhdi_mode, + .lanes = 4, + .flags = MIPI_DSI_MODE_VIDEO_BURST, + .format = MIPI_DSI_FMT_RGB888, + .panel_cmds = microtech_mtf050fhdi_cmds, + .num_panel_cmds = ARRAY_SIZE(microtech_mtf050fhdi_cmds), +}; + +static int nt35596_dsi_probe(struct mipi_dsi_device *dsi) +{ + const struct nt35596_panel_desc *desc; + struct nt35596 *nt35596; + int ret; + + nt35596 = devm_kzalloc(&dsi->dev, sizeof(*nt35596), GFP_KERNEL); + if (!nt35596) + return -ENOMEM; + + desc = of_device_get_match_data(&dsi->dev); + dsi->mode_flags = desc->flags; + dsi->format = desc->format; + dsi->lanes = desc->lanes;
MAINTAINERS
Quoted 10 lines
MAINTAINERS +10
-0+ + drm_panel_init(&nt35596->panel); + nt35596->panel.dev = &dsi->dev; + nt35596->panel.funcs = &nt35596_funcs; + + nt35596->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); + if (IS_ERR(nt35596->dvdd)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); + return PTR_ERR(nt35596->dvdd); + }
It would be nive to have the error code in the above error logging. Same goes for the remaining get operatiosn below.
Quoted 56 lines
MAINTAINERS +56
-0+ + nt35596->avdd = devm_regulator_get(&dsi->dev, "avdd"); + if (IS_ERR(nt35596->avdd)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); + return PTR_ERR(nt35596->avdd); + } + + nt35596->avee = devm_regulator_get(&dsi->dev, "avee"); + if (IS_ERR(nt35596->avee)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avee regulator\n"); + return PTR_ERR(nt35596->avee); + } + + nt35596->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(nt35596->reset)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); + return PTR_ERR(nt35596->reset); + } + + nt35596->backlight = devm_of_find_backlight(&dsi->dev); + if (IS_ERR(nt35596->backlight)) + return PTR_ERR(nt35596->backlight); + + ret = drm_panel_add(&nt35596->panel); + if (ret < 0) + return ret; + + mipi_dsi_set_drvdata(dsi, nt35596); + nt35596->dsi = dsi; + nt35596->desc = desc; + + return mipi_dsi_attach(dsi); +} + +static int nt35596_dsi_remove(struct mipi_dsi_device *dsi) +{ + struct nt35596 *nt35596 = mipi_dsi_get_drvdata(dsi); + + mipi_dsi_detach(dsi); + drm_panel_remove(&nt35596->panel); + + return 0; +} + +static const struct of_device_id nt35596_of_match[] = { + { + .compatible = "microtech,mtf050fhdi-03", + .data = µtech_mtf050fhdi_desc, + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, nt35596_of_match); + +static struct mipi_dsi_driver nt35596_driver = { + .probe = nt35596_dsi_probe, + .remove = nt35596_dsi_remove,
MAINTAINERS
Quoted 10 lines
MAINTAINERS +10
-0+ .driver = { + .name = "novatek-nt35596", + .of_match_table = nt35596_of_match, + }, +}; +module_mipi_dsi_driver(nt35596_driver); + +MODULE_AUTHOR("Jagan Teki <[email protected]>"); +MODULE_DESCRIPTION("Novatek NT35596 MIPI-DSI LCD panel"); +MODULE_LICENSE("GPL");
Please check that this license mathes your SPDX identifier.
Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel