tls: Add SOL_TLS to uapi
Subsystems (3)
PATCH v2 1/1 tls: Add SOL_TLS to uapi
User applications are forced to define the SOL_TLS manually at the moment, which is inappropriate. Add SOL_TLS to the uapi.
Other protocols handle this similarly. For example see SOL_TIPC.
---
v1: update commit message
--- include/uapi/linux/tls.h | 4 ++++ 1 file changed, 4 insertions(+)
include/uapi/linux/tls.h +4 -0
@@ -36,6 +36,10 @@#include <linux/types.h> +#ifndef SOL_TLS +#define SOL_TLS 282 +#endif +/* TLS socket options */ #define TLS_TX 1/* Set transmit parameters */ #define TLS_RX 2/* Set receive parameters */
Signature · 1 line
1.8.3.1
David Miller
maintainerFrom: Boris Pismenny <[email protected]>
Date: Thu, 21 Mar 2019 16:29:02 +0200
Quoted 8 lines
User applications are forced to define the
SOL_TLSmanually at the moment, which is inappropriate. AddSOL_TLSto the uapi.Other protocols handle this similarly. For example see
SOL_TIPC.Signed-off-by Boris Pismenny <[email protected]>---
v1: update commit message
Where did this convention come from where we define SOL_* in linux/socket.h and then have to do this ifdef dance in the per-family UAPI header?
AF_ALG and AF_KCM never did this, but I see that AF_TIPC did.
There really has to be a better way.
Quoted 8 lines · David Miller
From: Boris Pismenny <[email protected]>
Date: Thu, 21 Mar 2019 16:29:02 +0200Quoted 5 lines
User applications are forced to define the
SOL_TLSmanually at the moment, which is inappropriate. AddSOL_TLSto the uapi.Other protocols handle this similarly. For example see
SOL_TIPC.
Quoted 8 lines
Quoted 3 lines
Signed-off-by Boris Pismenny <[email protected]>---
v1: update commit messageWhere did this convention come from where we define SOL_* in
linux/socket.hand then have to do this ifdef dance in the per-family UAPI header?
The source for this is not known to me.
I've saw that this issue was mentioned and fixed in libc:
http://sourceware.org/ml/libc-alpha/2016-05/msg00322.html
Quoted 4 lines
AF_ALGandAF_KCMnever did this, but I see thatAF_TIPCdid.There really has to be a better way.
Maybe libc maintainers need to be notified whenever linux/socket.h is modified.
David Miller
maintainerFrom: Boris Pismenny <[email protected]>
Date: Fri, 22 Mar 2019 14:32:45 +0000
Quoted 3 lines
The source for this is not known to me.
I've saw that this issue was mentioned and fixed in libc:
http://sourceware.org/ml/libc-alpha/2016-05/msg00322.html
...
Quoted 2 lines
Maybe libc maintainers need to be notified whenever
linux/socket.his modified.
I think that is a much better way to handle this.