staging: rtl8723bs: include: remove typedef of
v2 cover staging: rtl8723bs: include: remove typedef of
This patchset removes typedef from various structures defined in /staging/rtl8723bs/include/rtw_pwrctl.h as
the linux kernel coding style guidelines discourage the use of typedef for struct types.
V2:
- Remove extra whitespaces
Himadri Pandya (5):
staging: rtl8723bs: include: remove typedef for struct pno_nlo_info
staging: rtl8723bs: include: remove typedef for struct pno_ssid
staging: rtl8723bs: include: remove typedef for struct pno_ssid_list
staging: rtl8723bs: include: remove typedef for struct
pno_scan_channel_info
staging: rtl8723bs: include: remove typedef for struct pno_scan_info
.../staging/rtl8723bs/include/rtw_pwrctrl.h | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/5 staging: rtl8723bs: include: remove typedef for struct pno_nlo_info
Remove typedef for struct pno_nlo_info as the Linux kernel coding style guidelines discourage the use of typedefs for struct types.
---
Changes in V2:
- Remove extra whitespaces befor *pnlo_info
--- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +3 -3
@@ -159,7 +159,7 @@ enum PS_DENY_REASON { }; #ifdef CONFIG_PNO_SUPPORT -typedef struct pno_nlo_info +struct pno_nlo_info { u32 fast_scan_period; /* Fast scan period */ u32 ssid_num; /* number of entry */
@@ -168,7 +168,7 @@ typedef struct pno_nlo_infou8 ssid_length[MAX_PNO_LIST_COUNT ];/* SSID Length Array */ u8 ssid_cipher_info[MAX_PNO_LIST_COUNT ];/* Cipher information for security */ u8 ssid_channel_info[MAX_PNO_LIST_COUNT ];/* channel information */ -}pno_nlo_info_t; +}; typedef struct pno_ssid { u32 SSID_len;
@@ -279,7 +279,7 @@ struct pwrctrl_priv#ifdef CONFIG_PNO_SUPPORT u8 pno_in_resume;u8 pno_inited; -pno_nlo_info_t *pnlo_info; +struct pno_nlo_info *pnlo_info;pno_scan_info_t *pscan_info;pno_ssid_list_t *pno_ssid_list;#endif
Signature · 1 line
2.17.1
PATCH v2 2/5 staging: rtl8723bs: include: remove typedef for struct pno_ssid
In reply to Himadri PandyaRemove typedef for struct pno_ssid as The Linux kernel coding style guidelines discourage the use of typedefs for struct types.
--- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +3 -3
@@ -170,13 +170,13 @@ struct pno_nlo_infou8 ssid_channel_info[MAX_PNO_LIST_COUNT ];/* channel information */ }; -typedef struct pno_ssid { +struct pno_ssid {u32 SSID_len;u8 SSID[32 ]; -}pno_ssid_t ; +};typedef struct pno_ssid_list { -pno_ssid_t node[MAX_PNO_LIST_COUNT ]; +struct pno_ssid node[MAX_PNO_LIST_COUNT ]; }pno_ssid_list_t ; typedef struct pno_scan_channel_info
Signature · 1 line
2.17.1
PATCH v2 3/5 staging: rtl8723bs: include: remove typedef for struct pno_ssid_list
In reply to Himadri PandyaRemove typedef from struct pno_ssid_list as The Linux kernel coding style guidelines discourage the use of typedefs for struct types.
---
Changes in V2:
- Remove extra whitespaces before *pno_ssid_list
--- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +3 -3
@@ -175,9 +175,9 @@ struct pno_ssid {u8 SSID [32 ]; }; -typedef struct pno_ssid_list { +struct pno_ssid_list {struct pno_ssid node[MAX_PNO_LIST_COUNT ]; -}pno_ssid_list_t ; +}; typedef struct pno_scan_channel_info {
@@ -281,7 +281,7 @@ struct pwrctrl_privu8 pno_inited;struct pno_nlo_info *pnlo_info;pno_scan_info_t *pscan_info; -pno_ssid_list_t *pno_ssid_list; +struct pno_ssid_list *pno_ssid_list;#endif u32 wowlan_pattern_context[8 ][5 ];u64 wowlan_fw_iv;
Signature · 1 line
2.17.1
PATCH v2 4/5 staging: rtl8723bs: include: remove typedef for struct pno_scan_channel_info
In reply to Himadri PandyaRemove typedef for struct pno_scan_channel_info as The Linux kernel coding style guidelines discourage the use of typedefs for struct types.
--- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +3 -3
@@ -179,13 +179,13 @@ struct pno_ssid_list {struct pno_ssid node[MAX_PNO_LIST_COUNT ]; }; -typedef struct pno_scan_channel_info +struct pno_scan_channel_info {u8 channel;u8 tx_power;u8 timeout;u8 active;/* set 1 means active scan, or pasivite scan. */ -}pno_scan_channel_info_t ; +}; typedef struct pno_scan_info {
@@ -198,7 +198,7 @@ typedef struct pno_scan_infou8 orig_ch;/* original channel */ u8 channel_num;/* number of channel */ u64 rfe_type;/* rfe_type && 0x00000000000000ff */ - pno_scan_channel_info_t ssid_channel_info[MAX_SCAN_LIST_COUNT]; + struct pno_scan_channel_info ssid_channel_info[MAX_SCAN_LIST_COUNT]; }pno_scan_info_t;#endif /* CONFIG_PNO_SUPPORT */
Signature · 1 line
2.17.1
PATCH v2 5/5 staging: rtl8723bs: include: remove typedef for struct pno_scan_info
In reply to Himadri PandyaRemove typedef for struct pno_scan_info as The Linux kernel coding style guidelines discourage the use of typedefs for struct types.
---
Changes in V2:
- Remove extra whitespaces befor *pscan_info
--- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +3 -3
@@ -187,7 +187,7 @@ struct pno_scan_channel_infou8 active;/* set 1 means active scan, or pasivite scan. */ }; -typedef struct pno_scan_info +struct pno_scan_info {u8 enableRFE;/* Enable RFE */ u8 period_scan_time;/* exclusive with fast_scan_period and slow_scan_period */
@@ -199,7 +199,7 @@ typedef struct pno_scan_infou8 channel_num;/* number of channel */ u64 rfe_type;/* rfe_type && 0x00000000000000ff */ struct pno_scan_channel_info ssid_channel_info[MAX_SCAN_LIST_COUNT]; -}pno_scan_info_t; +};#endif /* CONFIG_PNO_SUPPORT */ struct pwrctrl_priv
@@ -280,7 +280,7 @@ struct pwrctrl_privu8 pno_in_resume;u8 pno_inited;struct pno_nlo_info *pnlo_info; -pno_scan_info_t *pscan_info; +struct pno_scan_info *pscan_info;struct pno_ssid_list *pno_ssid_list;#endif u32 wowlan_pattern_context[8 ][5 ];
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 7 lines · Himadri Pandya
This patchset removes typedef from various structures defined in /staging/rtl8723bs/include/rtw_pwrctl.h as
the linux kernel coding style guidelines discourage the use of typedef for struct types.V2:
- Remove extra whitespaces
Nice work, all now applied.