Skip to contentSkip to conversation

staging: mt7621-pci: Add spaces to Macros in pci-mt7621.c

PATCH In review Emanuel Bennici 2 participants 2 messages Mar 21, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: mt7621-pci: Add spaces to Macros in pci-mt7621.c

Apply Kernel Coding Style to pci-mt7621.c by adding Tabs

---
 drivers/staging/mt7621-pci/pci-mt7621.c | 70 ++++++++++++-------------
 1 file changed, 35 insertions(+), 35 deletions(-)
drivers/staging/mt7621-pci/pci-mt7621.c +35 -35
index 379ae780c691..c5d9b7204aef 100644
@@ -34,16 +34,16 @@
 #include "../../pci/pci.h"
 
 /* sysctl */
-#define MT7621_CHIP_REV_ID		0x0c
-#define CHIP_REV_MT7621_E2		0x0101
+#define MT7621_CHIP_REV_ID			0x0c
+#define CHIP_REV_MT7621_E2			0x0101
 
 /* MediaTek specific configuration registers */
-#define PCIE_FTS_NUM			0x70c
-#define PCIE_FTS_NUM_MASK		GENMASK(15, 8)
-#define PCIE_FTS_NUM_L0(x)		((x) & 0xff << 8)
+#define PCIE_FTS_NUM				0x70c
+#define PCIE_FTS_NUM_MASK			GENMASK(15, 8)
+#define PCIE_FTS_NUM_L0(x)			((x) & 0xff << 8)
 
 /* rt_sysc_membase relative registers */
-#define RALINK_PCIE_CLK_GEN		0x7c
+#define RALINK_PCIE_CLK_GEN			0x7c
 #define RALINK_PCIE_CLK_GEN1		0x80
 
 /* Host-PCI bridge registers */
@@ -51,44 +51,44 @@
 #define RALINK_PCI_PCIMSK_ADDR		0x000C
 #define RALINK_PCI_CONFIG_ADDR		0x0020
 #define RALINK_PCI_CONFIG_DATA		0x0024
-#define RALINK_PCI_MEMBASE		0x0028
-#define RALINK_PCI_IOBASE		0x002C
+#define RALINK_PCI_MEMBASE			0x0028
+#define RALINK_PCI_IOBASE			0x002C
 
 /* PCICFG virtual bridges */
-#define MT7621_BR0_MASK			GENMASK(19, 16)
-#define MT7621_BR1_MASK			GENMASK(23, 20)
-#define MT7621_BR2_MASK			GENMASK(27, 24)
-#define MT7621_BR_ALL_MASK		GENMASK(27, 16)
-#define MT7621_BR0_SHIFT		16
-#define MT7621_BR1_SHIFT		20
-#define MT7621_BR2_SHIFT		24
+#define MT7621_BR0_MASK				GENMASK(19, 16)
+#define MT7621_BR1_MASK				GENMASK(23, 20)
+#define MT7621_BR2_MASK				GENMASK(27, 24)
+#define MT7621_BR_ALL_MASK			GENMASK(27, 16)
+#define MT7621_BR0_SHIFT			16
+#define MT7621_BR1_SHIFT			20
+#define MT7621_BR2_SHIFT			24
 
 /* PCIe RC control registers */
-#define MT7621_PCIE_OFFSET		0x2000
-#define MT7621_NEXT_PORT		0x1000
+#define MT7621_PCIE_OFFSET			0x2000
+#define MT7621_NEXT_PORT			0x1000
 
 #define RALINK_PCI_BAR0SETUP_ADDR	0x0010
 #define RALINK_PCI_IMBASEBAR0_ADDR	0x0018
-#define RALINK_PCI_ID			0x0030
-#define RALINK_PCI_CLASS		0x0034
-#define RALINK_PCI_SUBID		0x0038
-#define RALINK_PCI_STATUS		0x0050
+#define RALINK_PCI_ID				0x0030
+#define RALINK_PCI_CLASS			0x0034
+#define RALINK_PCI_SUBID			0x0038
+#define RALINK_PCI_STATUS			0x0050
 
 /* Some definition values */
-#define PCIE_REVISION_ID		BIT(0)
-#define PCIE_CLASS_CODE			(0x60400 << 8)
-#define PCIE_BAR_MAP_MAX		GENMASK(30, 16)
-#define PCIE_BAR_ENABLE			BIT(0)
-#define PCIE_PORT_INT_EN(x)		BIT(20 + (x))
-#define PCIE_PORT_CLK_EN(x)		BIT(24 + (x))
-#define PCIE_PORT_PERST(x)		BIT(1 + (x))
-#define PCIE_PORT_LINKUP		BIT(0)
-
-#define PCIE_CLK_GEN_EN			BIT(31)
-#define PCIE_CLK_GEN_DIS		0
-#define PCIE_CLK_GEN1_DIS		GENMASK(30, 24)
-#define PCIE_CLK_GEN1_EN		(BIT(27) | BIT(25))
-#define MEMORY_BASE			0x0
+#define PCIE_REVISION_ID			BIT(0)
+#define PCIE_CLASS_CODE				(0x60400 << 8)
+#define PCIE_BAR_MAP_MAX			GENMASK(30, 16)
+#define PCIE_BAR_ENABLE				BIT(0)
+#define PCIE_PORT_INT_EN(x)			BIT(20 + (x))
+#define PCIE_PORT_CLK_EN(x)			BIT(24 + (x))
+#define PCIE_PORT_PERST(x)			BIT(1 + (x))
+#define PCIE_PORT_LINKUP			BIT(0)
+
+#define PCIE_CLK_GEN_EN				BIT(31)
+#define PCIE_CLK_GEN_DIS			0
+#define PCIE_CLK_GEN1_DIS			GENMASK(30, 24)
+#define PCIE_CLK_GEN1_EN			(BIT(27) | BIT(25))
+#define MEMORY_BASE					0x0
 
 /**
  * struct mt7621_pcie_port - PCIe port information
Signature · 1 line
2.19.1
#1 lore raw
Quoted 1 line · Emanuel Bennici

Apply Kernel Coding Style to pci-mt7621.c by adding Tabs

which part of Coding Style are you applying here? All these macros already are perfectly lined up with Tabs. You are adding an extra Tab to each line - why?

Thanks,
NeilBrown

Quoted 109 lines
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 70 ++++++++++++-------------
 1 file changed, 35 insertions(+), 35 deletions(-)
drivers/staging/mt7621-pci/pci-mt7621.c +35 -35
index 379ae780c691..c5d9b7204aef 100644
@@ -34,16 +34,16 @@
 #include "../../pci/pci.h"
 
 /* sysctl */
-#define MT7621_CHIP_REV_ID		0x0c
-#define CHIP_REV_MT7621_E2		0x0101
+#define MT7621_CHIP_REV_ID			0x0c
+#define CHIP_REV_MT7621_E2			0x0101
 
 /* MediaTek specific configuration registers */
-#define PCIE_FTS_NUM			0x70c
-#define PCIE_FTS_NUM_MASK		GENMASK(15, 8)
-#define PCIE_FTS_NUM_L0(x)		((x) & 0xff << 8)
+#define PCIE_FTS_NUM				0x70c
+#define PCIE_FTS_NUM_MASK			GENMASK(15, 8)
+#define PCIE_FTS_NUM_L0(x)			((x) & 0xff << 8)
 
 /* rt_sysc_membase relative registers */
-#define RALINK_PCIE_CLK_GEN		0x7c
+#define RALINK_PCIE_CLK_GEN			0x7c
 #define RALINK_PCIE_CLK_GEN1		0x80
 
 /* Host-PCI bridge registers */
@@ -51,44 +51,44 @@
 #define RALINK_PCI_PCIMSK_ADDR		0x000C
 #define RALINK_PCI_CONFIG_ADDR		0x0020
 #define RALINK_PCI_CONFIG_DATA		0x0024
-#define RALINK_PCI_MEMBASE		0x0028
-#define RALINK_PCI_IOBASE		0x002C
+#define RALINK_PCI_MEMBASE			0x0028
+#define RALINK_PCI_IOBASE			0x002C
 
 /* PCICFG virtual bridges */
-#define MT7621_BR0_MASK			GENMASK(19, 16)
-#define MT7621_BR1_MASK			GENMASK(23, 20)
-#define MT7621_BR2_MASK			GENMASK(27, 24)
-#define MT7621_BR_ALL_MASK		GENMASK(27, 16)
-#define MT7621_BR0_SHIFT		16
-#define MT7621_BR1_SHIFT		20
-#define MT7621_BR2_SHIFT		24
+#define MT7621_BR0_MASK				GENMASK(19, 16)
+#define MT7621_BR1_MASK				GENMASK(23, 20)
+#define MT7621_BR2_MASK				GENMASK(27, 24)
+#define MT7621_BR_ALL_MASK			GENMASK(27, 16)
+#define MT7621_BR0_SHIFT			16
+#define MT7621_BR1_SHIFT			20
+#define MT7621_BR2_SHIFT			24
 
 /* PCIe RC control registers */
-#define MT7621_PCIE_OFFSET		0x2000
-#define MT7621_NEXT_PORT		0x1000
+#define MT7621_PCIE_OFFSET			0x2000
+#define MT7621_NEXT_PORT			0x1000
 
 #define RALINK_PCI_BAR0SETUP_ADDR	0x0010
 #define RALINK_PCI_IMBASEBAR0_ADDR	0x0018
-#define RALINK_PCI_ID			0x0030
-#define RALINK_PCI_CLASS		0x0034
-#define RALINK_PCI_SUBID		0x0038
-#define RALINK_PCI_STATUS		0x0050
+#define RALINK_PCI_ID				0x0030
+#define RALINK_PCI_CLASS			0x0034
+#define RALINK_PCI_SUBID			0x0038
+#define RALINK_PCI_STATUS			0x0050
 
 /* Some definition values */
-#define PCIE_REVISION_ID		BIT(0)
-#define PCIE_CLASS_CODE			(0x60400 << 8)
-#define PCIE_BAR_MAP_MAX		GENMASK(30, 16)
-#define PCIE_BAR_ENABLE			BIT(0)
-#define PCIE_PORT_INT_EN(x)		BIT(20 + (x))
-#define PCIE_PORT_CLK_EN(x)		BIT(24 + (x))
-#define PCIE_PORT_PERST(x)		BIT(1 + (x))
-#define PCIE_PORT_LINKUP		BIT(0)
-
-#define PCIE_CLK_GEN_EN			BIT(31)
-#define PCIE_CLK_GEN_DIS		0
-#define PCIE_CLK_GEN1_DIS		GENMASK(30, 24)
-#define PCIE_CLK_GEN1_EN		(BIT(27) | BIT(25))
-#define MEMORY_BASE			0x0
+#define PCIE_REVISION_ID			BIT(0)
+#define PCIE_CLASS_CODE				(0x60400 << 8)
+#define PCIE_BAR_MAP_MAX			GENMASK(30, 16)
+#define PCIE_BAR_ENABLE				BIT(0)
+#define PCIE_PORT_INT_EN(x)			BIT(20 + (x))
+#define PCIE_PORT_CLK_EN(x)			BIT(24 + (x))
+#define PCIE_PORT_PERST(x)			BIT(1 + (x))
+#define PCIE_PORT_LINKUP			BIT(0)
+
+#define PCIE_CLK_GEN_EN				BIT(31)
+#define PCIE_CLK_GEN_DIS			0
+#define PCIE_CLK_GEN1_DIS			GENMASK(30, 24)
+#define PCIE_CLK_GEN1_EN			(BIT(27) | BIT(25))
+#define MEMORY_BASE					0x0
 
 /**
  * struct mt7621_pcie_port - PCIe port information
Signature · 1 line
2.19.1