Skip to contentSkip to conversation

rte_ring: add newline to error message

PATCH Superseded Stephen Hemminger 3 participants 5 messages Mar 21, 2019 – Apr 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rte_ring: add newline to error message

Log message should end with newline.

Fixes 4e32101f9b01 ("ring: support freeing")
---
 lib/librte_ring/rte_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/librte_ring/rte_ring.c +2 -1
index d215aceccf46..61534b286b53 100644
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)
 	 * therefore, there is no memzone to free.
 	 */
 	if (r->memzone == NULL) {
-		RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+		RTE_LOG(ERR, RING,
+			"Cannot free ring (not created with rte_ring_create()\n");
 		return;
 	}
 
Signature · 1 line
2.17.1
#2 lore raw
In reply to Stephen Hemminger

22/03/2019 00:03, Stephen Hemminger:

lib/librte_ring/rte_ring.c rte_ring_free(struct rte_ring *r) · line 193

Quoted 8 lines

Log message should end with newline.

Fixes 4e32101f9b01 ("ring: support freeing")

---

lib/librte_ring/rte_ring.c +2 -1
-		RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+		RTE_LOG(ERR, RING,
+			"Cannot free ring (not created with rte_ring_create()\n");

While at it, could you fix the parens?
I think it would be better to replace the first paren with a comma.

#3 lore raw

PATCH v2 1/1 rte_ring: add newline to error message

In reply to Stephen Hemminger

Log message should end with newline.

Fixes 4e32101f9b01 ("ring: support freeing")

---
v2 -- fix punctuation in message as well

 lib/librte_ring/rte_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
lib/librte_ring/rte_ring.c +2 -1
index d215aceccf46..550549db3924 100644
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)
 	 * therefore, there is no memzone to free.
 	 */
 	if (r->memzone == NULL) {
-		RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+		RTE_LOG(ERR, RING,
+			"Cannot free ring, not created with rte_ring_create()\n");
 		return;
 	}
 
Signature · 1 line
2.17.1