rte_ring: add newline to error message
PATCH 1/1 rte_ring: add newline to error message
Log message should end with newline.
Fixes 4e32101f9b01 ("ring: support freeing")
Signed-off-by Stephen Hemminger <[email protected]>
--- lib/librte_ring/rte_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
lib/librte_ring/rte_ring.c +2 -1
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)* therefore, there is no memzone to free. */ if (r->memzone ==NULL ) { -RTE_LOG (ERR ,RING ,"Cannot free ring (not created with rte_ring_create()" ); +RTE_LOG (ERR ,RING , +"Cannot free ring (not created with rte_ring_create()\n" );return ; }
Signature · 1 line
2.17.1
Quoted 6 lines · Stephen Hemminger
Log message should end with newline.
Fixes 4e32101f9b01 ("ring: support freeing")Signed-off-by Stephen Hemminger <[email protected]>---
Reviewed-by Rami Rosen <[email protected]>
22/03/2019 00:03, Stephen Hemminger:
lib/librte_ring/rte_ring.c rte_ring_free(struct rte_ring *r) · line 193
Quoted 8 lines
Log message should end with newline.
Fixes 4e32101f9b01 ("ring: support freeing")Signed-off-by Stephen Hemminger <[email protected]>---
lib/librte_ring/rte_ring.c +2
-1-RTE_LOG (ERR ,RING ,"Cannot free ring (not created with rte_ring_create()" ); +RTE_LOG (ERR ,RING , +"Cannot free ring (not created with rte_ring_create()\n" );
While at it, could you fix the parens?
I think it would be better to replace the first paren with a comma.
PATCH v2 1/1 rte_ring: add newline to error message
In reply to Stephen HemmingerLog message should end with newline.
Fixes 4e32101f9b01 ("ring: support freeing")
Signed-off-by Stephen Hemminger <[email protected]>
Reviewed-by Rami Rosen <[email protected]>
---
v2 -- fix punctuation in message as well
lib/librte_ring/rte_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
lib/librte_ring/rte_ring.c +2 -1
@@ -189,7 +189,8 @@ rte_ring_free(struct rte_ring *r)* therefore, there is no memzone to free. */ if (r->memzone ==NULL ) { -RTE_LOG (ERR ,RING ,"Cannot free ring (not created with rte_ring_create()" ); +RTE_LOG (ERR ,RING , +"Cannot free ring, not created with rte_ring_create()\n" );return ; }
Signature · 1 line
2.17.1
Thomas Monjalon
Applied02/04/2019 17:30, Stephen Hemminger:
Quoted 7 lines
Log message should end with newline.
Fixes 4e32101f9b01 ("ring: support freeing")Signed-off-by Stephen Hemminger <[email protected]>Reviewed-by Rami Rosen <[email protected]>---
v2 -- fix punctuation in message as well
Applied, thanks