arm64: tegra: Add pinmux for PWM-based DFLL support on Shield platform
Subsystems (2)
PATCH 1/2 arm64: tegra: Add pinmux for PWM-based DFLL support on Shield platform
Add pinmux for PWM-based DFLL support on Shield platform.
--- arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi +14 -0
@@ -1318,6 +1318,20 @@ nvidia,open-drain = <TEGRA_PIN_DISABLE>; }; }; + + dvfs_pwm_active_state: dvfs_pwm_active { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + }; + }; + + dvfs_pwm_inactive_state: dvfs_pwm_inactive { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_ENABLE>; + }; + }; }; serial@70006000 {
Signature · 1 line
2.21.0
PATCH 2/2 arm64: tegra: Enable DFLL clock on Shield platform
Enable DFLL clock on Shield platform.
--- .../arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)
arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi +21 -0
@@ -1600,6 +1600,27 @@ status = "okay"; }; + clock@70110000 { + status = "okay"; + + nvidia,cf = <6>; + nvidia,ci = <0>; + nvidia,cg = <2>; + nvidia,droop-ctrl = <0x00000f00>; + nvidia,force-mode = <1>; + nvidia,sample-rate = <25000>; + + nvidia,pwm-min-microvolts = <708000>; + nvidia,pwm-period-nanoseconds = <2500>; /* 2.5us */ + nvidia,pwm-to-pmic; + nvidia,pwm-tristate-microvolts = <1000000>; + nvidia,pwm-voltage-step-microvolts = <19200>; + + pinctrl-names = "dvfs_pwm_enable", "dvfs_pwm_disable"; + pinctrl-0 = <&dvfs_pwm_active_state>; + pinctrl-1 = <&dvfs_pwm_inactive_state>; + }; + clocks { compatible = "simple-bus"; #address-cells = <1>;
Signature · 1 line
2.21.0
Quoted 6 lines · Joseph Lo
Add pinmux for PWM-based DFLL support on Shield platform.
Signed-off-by Joseph Lo <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
There's been some discussion recently about moving away from programming pinmux in the kernel because it isn't always safe to do that. The idea is that early boot firmware (typically cboot) will already have set up the pinmux, so there's no need to do it again in the kernel.
These look like you're going to change this pin to/from tristate at runtime, so perhaps that's the kind of thing that we're okay with?
Adding Stephen for visibility.
Thierry
Quoted 28 lines
arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi +14
-0@@ -1318,6 +1318,20 @@ nvidia,open-drain = <TEGRA_PIN_DISABLE>; }; }; + + dvfs_pwm_active_state: dvfs_pwm_active { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + }; + }; + + dvfs_pwm_inactive_state: dvfs_pwm_inactive { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_ENABLE>; + }; + }; }; serial@70006000 {Signature · 1 line
2.21.0
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 13 lines · Thierry Reding
Quoted 6 lines · Joseph Lo
Add pinmux for PWM-based DFLL support on Shield platform.
Signed-off-by Joseph Lo <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 14 ++++++++++++++ 1 file changed, 14 insertions(+)There's been some discussion recently about moving away from programming pinmux in the kernel because it isn't always safe to do that. The idea is that early boot firmware (typically cboot) will already have set up the pinmux, so there's no need to do it again in the kernel.
Quoted 4 lines
These look like you're going to change this pin to/from tristate at runtime, so perhaps that's the kind of thing that we're okay with?
Adding Stephen for visibility.
Gentle ping.
Thanks,
Joseph
Quoted 31 lines
Thierry
Quoted 28 lines
arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi +14
-0@@ -1318,6 +1318,20 @@ nvidia,open-drain = <TEGRA_PIN_DISABLE>; }; }; + + dvfs_pwm_active_state: dvfs_pwm_active { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + }; + }; + + dvfs_pwm_inactive_state: dvfs_pwm_inactive { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_ENABLE>; + }; + }; }; serial@70006000 {Signature · 1 line
2.21.0
Quoted 14 lines · Joseph Lo
Quoted 13 lines · Thierry Reding
Quoted 6 lines · Joseph Lo
Add pinmux for PWM-based DFLL support on Shield platform.
Signed-off-by Joseph Lo <[email protected]>---
arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi| 14 ++++++++++++++1 file changed, 14 insertions(+)There's been some discussion recently about moving away from programming pinmux in the kernel because it isn't always safe to do that. The idea is that early boot firmware (typically cboot) will already have set up the pinmux, so there's no need to do it again in the kernel.
Quoted 7 lines
Quoted 4 lines
These look like you're going to change this pin to/from tristate at runtime, so perhaps that's the kind of thing that we're okay with?
Adding Stephen for visibility.
Gentle ping.
If there is no further objection, could we apply this series?
Thanks,
Joseph
Quoted 25 lines
Quoted 25 lines
Quoted 25 lines
arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi +14
-0@@ -1318,6 +1318,20 @@ nvidia,open-drain = <TEGRA_PIN_DISABLE>; }; }; + + dvfs_pwm_active_state: dvfs_pwm_active { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + }; + }; + + dvfs_pwm_inactive_state: dvfs_pwm_inactive { + dvfs_pwm_pbb1 { + nvidia,pins = "dvfs_pwm_pbb1"; + nvidia,tristate = <TEGRA_PIN_ENABLE>; + }; + }; }; serial@70006000 {
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Signature · 1 line
2.21.0_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel