thunderbolt: xdomain: Fix to check return value of kmemdup
Subsystems (4)
PATCH v2 1/1 thunderbolt: xdomain: Fix to check return value of kmemdup
kmemdup can fail and return a NULL pointer. The patch modifies the signature of tb_xdp_schedule_request and passes the failure error upstream.
Signed-off-by Aditya Pakki <[email protected]>
---
v1: Missed clean up of xw in case of kmemdup failure, per David
--- drivers/thunderbolt/xdomain.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/thunderbolt/xdomain.c +9 -6
@@ -526,7 +526,7 @@ static void tb_xdp_handle_request(struct work_struct *work)kfree (xw); } -static void +static bool tb_xdp_schedule_request (struct tb *tb,const struct tb_xdp_header *hdr,size_t size) {
@@ -534,13 +534,18 @@ tb_xdp_schedule_request(struct tb *tb, const struct tb_xdp_header *hdr, xw =kmalloc (sizeof (*xw),GFP_KERNEL );if (!xw) -return ; +return false;INIT_WORK (&xw->work, tb_xdp_handle_request); xw->pkg =kmemdup (hdr, size,GFP_KERNEL ); +if (!xw->pkg) { +kfree (xw); +return false; + } xw->tb = tb;queue_work (tb->wq, &xw->work); +return true; }/**
@@ -1416,10 +1421,8 @@ bool tb_xdomain_handle_request(struct tb *tb, enum tb_cfg_pkg_type type,* handlers in turn. */ if (uuid_equal (&hdr->uuid, &tb_xdp_uuid)) { -if (type ==TB_CFG_PKG_XDOMAIN_REQ ) { -tb_xdp_schedule_request (tb, hdr, size); -return true; - } +if (type ==TB_CFG_PKG_XDOMAIN_REQ ) +return tb_xdp_schedule_request (tb, hdr, size);return false; }
Signature · 1 line
2.17.1
Mika Westerberg
AppliedQuoted 4 lines · Aditya Pakki
kmemdup can fail and return a NULL pointer. The patch modifies the signature of
tb_xdp_schedule_requestand passes the failure error upstream.Signed-off-by Aditya Pakki <[email protected]>
Applied, thanks!